Anthony Liguori
2006-Mar-23 19:59 UTC
[Xen-devel] Re: [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass
Xen patchbot -unstable wrote:> # HG changeset patch > # User emellor@leeni.uk.xensource.com > # Node ID d52a93ee4624b0fae694353251622af2eb51dabc > # Parent 8afbc25861219578fae30cc2a9bd60bf2ab26349 > Removed unused handler parameter from UnixXMLRPCServer interface -- just pass > UnixXMLRPCRequestHandler through to TCPXMLRPCServer. > > Do not log requests -- this fills up xend-debug.log uselessly. > > Signed-off-by: Ewan Mellor <ewan@xensource.com> > > diff -r 8afbc2586121 -r d52a93ee4624 tools/python/xen/xend/server/XMLRPCServer.py > --- a/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 10:30:33 2006 > +++ b/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 10:40:43 2006 > @@ -13,6 +13,7 @@ > # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > #===========================================================================> # Copyright (C) 2006 Anthony Liguori <aliguori@us.ibm.com> > +# Copyright (C) 2006 XenSource Ltd > #===========================================================================> > from xen.xend import XendDomain, XendDomainInfo, XendNode, \ > @@ -69,9 +70,9 @@ > if self.use_tcp: > # bind to something fixed for now as we may eliminate > # tcp support completely. > - self.server = TCPXMLRPCServer(("localhost", 8005)) > + self.server = TCPXMLRPCServer(("localhost", 8005, False)) >This should be: self.server = TCPXMLRPCServer(("localhost", 8005), False) Regards, Anthony Liguori> else: > - self.server = UnixXMLRPCServer(XML_RPC_SOCKET) > + self.server = UnixXMLRPCServer(XML_RPC_SOCKET, False) > > # Functions in XendDomainInfo > for name in methods: > > _______________________________________________ > Xen-changelog mailing list > Xen-changelog@lists.xensource.com > http://lists.xensource.com/xen-changelog >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Anthony Liguori
2006-Mar-23 20:05 UTC
Re: [Xen-devel] Re: [Xen-changelog] Removed unused handler parameter from UnixXMLRPCServer interface -- just pass
Anthony Liguori wrote:> Xen patchbot -unstable wrote: >> # HG changeset patch >> # User emellor@leeni.uk.xensource.com >> # Node ID d52a93ee4624b0fae694353251622af2eb51dabc >> # Parent 8afbc25861219578fae30cc2a9bd60bf2ab26349 >> Removed unused handler parameter from UnixXMLRPCServer interface -- >> just pass >> UnixXMLRPCRequestHandler through to TCPXMLRPCServer. >> >> Do not log requests -- this fills up xend-debug.log uselessly. >> >> Signed-off-by: Ewan Mellor <ewan@xensource.com> >> >> diff -r 8afbc2586121 -r d52a93ee4624 >> tools/python/xen/xend/server/XMLRPCServer.py >> --- a/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 >> 10:30:33 2006 >> +++ b/tools/python/xen/xend/server/XMLRPCServer.py Thu Mar 23 >> 10:40:43 2006 >> @@ -13,6 +13,7 @@ >> # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA >> 02111-1307 USA >> #============================================================================ >> >> # Copyright (C) 2006 Anthony Liguori <aliguori@us.ibm.com> >> +# Copyright (C) 2006 XenSource Ltd >> #============================================================================ >> >> >> from xen.xend import XendDomain, XendDomainInfo, XendNode, \ >> @@ -69,9 +70,9 @@ >> if self.use_tcp: >> # bind to something fixed for now as we may eliminate >> # tcp support completely. >> - self.server = TCPXMLRPCServer(("localhost", 8005)) >> + self.server = TCPXMLRPCServer(("localhost", 8005, False)) >> > > This should be: > > self.server = TCPXMLRPCServer(("localhost", 8005), False)Sorry, it should actually be: self.server = TCPXMLRPCServer(("localhost, 8005), logRequests=False) Regards, Anthony Liguori> Regards, > > Anthony Liguori > >> else: >> - self.server = UnixXMLRPCServer(XML_RPC_SOCKET) >> + self.server = UnixXMLRPCServer(XML_RPC_SOCKET, False) >> >> # Functions in XendDomainInfo >> for name in methods: >> >> _______________________________________________ >> Xen-changelog mailing list >> Xen-changelog@lists.xensource.com >> http://lists.xensource.com/xen-changelog >> > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel