WM> Fix init of report file for runtest.sh Good, this is definitely needed because people are accidentally submitting duplicate results when they use the same logfile name with runtest.sh multiple times.> - echo "*** case $casename from group $groupentered" >> $output > + echo "*** case $casename from group $groupentered" > $output > if [ -z "$testlist" ]; then > - echo "*** Running tests for case $casename" >> $output > - (cd tests/$casename && TEST_VERBOSE=1 make -k check) >> $output 2>&1 > + echo "*** Running tests for case $casename" > $output > + (cd tests/$casename && TEST_VERBOSE=1 make -k check) > $output 2>&1 > else > - echo "*** Running tests $testlist from case $casename" >> $output > - (cd tests/$casename && TEST_VERBOSE=1 make -k check TESTS="$testlist") >> $output 2>&1 > + echo "*** Running tests $testlist from case $casename" > $output > + (cd tests/$casename && TEST_VERBOSE=1 make -k check TESTS="$testlist") > $output 2>&1By changing every one of the redirects to ''>'' instead of ''>>'', you will clobber the output file each time, which means that only the last test group will actually be reported in the log file! How did this pass a sniff test? -- Dan Smith IBM Linux Technology Center Open Hypervisor Team email: danms@us.ibm.com _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
Fix init of report file for runtest.sh Signed-off-by: Woody Marvel <marvel@us.ibm.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel
woody marvel
2006-Mar-15 00:13 UTC
Re: [Xen-devel] [PATCH][XM-TEST] init xmtest report files
Apologies, I will be more fastidious next time. wm ===========On Tue, 2006-03-14 at 15:59 -0800, Dan Smith wrote:> WM> Fix init of report file for runtest.sh > > Good, this is definitely needed because people are accidentally > submitting duplicate results when they use the same logfile name with > runtest.sh multiple times. > > > - echo "*** case $casename from group $groupentered" >> $output > > + echo "*** case $casename from group $groupentered" > $output > > if [ -z "$testlist" ]; then > > - echo "*** Running tests for case $casename" >> $output > > - (cd tests/$casename && TEST_VERBOSE=1 make -k check) >> $output 2>&1 > > + echo "*** Running tests for case $casename" > $output > > + (cd tests/$casename && TEST_VERBOSE=1 make -k check) > $output 2>&1 > > else > > - echo "*** Running tests $testlist from case $casename" >> $output > > - (cd tests/$casename && TEST_VERBOSE=1 make -k check TESTS="$testlist") >> $output 2>&1 > > + echo "*** Running tests $testlist from case $casename" > $output > > + (cd tests/$casename && TEST_VERBOSE=1 make -k check TESTS="$testlist") > $output 2>&1 > > By changing every one of the redirects to ''>'' instead of ''>>'', you > will clobber the output file each time, which means that only the last > test group will actually be reported in the log file! > > How did this pass a sniff test? >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel