xen/ia64 uaccess is still linux style with different declaration as common xen. It''s meaningless to patch original file with many #ifdef XEN, and so instead copy that file to create a new xen specific uaccess file, with unused lines removed. May need render later. Or else it breaks compilation on xen-unstable. Signed-off-by Kevin Tian <kevin.tian@intel.com> Thanks, Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel
On 27 Feb 2006, at 13:15, Tian, Kevin wrote:> xen/ia64 uaccess is still linux style with different declaration as > common xen. It''s meaningless to patch original file with many #ifdef > XEN, and so instead copy that file to create a new xen specific > uaccess file, with unused lines removed. May need render later. > > Or else it breaks compilation on xen-unstable. > > Signed-off-by Kevin Tian <kevin.tian@intel.com>Please, unless you are fixing a regression in unstable, these patches should be going to the ia64 mailing list and initially should be applied to the ia64-unstable tree. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel
>From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >Sent: 2006年2月27日 21:51 > > >On 27 Feb 2006, at 13:15, Tian, Kevin wrote: > >> xen/ia64 uaccess is still linux style with different declaration as >> common xen. It''s meaningless to patch original file with many #ifdef >> XEN, and so instead copy that file to create a new xen specific >> uaccess file, with unused lines removed. May need render later. >> >> Or else it breaks compilation on xen-unstable. >> >> Signed-off-by Kevin Tian <kevin.tian@intel.com> > >Please, unless you are fixing a regression in unstable, these patches >should be going to the ia64 mailing list and initially should be >applied to the ia64-unstable tree. > > -- KeirYes, that''s the fix to regression in unstable. Though the issue exists for a long time, but common code never triggers it until yesterday. ;-) Thanks, Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel
On 27 Feb 2006, at 14:40, Tian, Kevin wrote:>> Please, unless you are fixing a regression in unstable, these patches >> should be going to the ia64 mailing list and initially should be >> applied to the ia64-unstable tree. >> >> -- Keir > > Yes, that''s the fix to regression in unstable. Though the issue exists > for a long time, but common code never triggers it until yesterday. > ;-)Ah, okay, then I''ll apply it. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel
>From: Keir Fraser [mailto:Keir.Fraser@cl.cam.ac.uk] >Sent: 2006年2月27日 23:18 >On 27 Feb 2006, at 14:40, Tian, Kevin wrote: > >>> Please, unless you are fixing a regression in unstable, these patches >>> should be going to the ia64 mailing list and initially should be >>> applied to the ia64-unstable tree. >>> >>> -- Keir >> >> Yes, that''s the fix to regression in unstable. Though the issue exists >> for a long time, but common code never triggers it until yesterday. >> ;-) > >Ah, okay, then I''ll apply it. :-) > > -- KeirThanks a lot. Kevin _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel
>>> Please, unless you are fixing a regression in unstable, >these patches >>> should be going to the ia64 mailing list and initially should be >>> applied to the ia64-unstable tree. >>> >>> -- Keir >> >> Yes, that''s the fix to regression in unstable. Though the >issue exists >> for a long time, but common code never triggers it until yesterday. >> ;-) > >Ah, okay, then I''ll apply it. :-) >When more archs are introduced into xen, maybe a guideline is perferred to unify the code structure. Thanks -Xin> -- Keir > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >lists.xensource.com/xen-devel >_______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com lists.xensource.com/xen-devel