The attached patch apic.patch updates xen/arch/x86/apic.c so that it is based on linux 2.6.10 code. The patch is a bit ugly because rather than removing the unused code, it is surround by #if 0 ... #endif as was requested. There were a few changes to function declarations and the like which would require altering other files as well. I held off on those changes since I didn''t want to throw too much in here at once. The new apic.c includes two new files: asm/io_ports.h and asm/mach_apic.h. Patches to create those files are included as well. Again, mach_apic.h is mostly #if''d out but much of that code can/will be used as xen functionality is updated. Finally, xen/ac_timer.h was included but not needed by apic.c so I removed it from the list of #includes. Natasha
I forgot the signed-off-by line on that previous email. if there are no major objections to the patch itself I will resend. sorry about that. Natasha ------------------------------------------------------- This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) & Windows Mobile(tm) platforms, applications & content. Register by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
Natasha, It didn''t apply totally cleanly, but I fixed it up, and it booted OK for me. How much testing have you been able to give the patch? I''m not sure that some of the #if 0''s are actually going to help from a maintenance POV, so it might actually be better to remove any whole functions etc that aren''t used. Please can you resend with a signed-off-by line, and as a single patch. Thanks, Ian> -----Original Message----- > From: xen-devel-admin@lists.sourceforge.net > [mailto:xen-devel-admin@lists.sourceforge.net] On Behalf Of > Natasha Jarymowycz > Sent: 24 March 2005 13:57 > To: xen-devel@lists.sourceforge.net > Subject: Re: [Xen-devel] [PATCH]local apic initialization > > I forgot the signed-off-by line on that previous email. if there > are no major objections to the patch itself I will resend. sorry > about that. > > Natasha > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by Microsoft Mobile & Embedded > DevCon 2005 > Attend MEDC 2005 May 9-12 in Vegas. Learn more about the > latest Windows > Embedded(r) & Windows Mobile(tm) platforms, applications & > content. Register > by 3/29 & save $300 > http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/xen-devel >------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On 25 Mar 2005, at 21:23, Ian Pratt wrote:> It didn''t apply totally cleanly, but I fixed it up, and it booted OK > for > me. > > How much testing have you been able to give the patch? > > I''m not sure that some of the #if 0''s are actually going to help from a > maintenance POV, so it might actually be better to remove any whole > functions etc that aren''t used.I''d make it a pre-condition of acceptance: the patch will be much smaller since a lot of the added code fragments are actually if 0''ed out. It makes it hard to work out what moving parts have actually changed. -- Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel