Xen devel - Mar 2005 - how to avoid building ACPI?

Hi, what''s the best way in the Xen build system to avoid building 
xen/drivers/acpi on non-x86 architectures? Both xen/drivers/Makefile and 
xen/Rules.mk hardcode something about ACPI.

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

On 18 Mar 2005, at 22:05, Hollis Blanchard wrote:
> Hi, what''s the best way in the Xen build system to avoid building
> xen/drivers/acpi on non-x86 architectures? Both xen/drivers/Makefile 
> and
> xen/Rules.mk hardcode something about ACPI.
See what we did in common/Makefile to avoid building certain files on 
ia64.

  -- Keir



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel

On Saturday 19 March 2005 04:23, Keir Fraser wrote:
> On 18 Mar 2005, at 22:05, Hollis Blanchard wrote:
> > Hi, what''s the best way in the Xen build system to avoid
building
> > xen/drivers/acpi on non-x86 architectures? Both xen/drivers/Makefile
> > and
> > xen/Rules.mk hardcode something about ACPI.
>
> See what we did in common/Makefile to avoid building certain files on
> ia64.
How''s this? I''ve verified that x86 still builds.

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

-- 
Hollis Blanchard
IBM Linux Technology Center

Any comments on that patch?

Of course, the Linux way avoids the ifdefs entirely, and would look something 
like this:

    DIRS-y := char pci
    DIRS-$(HAS_ACPI) += acpi

    default:
        for DIR in $(DIRS-y) ; do $(MAKE) -C $$DIR ; done

Do you prefer that?

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------
This SF.net email is sponsored by: 2005 Windows Mobile Application Contest
Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones
for the chance to win $25,000 and application distribution. Enter today at
http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xen-devel