Since xen uses -Wall -Werror, gcc4 refuses to compile areas of the code where "char *" and "unsigned char *" are used in a mixed fashion. This is a problem since xen uses "unsigned char *" for many string functions, but the x86 string implementation uses the (standard) "char *" and the generic string implementation uses the (non-standard?) "unsigned char *". I''m willing to do the work to standardise on one, if the Xen maintainers think this is worth doing. Otherwise I''ll just get rid of the -Werror for now ... -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
> Since xen uses -Wall -Werror, gcc4 refuses to compile areas > of the code where "char *" and "unsigned char *" are used in a > mixed fashion. > > This is a problem since xen uses "unsigned char *" for many > string functions, but the x86 string implementation uses > the (standard) "char *" and the generic string implementation > uses the (non-standard?) "unsigned char *". > > I''m willing to do the work to standardise on one, if the Xen > maintainers think this is worth doing. Otherwise I''ll just > get rid of the -Werror for now ...I''m a big fan of -Werror. It sounds like we should change the generic string implementation. Best, Ian ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On Thu, 3 Mar 2005, Ian Pratt wrote:> > Since xen uses -Wall -Werror, gcc4 refuses to compile areas > > of the code where "char *" and "unsigned char *" are used in a > > mixed fashion.> I''m a big fan of -Werror. > > It sounds like we should change the generic string implementation.OK, I''ll start patch spamming the list ;) -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On 3 Mar 2005, at 19:38, Rik van Riel wrote:> I''m willing to do the work to standardise on one, if the Xen > maintainers think this is worth doing. Otherwise I''ll just > get rid of the -Werror for now ...Please choose the easiest one to standardise on and send us a patch. Thanks, Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On Fri, 4 Mar 2005, Keir Fraser wrote:> On 3 Mar 2005, at 19:38, Rik van Riel wrote: > > > I''m willing to do the work to standardise on one, if the Xen > > maintainers think this is worth doing. Otherwise I''ll just > > get rid of the -Werror for now ... > > Please choose the easiest one to standardise on and send us a patch.In doubt, I follow whatever is specified in the glibc man pages ;) -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel