Fix gcc4 compile error. arch/xen/i386/kernel/smpboot.c:72: error: static declaration of ''cpu_callin_map'' follows non-static declaration include/asm/smp.h:56: error: previous declaration of ''cpu_callin_map'' was here Signed-off-by: Rik van Riel <riel@redhat.com> Signed-off-by: David Woodhouse <dwmw2@redhat.com> --- linux-2.6.10/arch/xen/i386/kernel/smpboot.c~ 2005-03-01 11:36:31.000000000 +0000 +++ linux-2.6.10/arch/xen/i386/kernel/smpboot.c 2005-03-01 12:56:44.454092184 +0000 @@ -69,7 +69,7 @@ /* bitmap of online cpus */ cpumask_t cpu_online_map; -static cpumask_t cpu_callin_map; +cpumask_t cpu_callin_map; cpumask_t cpu_callout_map; static cpumask_t smp_commenced_mask; ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On 1 Mar 2005, at 15:21, Rik van Riel wrote:> Fix gcc4 compile error. > > arch/xen/i386/kernel/smpboot.c:72: error: static declaration of > ''cpu_callin_map'' follows non-static declaration > include/asm/smp.h:56: error: previous declaration of ''cpu_callin_map'' > was here > > Signed-off-by: Rik van Riel <riel@redhat.com> > Signed-off-by: David Woodhouse <dwmw2@redhat.com>The patch has finally made it through sourceforge, so I''ll respond to it on the list also. This kind of patch should properly be applied to arch/i386, at which point we will pull it through into arch/xen/i386 as part of our normal update/sync process. Particularly in this case, since the patch can hardly be considered critical. -- Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On Tue, 1 Mar 2005, Keir Fraser wrote:> > arch/xen/i386/kernel/smpboot.c:72: error: static declaration of > > ''cpu_callin_map'' follows non-static declaration > > include/asm/smp.h:56: error: previous declaration of ''cpu_callin_map'' was > > here> This kind of patch should properly be applied to arch/i386, at which > point we will pull it through into arch/xen/i386 as part of our normal > update/sync process. Particularly in this case, since the patch can > hardly be considered critical.It already has been applied to arch/i386. I''ll gladly keep it around until 2.6.11 time though, when Xen will get it from arch/i386 automatically. -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel
On 1 Mar 2005, at 20:56, Rik van Riel wrote:>> This kind of patch should properly be applied to arch/i386, at which >> point we will pull it through into arch/xen/i386 as part of our normal >> update/sync process. Particularly in this case, since the patch can >> hardly be considered critical. > > It already has been applied to arch/i386. I''ll gladly > keep it around until 2.6.11 time though, when Xen will > get it from arch/i386 automatically.Excellent, thanks. We run a little behind Fedora Rawhide. :-) -- Keir ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click _______________________________________________ Xen-devel mailing list Xen-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xen-devel