Xapian devel - Dec 2006 - Re: [Xapian-commits] 7575: trunk/xapian-core/ trunk/xapian-core/include/xapian/

On Wed, Dec 13, 2006 at 06:09:49PM +0000, richard wrote:
> Improve documentation comment for Document::get_value().
Further to this improvement, I wonder if the "must be >= 0" should
be
dropped.  Xapian::valueno is an unsigned type, so you effectively can't
pass a negative value in (if you do it'll be converted to a large
positive value and would work if used consistently).  Thoughts?

Cheers,
    Olly

Olly Betts wrote:
> On Wed, Dec 13, 2006 at 06:09:49PM +0000, richard wrote:
>> Improve documentation comment for Document::get_value().
> 
> Further to this improvement, I wonder if the "must be >= 0"
should be
> dropped.  Xapian::valueno is an unsigned type, so you effectively can't
> pass a negative value in (if you do it'll be converted to a large
> positive value and would work if used consistently).  Thoughts?
Yes, that makes sense.  I didn't think to check if Xapian::valueno was 
unsigned.  I'll fix it.