Xapian devel - Jan 2007 - Re: [Xapian-commits] 7603: trunk/xapian-core/ trunk/xapian-core/backends/flint/ trunk/xapian-core/backends/quartz/

On Tue, Jan 02, 2007 at 03:55:59PM +0000, richard wrote:
> * backends/quartz/btree.cc,backends/flint/flint_io.h: Patches from
>   Charlie Hull to allow 2GB+ index files work when compiled using
>   Visual C++.
I suspect that xapian-compact.cc (and quartzcompact.cc if you can be
bothered) will also need fixing since they use off_t.  You need to make
sure that the stat() function called works for 2GB+ files.  Without this
compression statistics don't get reported for such files.

Cheers,
    Olly

Olly Betts wrote:
> On Tue, Jan 02, 2007 at 03:55:59PM +0000, richard wrote:
>> * backends/quartz/btree.cc,backends/flint/flint_io.h: Patches from
>>   Charlie Hull to allow 2GB+ index files work when compiled using
>>   Visual C++.
> 
> I suspect that xapian-compact.cc (and quartzcompact.cc if you can be
> bothered) will also need fixing since they use off_t.  You need to make
> sure that the stat() function called works for 2GB+ files.  Without this
> compression statistics don't get reported for such files.
> 
> Cheers,
>     Olly
> 
I've produced patches for xapian-compact.cc, quartzcompact.cc and 
quartzcheck.cc (enclosed). Unfortunately I don't have any way of quickly 
testing them here but we should soon have some kind of Xapian test 
framework on Windows, complete with huge files, so I'll do it then.

Charlie
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: quartzcheck.cc.diff
URL:
<http://lists.xapian.org/pipermail/xapian-devel/attachments/20070129/fa86514f/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: xapian-compact.cc.diff
URL:
<http://lists.xapian.org/pipermail/xapian-devel/attachments/20070129/fa86514f/attachment-0001.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: quartzcompact.cc.diff
URL:
<http://lists.xapian.org/pipermail/xapian-devel/attachments/20070129/fa86514f/attachment-0002.ksh>