What do I need to do to be able to contribute patches?
Thanks,
Joe
_______________________________________________
wxruby-users mailing list
wxruby-users@rubyforge.org
http://rubyforge.org/mailman/listinfo/wxruby-users
Hi Joe Seeley wrote:> What do I need to do to be able to contribute patches?Patches are very welcome; please submit them to the mailing list and one of the committers will review and commit them. The standard procedure people generally use to create patches is: /#first login to cvs server //cvs -d :pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby login/ / //#for convenience set your CVSROOT //#Unix //export CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby// //#Windows //set CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby // # if, for example, the file you changed was swig/common.i //# change directory to the directory above the wxruby2 root directory and do: //cvs diff -r HEAD -b -u wxruby2/swig/common.i > common.i.patch/// # If you''ve changed multiple files, you can combine them into one patch //cvs diff -r HEAD -b -u wxruby2/first_file wxruby2/second_file > combined.patch // Once you''ve created the patch, just send it as an attachment to the mailing list. If your change requires adding new files (e.g. a new .i interface file), just add these as attachments and note where they should go, if it''s not obvious. Please put a short description of what the patch is intended to achieve in your email, and, if appropriate, please include a test case or sample that tests out the functionality you''re adding or fixing. I think it also helps the committers if you collect related changes into a single email, and keep the patches in one email related to a single topic. Thanks - cheers alex [1] http://rubyforge.org/pipermail/wxruby-users/2005-August/001580.html
This is an awesome email. Can you put this info in the wiki so we can point folks to it as needed? Having never submitted a patch, I can''t vouch for the technical details, but conceptually it all looks right to me. If you are adding a new class, definitely add some tests of it to one of the samples, or create a new sample. If you are fixing something, it really helps me if you can briefly describe how I can see the problem, and then see that the patch fixed it. Thanks! Kevin On Wed, 2006-08-16 at 00:48 +0100, Alex Fenton wrote:> Hi > > Joe Seeley wrote: > > What do I need to do to be able to contribute patches? > Patches are very welcome; please submit them to the mailing list and one > of the committers will review and commit them. > > The standard procedure people generally use to create patches is: > > /#first login to cvs server > //cvs -d :pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby login/ > / > //#for convenience set your CVSROOT > //#Unix > //export CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby// > //#Windows > //set CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby > // > # if, for example, the file you changed was swig/common.i > //# change directory to the directory above the wxruby2 root directory and do: > //cvs diff -r HEAD -b -u wxruby2/swig/common.i > common.i.patch/// > > # If you''ve changed multiple files, you can combine them into one patch > //cvs diff -r HEAD -b -u wxruby2/first_file wxruby2/second_file > combined.patch > > // > > Once you''ve created the patch, just send it as an attachment to the > mailing list. If your change requires adding new files (e.g. a new .i > interface file), just add these as attachments and note where they > should go, if it''s not obvious. > > Please put a short description of what the patch is intended to achieve > in your email, and, if appropriate, please include a test case or sample > that tests out the functionality you''re adding or fixing. > > I think it also helps the committers if you collect related changes into > a single email, and keep the patches in one email related to a single topic. > > Thanks - > cheers > alex > > [1] http://rubyforge.org/pipermail/wxruby-users/2005-August/001580.html > > > > > _______________________________________________ > wxruby-users mailing list > wxruby-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users
I put it up on the Wiki: http://wxruby.rubyforge.org/wiki/wiki.pl?How_To_Create_And_Submit_Patches Sean On 8/15/06, Kevin Smith <wxruby at qualitycode.com> wrote:> This is an awesome email. Can you put this info in the wiki so we can > point folks to it as needed? > > Having never submitted a patch, I can''t vouch for the technical details, > but conceptually it all looks right to me. > > If you are adding a new class, definitely add some tests of it to one of > the samples, or create a new sample. If you are fixing something, it > really helps me if you can briefly describe how I can see the problem, > and then see that the patch fixed it. > > Thanks! > > Kevin > > > On Wed, 2006-08-16 at 00:48 +0100, Alex Fenton wrote: > > Hi > > > > Joe Seeley wrote: > > > What do I need to do to be able to contribute patches? > > Patches are very welcome; please submit them to the mailing list and one > > of the committers will review and commit them. > > > > The standard procedure people generally use to create patches is: > > > > /#first login to cvs server > > //cvs -d :pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby login/ > > / > > //#for convenience set your CVSROOT > > //#Unix > > //export CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby// > > //#Windows > > //set CVSROOT=:pserver:anonymous at rubyforge.org <http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby > > // > > # if, for example, the file you changed was swig/common.i > > //# change directory to the directory above the wxruby2 root directory and do: > > //cvs diff -r HEAD -b -u wxruby2/swig/common.i > common.i.patch/// > > > > # If you''ve changed multiple files, you can combine them into one patch > > //cvs diff -r HEAD -b -u wxruby2/first_file wxruby2/second_file > combined.patch > > > > // > > > > Once you''ve created the patch, just send it as an attachment to the > > mailing list. If your change requires adding new files (e.g. a new .i > > interface file), just add these as attachments and note where they > > should go, if it''s not obvious. > > > > Please put a short description of what the patch is intended to achieve > > in your email, and, if appropriate, please include a test case or sample > > that tests out the functionality you''re adding or fixing. > > > > I think it also helps the committers if you collect related changes into > > a single email, and keep the patches in one email related to a single topic. > > > > Thanks - > > cheers > > alex > > > > [1] http://rubyforge.org/pipermail/wxruby-users/2005-August/001580.html > > > > > > > > > > _______________________________________________ > > wxruby-users mailing list > > wxruby-users at rubyforge.org > > http://rubyforge.org/mailman/listinfo/wxruby-users > > _______________________________________________ > wxruby-users mailing list > wxruby-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users >
Alex, Thanks for the info! Joe On 8/15/06, Alex Fenton <alex at pressure.to> wrote:> > Hi > > Joe Seeley wrote: > > What do I need to do to be able to contribute patches? > Patches are very welcome; please submit them to the mailing list and one > of the committers will review and commit them. > > The standard procedure people generally use to create patches is: > > /#first login to cvs server > //cvs -d :pserver:anonymous at rubyforge.org < > http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby login/ > / > //#for convenience set your CVSROOT > //#Unix > //export CVSROOT=:pserver:anonymous at rubyforge.org < > http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby// > //#Windows > //set CVSROOT=:pserver:anonymous at rubyforge.org < > http://rubyforge.org/mailman/listinfo/wxruby-users>:/var/cvs/wxruby > // > # if, for example, the file you changed was swig/common.i > //# change directory to the directory above the wxruby2 root directory and > do: > //cvs diff -r HEAD -b -u wxruby2/swig/common.i > common.i.patch/// > > # If you''ve changed multiple files, you can combine them into one patch > //cvs diff -r HEAD -b -u wxruby2/first_file wxruby2/second_file > > combined.patch > > // > > Once you''ve created the patch, just send it as an attachment to the > mailing list. If your change requires adding new files (e.g. a new .i > interface file), just add these as attachments and note where they > should go, if it''s not obvious. > > Please put a short description of what the patch is intended to achieve > in your email, and, if appropriate, please include a test case or sample > that tests out the functionality you''re adding or fixing. > > I think it also helps the committers if you collect related changes into > a single email, and keep the patches in one email related to a single > topic. > > Thanks - > cheers > alex > > [1] http://rubyforge.org/pipermail/wxruby-users/2005-August/001580.html > > > > > _______________________________________________ > wxruby-users mailing list > wxruby-users at rubyforge.org > http://rubyforge.org/mailman/listinfo/wxruby-users >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/wxruby-users/attachments/20060816/4b0e9a54/attachment.html