thr3ads.net - wxruby users - Patch files to implement AcceptFocus [Sep 2006]

If this information is useful, please help other people find it:
Share via:

Roy Sutton

2006-Sep-03 04:07 UTC

Patch files to implement AcceptFocus

These files add the virtual function AcceptFocus that was missing from 
wxWindow.h.  In order to make things right I had to make sure it was 
also declared in all the places where wxWindows also changes it.  Also, 
in wxTextCtrl on Windows GetDefaultAttributes needs to be redeclared.  I 
haven''t downloaded the Unix and Mac headers for 2.6.3 so I
couldn''t see
if it also applies to other installs.  You should check.  In a couple 
places AcceptFocus is #ifdef''ed to only affect Windows, for the same 
reason.  I don''t -think- there''s any harm in redeclaring it
even if it''s
not redeclared but I didn''t want to chance it.  I''m trying to
keep these
patches more bite-sized and focused on a specific problem area.  If we 
can get this applied I can work on the next set.

Roy













_______________________________________________
wxruby-users mailing list
wxruby-users@rubyforge.org
http://rubyforge.org/mailman/listinfo/wxruby-users

Roy Sutton

2006-Sep-03 06:32 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Well, I see the patch files are all hosed up.  I''ll redo them and
resubmit.

<mutter>

Roy Sutton wrote:> These files add the virtual function AcceptFocus that was missing from 
> wxWindow.h.  In order to make things right I had to make sure it was 
> also declared in all the places where wxWindows also changes it.  
> Also, in wxTextCtrl on Windows GetDefaultAttributes needs to be 
> redeclared.  I haven''t downloaded the Unix and Mac headers for
2.6.3
> so I couldn''t see if it also applies to other installs.  You
should
> check.  In a couple places AcceptFocus is #ifdef''ed to only affect
> Windows, for the same reason.  I don''t -think- there''s
any harm in
> redeclaring it even if it''s not redeclared but I didn''t
want to chance
> it.  I''m trying to keep these patches more bite-sized and focused
on a
> specific problem area.  If we can get this applied I can work on the 
> next set.
>
> Roy
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxWindow.h
> Index: wxruby2/swig/classes/include/wxWindow.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxWindow.h,v
> retrieving revision 1.13
> diff -b -u -r1.13 wxWindow.h
> --- wxruby2/swig/classes/include/wxWindow.h	26 Aug 2006 03:58:57 -0000	1.13
> +++ wxruby2/swig/classes/include/wxWindow.h	3 Sep 2006 04:01:53 -0000
> @@ -38,6 +38,8 @@
>  	 * \param wxWindow*   
>  	*/
>  
> +  virtual bool AcceptsFocus() const;
> +
>    virtual void AddChild(wxWindow*  child ) ;
>  	/**
>  	 * \brief Directs all mouse input to this window. Call   to
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxGauge.h
> Index: wxruby2/swig/classes/include/wxGauge.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxGauge.h,v
> retrieving revision 1.3
> diff -b -u -r1.3 wxGauge.h
> --- wxruby2/swig/classes/include/wxGauge.h	31 Jan 2005 04:18:52 -0000	1.3
> +++ wxruby2/swig/classes/include/wxGauge.h	3 Sep 2006 01:47:38 -0000
> @@ -89,6 +89,7 @@
>  	*/
>  
>    void SetValue(int  pos ) ;
> +  virtual bool AcceptsFocus() const { return false; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxRadioBox.h
> Index: wxruby2/swig/classes/include/wxRadioBox.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxRadioBox.h,v
> retrieving revision 1.5
> diff -b -u -r1.5 wxRadioBox.h
> --- wxruby2/swig/classes/include/wxRadioBox.h	21 Apr 2006 01:56:04 -0000
1.5
> +++ wxruby2/swig/classes/include/wxRadioBox.h	3 Sep 2006 01:57:02 -0000
> @@ -30,6 +30,9 @@
>    virtual bool Show(bool show = true);
>    virtual bool Show(int item, bool show = true);
>    virtual wxString GetString(int  n ) const;
> +#if defined(__WXMSW__)
> +  virtual bool AcceptsFocus() const { return true; }
> +#endif
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxSpinButton.h
> Index: wxruby2/swig/classes/include/wxSpinButton.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxSpinButton.h,v
> retrieving revision 1.3
> diff -b -u -r1.3 wxSpinButton.h
> --- wxruby2/swig/classes/include/wxSpinButton.h	31 Jan 2005 04:18:52 -0000
1.3
> +++ wxruby2/swig/classes/include/wxSpinButton.h	3 Sep 2006 01:57:44 -0000
> @@ -69,6 +69,9 @@
>  	*/
>  
>    void SetValue(int  value ) ;
> +#if defined(__WXMSW__)
> +  virtual bool AcceptsFocus() const { return false; }
> +#endif
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxSpinCtrl.h
> Index: wxruby2/swig/classes/include/wxSpinCtrl.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxSpinCtrl.h,v
> retrieving revision 1.3
> diff -b -u -r1.3 wxSpinCtrl.h
> --- wxruby2/swig/classes/include/wxSpinCtrl.h	31 Jan 2005 04:18:52 -0000
1.3
> +++ wxruby2/swig/classes/include/wxSpinCtrl.h	3 Sep 2006 01:57:57 -0000
> @@ -91,6 +91,9 @@
>  	*/
>  
>    int GetMax() const;
> +#if defined(__WXMSW__)
> +  virtual bool AcceptsFocus() const { return wxWindow::AcceptsFocus(); }
> +#endif
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxStaticBitmap.h
> Index: wxruby2/swig/classes/include/wxStaticBitmap.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxStaticBitmap.h,v
> retrieving revision 1.4
> diff -b -u -r1.4 wxStaticBitmap.h
> --- wxruby2/swig/classes/include/wxStaticBitmap.h	31 Jan 2005 04:18:52
-0000	1.4
> +++ wxruby2/swig/classes/include/wxStaticBitmap.h	3 Sep 2006 01:48:02 -0000
> @@ -48,6 +48,8 @@
>  	*/
>  
>    virtual void SetBitmap(const wxBitmap&   label ) ;
> +  virtual bool AcceptsFocus() const { return false; }
> +  virtual bool HasTransparentBackground() { return true; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxStaticBox.h
> Index: wxruby2/swig/classes/include/wxStaticBox.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxStaticBox.h,v
> retrieving revision 1.3
> diff -b -u -r1.3 wxStaticBox.h
> --- wxruby2/swig/classes/include/wxStaticBox.h	31 Jan 2005 04:18:52 -0000
1.3
> +++ wxruby2/swig/classes/include/wxStaticBox.h	3 Sep 2006 01:41:12 -0000
> @@ -43,6 +43,8 @@
>  	*/
>  
>    bool Create(wxWindow*  parent , wxWindowID  id , const wxString& 
label , const wxPoint& pos = wxDefaultPosition, const wxSize&  size =
wxDefaultSize, long style = 0, const wxString&  name =
wxT("staticBox")) ;
> +  virtual bool AcceptsFocus() const { return false; }
> +  virtual bool HasTransparentBackground() { return true; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxStaticLine.h
> Index: wxruby2/swig/classes/include/wxStaticLine.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxStaticLine.h,v
> retrieving revision 1.4
> diff -b -u -r1.4 wxStaticLine.h
> --- wxruby2/swig/classes/include/wxStaticLine.h	3 Sep 2005 20:07:43 -0000
1.4
> +++ wxruby2/swig/classes/include/wxStaticLine.h	3 Sep 2006 01:39:51 -0000
> @@ -48,6 +48,7 @@
>  	*/
>  
>    int GetDefaultSize() ;
> +  virtual bool AcceptsFocus() const { return false; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxStaticText.h
> Index: wxruby2/swig/classes/include/wxStaticText.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxStaticText.h,v
> retrieving revision 1.4
> diff -b -u -r1.4 wxStaticText.h
> --- wxruby2/swig/classes/include/wxStaticText.h	21 Apr 2006 01:56:04 -0000
1.4
> +++ wxruby2/swig/classes/include/wxStaticText.h	3 Sep 2006 01:37:46 -0000
> @@ -49,6 +49,10 @@
>    virtual void SetLabel(const wxString&   label ) ;
>    // the following were missing from the xml
>    virtual ~wxStaticText();
> +
> +  virtual bool AcceptsFocus() const { return false; }
> +  virtual bool HasTransparentBackground() { return true; }
> +
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxStatusBar.h
> Index: wxruby2/swig/classes/include/wxStatusBar.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxStatusBar.h,v
> retrieving revision 1.4
> diff -b -u -r1.4 wxStatusBar.h
> --- wxruby2/swig/classes/include/wxStatusBar.h	20 Jul 2005 00:56:02 -0000
1.4
> +++ wxruby2/swig/classes/include/wxStatusBar.h	3 Sep 2006 01:41:33 -0000
> @@ -109,6 +109,7 @@
>  	*/
>  
>    virtual void SetStatusWidths(int  n , int * widths ) ;
> +  virtual bool AcceptsFocus() const { return false; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxTextCtrl.h
> Index: wxruby2/swig/classes/include/wxTextCtrl.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxTextCtrl.h,v
> retrieving revision 1.9
> diff -b -u -r1.9 wxTextCtrl.h
> --- wxruby2/swig/classes/include/wxTextCtrl.h	25 Aug 2006 04:22:34 -0000
1.9
> +++ wxruby2/swig/classes/include/wxTextCtrl.h	3 Sep 2006 03:58:39 -0000
> @@ -169,6 +169,13 @@
>      virtual void DoUpdateWindowUI(wxUpdateUIEvent& event);
>  
>      virtual bool ShouldInheritColours() const;
> +
> +#if defined(__WXMSW__)
> + protected:
> +	virtual wxVisualAttributes GetDefaultAttributes() const;    
> +        virtual bool AcceptsFocus() const;
> +#endif
> +
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
login
> Logging in to :pserver:anonymous at rubyforge.org:2401:/var/cvs/wxruby
>
> C:\RubyDev>cvs -d :pserver:anonymous at rubyforge.org:/var/cvs/wxruby
diff -b -u wxruby2/swig/classes/include/wxToolBar.h
> Index: wxruby2/swig/classes/include/wxToolBar.h
> ==================================================================> RCS
file: /var/cvs/wxruby/wxruby2/swig/classes/include/wxToolBar.h,v
> retrieving revision 1.4
> diff -b -u -r1.4 wxToolBar.h
> --- wxruby2/swig/classes/include/wxToolBar.h	31 Jan 2005 04:18:52 -0000	1.4
> +++ wxruby2/swig/classes/include/wxToolBar.h	3 Sep 2006 01:43:14 -0000
> @@ -367,6 +367,8 @@
>    void ToggleTool(int  toolId , const bool  toggle ) ;
>    // the following were missing from the xml
>    void SetRows(int rows);
> +  virtual void UpdateWindowUI(long flags = wxUPDATE_UI_NONE) ;
> +  virtual bool AcceptsFocus() const { return false; }
>  };
>  
>  
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> wxruby-users mailing list
> wxruby-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wxruby-users

Roy Sutton

2006-Sep-03 06:35 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Try these instead.  <sigh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxWindow.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0012.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxGauge.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0013.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxRadioBox.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0014.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxSpinButton.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0015.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxSpinCtrl.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0016.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxStaticBitmap.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0017.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxStaticBox.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0018.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxStaticLine.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0019.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxStaticText.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0020.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxStatusBar.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0021.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxTextCtrl.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0022.pl
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxToolBar.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/b00efc25/attachment-0023.pl

Alex Fenton

2006-Sep-03 18:43 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Roy Sutton wrote:> Try these instead.  <sigh>Thank you. Just trying them out now. Are these to fix a problem by which 
static items (eg StaticLine) are incorrectly receiving focus? Is there a 
sample which demonstrates the before-and-after?

alex

Alex Fenton

2006-Sep-03 19:00 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

All seems to work fine, except I am getting an error compiling 
StaticText.cpp

/usr/local/include/wx-2.6/wx/mac/carbon/stattext.h: In function `VALUE
   _wrap_wxStaticText_AcceptsFocus(int, VALUE*, long unsigned int)'':
/usr/local/include/wx-2.6/wx/mac/carbon/stattext.h:48: error: `virtual bool
   wxStaticText::AcceptsFocus() const'' is protected
src/StaticText.cpp:3947: error: within this context

relevant line:
    result = (bool)((wxStaticText const *)arg1)->AcceptsFocus();

how the method is declared in the carbon headers:

protected :

  virtual wxSize DoGetBestSize() const ;
  virtual bool AcceptsFocus() const { return FALSE; }

Have not committed anything yet

alex

Roy Sutton

2006-Sep-03 20:12 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

You''ll need to put an #ifdef in there to make them protected for Mac.  
The simplest solution may be to just not add AcceptFocus to wxWindow.h.  
My fear is it will rear its ugly head again when someone adds it.  I''ll
go with whatever you want on this.

Roy

Alex Fenton wrote:> All seems to work fine, except I am getting an error compiling 
> StaticText.cpp
>
> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h: In function `VALUE
>    _wrap_wxStaticText_AcceptsFocus(int, VALUE*, long unsigned
int)'':
> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h:48: error: `virtual bool
>    wxStaticText::AcceptsFocus() const'' is protected
> src/StaticText.cpp:3947: error: within this context
>
> relevant line:
>     result = (bool)((wxStaticText const *)arg1)->AcceptsFocus();
>
> how the method is declared in the carbon headers:
>
> protected :
>
>   virtual wxSize DoGetBestSize() const ;
>   virtual bool AcceptsFocus() const { return FALSE; }
>
> Have not committed anything yet
>
> alex
> _______________________________________________
> wxruby-users mailing list
> wxruby-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wxruby-users
>
>
>
>

Roy Sutton

2006-Sep-03 20:13 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Well, the problem was I added more functions to wxWindow.h.  If you 
don''t declare the virtual AcceptFocus in wxWindow.h you don''t
need these.

Alex Fenton wrote:> Roy Sutton wrote:
>   
>> Try these instead.  <sigh>
>>     
> Thank you. Just trying them out now. Are these to fix a problem by which 
> static items (eg StaticLine) are incorrectly receiving focus? Is there a 
> sample which demonstrates the before-and-after?
>
> alex
> _______________________________________________
> wxruby-users mailing list
> wxruby-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wxruby-users
>
>
>
>

Kevin Smith

2006-Sep-03 22:23 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

That looks like an upstream bug to me. If it''s public in wxWindow, I 
can''t think of any reason it should be protected in wxStaticText.

For now, I could see leaving AcceptsFocus out of wxruby, with a comment 
saying why, or trying the #if that Roy mentions. But I think there might 
be a chance that the #if option could cause weird problems if anyone 
actually tried to use that method on wxruby-mac.

I also have not committed any of this. Maybe at this point the safest 
and least-effort option would be to omit it from Window, with a comment.

Kevin


Roy Sutton wrote:> You''ll need to put an #ifdef in there to make them protected for
Mac.
> The simplest solution may be to just not add AcceptFocus to wxWindow.h.  
> My fear is it will rear its ugly head again when someone adds it. 
I''ll
> go with whatever you want on this.
> 
> Roy
> 
> Alex Fenton wrote:
>> All seems to work fine, except I am getting an error compiling 
>> StaticText.cpp
>>
>> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h: In function `VALUE
>>    _wrap_wxStaticText_AcceptsFocus(int, VALUE*, long unsigned
int)'':
>> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h:48: error: `virtual
bool
>>    wxStaticText::AcceptsFocus() const'' is protected
>> src/StaticText.cpp:3947: error: within this context
>>
>> relevant line:
>>     result = (bool)((wxStaticText const *)arg1)->AcceptsFocus();
>>
>> how the method is declared in the carbon headers:
>>
>> protected :
>>
>>   virtual wxSize DoGetBestSize() const ;
>>   virtual bool AcceptsFocus() const { return FALSE; }
>>
>> Have not committed anything yet
>>
>> alex
>> _______________________________________________
>> wxruby-users mailing list
>> wxruby-users at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/wxruby-users
>>
>>
>>
>>   
> _______________________________________________
> wxruby-users mailing list
> wxruby-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wxruby-users

Roy Sutton

2006-Sep-03 22:37 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Something like this?

Kevin Smith wrote:> That looks like an upstream bug to me. If it''s public in wxWindow,
I
> can''t think of any reason it should be protected in wxStaticText.
>
> For now, I could see leaving AcceptsFocus out of wxruby, with a comment 
> saying why, or trying the #if that Roy mentions. But I think there might 
> be a chance that the #if option could cause weird problems if anyone 
> actually tried to use that method on wxruby-mac.
>
> I also have not committed any of this. Maybe at this point the safest 
> and least-effort option would be to omit it from Window, with a comment.
>
> Kevin
>
>
> Roy Sutton wrote:
>   
>> You''ll need to put an #ifdef in there to make them protected
for Mac.
>> The simplest solution may be to just not add AcceptFocus to wxWindow.h.
>> My fear is it will rear its ugly head again when someone adds it. 
I''ll
>> go with whatever you want on this.
>>
>> Roy
>>
>> Alex Fenton wrote:
>>     
>>> All seems to work fine, except I am getting an error compiling 
>>> StaticText.cpp
>>>
>>> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h: In function
`VALUE
>>>    _wrap_wxStaticText_AcceptsFocus(int, VALUE*, long unsigned
int)'':
>>> /usr/local/include/wx-2.6/wx/mac/carbon/stattext.h:48: error:
`virtual bool
>>>    wxStaticText::AcceptsFocus() const'' is protected
>>> src/StaticText.cpp:3947: error: within this context
>>>
>>> relevant line:
>>>     result = (bool)((wxStaticText const *)arg1)->AcceptsFocus();
>>>
>>> how the method is declared in the carbon headers:
>>>
>>> protected :
>>>
>>>   virtual wxSize DoGetBestSize() const ;
>>>   virtual bool AcceptsFocus() const { return FALSE; }
>>>
>>> Have not committed anything yet
>>>
>>> alex
>>> _______________________________________________
>>> wxruby-users mailing list
>>> wxruby-users at rubyforge.org
>>> http://rubyforge.org/mailman/listinfo/wxruby-users
>>>
>>>
>>>
>>>   
>>>       
>> _______________________________________________
>> wxruby-users mailing list
>> wxruby-users at rubyforge.org
>> http://rubyforge.org/mailman/listinfo/wxruby-users
>>     
>
> _______________________________________________
> wxruby-users mailing list
> wxruby-users at rubyforge.org
> http://rubyforge.org/mailman/listinfo/wxruby-users
>
>
>
>   -------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wxWindow.h.patch
Url:
http://rubyforge.org/pipermail/wxruby-users/attachments/20060903/e17a3639/attachment.pl

Kevin Smith

2006-Sep-04 00:20 UTC

head link

[Wxruby-users] Patch files to implement AcceptFocus

Roy Sutton wrote:> Something like this?
Perfect. Applied, thanks.

Kevin

Reasonably Related Threads

Search for more reasonably related threads

wxruby users - Sep 2006 - Patch files to implement AcceptFocus

Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

[Wxruby-users] Patch files to implement AcceptFocus

Reasonably Related Threads