I notice that the user is not able to set their own CFLAGS or LDFLAGS in
the ao, ogg, vorbis, and voribs-tools projects.
Is there a reason for this?
I understand the fact that these modules want to set extremely high
optimization flags, and that most users won't know what these are offhand,
but there are times when it is useful for the user to specify their own
CFLAGS/LDFLAGS. For example, I need to specify -D_REENTRANT for ogg and
vorbis-tools under Linux, and for all 4 modules under Solaris.
The way that the configure.in is coded *replaces* what the user has set in
the environment variables CFLAGS and LDFLAGS -- this is not normal style
for a configure script. *Adding* to the user-specified CFLAGS/LDFLAGS is
fine, but *replacing* it disallows other things that the user may wish to
do.
I can submit a patch for this; it's an easy fix.
Also, I asked several days ago, but has anyone had time to look at the
patches that I have already submitted? They were for:
- problems with static linking
- allowing compiles without gcc
- using the --prefix to find the ao, ogg, and vorbis libraries instead of
having to use --with-ogg-prefix and friends
- fixes for compiling under Solaris with the native compilers (not gcc)
See:
http://www.xiph.org/archives/vorbis-dev/200011/0290.html
http://www.xiph.org/archives/vorbis-dev/200011/0291.html
http://www.xiph.org/archives/vorbis-dev/0007.html
(I assume that this last one will turn into the following on 1
January:
http://www.xiph.org/archives/vorbis-dev/200012/0007.html
Thanks.
{+} Jeff Squyres
{+} squyres@cse.nd.edu
{+} Perpetual Obsessive Notre Dame Student Craving Utter Madness
{+} "I came to ND for 4 years and ended up staying for a decade"
--- >8 ----
List archives: http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body. No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.
Jeff Squyres <jsquyres@lsc.nd.edu> writes:> I notice that the user is not able to set their own CFLAGS or LDFLAGS in > the ao, ogg, vorbis, and voribs-tools projects. > > Is there a reason for this?Yeah, I noticed this, too. One way to fix this would be to provide a $(UCFLAGS) or something, which is specifically set aside for user-added flags.> The way that the configure.in is coded *replaces* what the user has set in > the environment variables CFLAGS and LDFLAGS -- this is not normal style > for a configure script. *Adding* to the user-specified CFLAGS/LDFLAGS is > fine, but *replacing* it disallows other things that the user may wish to > do.This is particularly problematic for the ao library, as part of CFLAGS is a define telling the library where to look for plugins, so if set your own CFLAGS, it breaks things. It would also be nice if the '-g' flag were always used. AFAIK, there's no reason not to include it when using gcc.> - using the --prefix to find the ao, ogg, and vorbis libraries instead of > having to use --with-ogg-prefix and friendsYes, this would be nice. Maybe make the --prefix value the default if the others are not specified. --Mike -- [O]ne of the features of the Internet [...] is that small groups of people can greatly disturb large organizations. --Charles C. Mann --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
>I can submit a patch for this; it's an easy fix.Yes, it should be fixed. Hopefully Jack will do so (I'm not touching the build stuff.)> >Also, I asked several days ago, but has anyone had time to look at the >patches that I have already submitted? They were for: > >- problems with static linking >- allowing compiles without gcc >- using the --prefix to find the ao, ogg, and vorbis libraries instead of > having to use --with-ogg-prefix and friends >- fixes for compiling under Solaris with the native compilers (not gcc)The compilation fixes I'll try and commit soon (apart from those to vorbiscomment. vorbiscomment is dead, and is only still in the tree to serve as a (very rough) example of how to do it. Again, I'll leave the build stuff to others. Ick. Michael --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Segher Boessenkool <segher@wanadoo.nl> writes:> > It would also be nice if the '-g' flag were always used. AFAIK, there's no > > reason not to include it when using gcc. > > Speed.Speed? AFAIK, the '-g' flag doesn't slow down execution for gcc-compiled code. If you mean speed of compilation, it doesn't seem like that'd make much difference. --Mike -- [O]ne of the features of the Internet [...] is that small groups of people can greatly disturb large organizations. --Charles C. Mann --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Jeff Squyres <jsquyres@lsc.nd.edu> writes:> On Thu, 21 Dec 2000, Segher Boessenkool wrote: > > > > Yeah, I noticed this, too. One way to fix this would be to provide a > > > $(UCFLAGS) or something, which is specifically set aside for user-added flags. > > > > EXTRA_CFLAGS is the normal name, maybe different punctuation. > > Actually, from the GNU-standard INSTALL file, they recomend setting the > CFLAGS environment variable (and any others) before running configure:Hmm. So maybe there's some way to make this graceful that way. I'm not sure exactly what the answer is, but somehow flags criticial for correctness (like -DAO_PLUGIN_PATH=\"${exec_prefix}/lib/ao\") ought to be put somewhere where they don't get stepped on by a user that wants to specify their own optimization flags. --Mike -- [O]ne of the features of the Internet [...] is that small groups of people can greatly disturb large organizations. --Charles C. Mann --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Segher Boessenkool <segher@wanadoo.nl> writes:> > Speed? AFAIK, the '-g' flag doesn't slow down execution for gcc-compiled > > It doesn't _in most cases_.Please enlighten me, I though '-g' never made a difference in execution speed (for gcc). Doesn't it emit the same actual instructions either way? --Mike -- [O]ne of the features of the Internet [...] is that small groups of people can greatly disturb large organizations. --Charles C. Mann --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
Jeff Squyres <jsquyres@lsc.nd.edu> writes:> On 21 Dec 2000, Mike Coleman wrote: > > > Please enlighten me, I though '-g' never made a difference in > > execution speed (for gcc). Doesn't it emit the same actual > > instructions either way? > > There are those of us who don't use gcc. > > Sun's Forte compilers, for example, have a *huge* speed difference with > and without -g. Using -g can disable tail-call optimization and back-end > inlining (from the cc man page).I understand this. Since vorbis isn't yet rock-solid, though, it would be really nice to have -g be the default, at least for platforms where it doesn't matter. Maybe there is some way to have autoconf do it based on the compiler? --Mike -- [O]ne of the features of the Internet [...] is that small groups of people can greatly disturb large organizations. --Charles C. Mann --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
>- problems with static linking >- allowing compiles without gcc >- using the --prefix to find the ao, ogg, and vorbis libraries instead of > having to use --with-ogg-prefix and friends >- fixes for compiling under Solaris with the native compilers (not gcc)I haven't touched all the build stuff, but the code fixes should be there. Could you test? I don't have access currently to the solaris machine I usually use. Oh, and I haven't changed vorbiscomment, because it doesn't work properly anymore anyway, I think. Don't use it. Michael --- >8 ---- List archives: http://www.xiph.org/archives/ Ogg project homepage: http://www.xiph.org/ogg/ To unsubscribe from this list, send a message to 'vorbis-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.