Vorbis dev - Nov 2000 - Vorbis Winamp plugin

Howdah...

I am working on adding configuration and comment editing to the 
OggVorbis Winamp plugin.

However I have currently banged my head against one major 
problem. How the h... do you update an .ogg with the new 
comments. Do I use the source in vorbiscomment (which doesn't 
work with any .ogg I've tested) - or is there a better alternative?

A function for simply updating an ogg with new comments would be 
*really* appreciated, but as long as anyone can point me in the 
right direction, I think I could figure it out.

I have added a configuration dialog (currently sets name format 
string and thread priority - both of which are implemented).

As for the comment dialog I have created, I am not sure if this is 
the Right Thing. Here's what my implementation does:
It creates a listbox-like window with the primary entries at the top 
(artist, title, etc.) - empty if they are not present in the .ogg.
Entries appearing several times in the .ogg are displayed under 
each other, like this:
Artist	John Doe
                Jane Doe
                Jonathan Doe
etc. - and are added simply by hitting enter when at the entry.

In addition, it allows the user to add custom entries after the 
standard entries.

Based on the documentation, the standard entries I have are 
currently (as far as I remember):

artist
title
album
tracknumber
year
composer
vendor
location
comment
lyrics (which the info displayer doesn't display at the moment)

Any others I should add as standard? And to the format string? 
(Currently similar to the one in Winamp 2.666 and 2.7)

Simon Vilmer Pedersen

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.

At 10:06 AM 11/17/00 +0100, you wrote:
>Howdah...
>
>I am working on adding configuration and comment editing to the 
>OggVorbis Winamp plugin.
Oh good. I was going to do this ages ago, but then realised that that would
mean win32 gui stuff. That's nasty, so I didn't. 
>
>However I have currently banged my head against one major 
>problem. How the h... do you update an .ogg with the new 
>comments. Do I use the source in vorbiscomment (which doesn't 
>work with any .ogg I've tested) - or is there a better alternative?
With much pain and suffering. vorbiscomment is more or less correct (but
NOT portable to non-unix systems), but it's nasty code. To do it nicely we
need an extra function or two in libvorbis. I might add them soon. 
>
>A function for simply updating an ogg with new comments would be 
>*really* appreciated, but as long as anyone can point me in the 
>right direction, I think I could figure it out.
vorbiscomment is it, for now. As far as I know, nobody other than me has
written comment-rewriting code. vorbiscomment should never have been
released into the wild as it is, though. However, vorbiscomment may have
become broken at some point - there could have been changes to the API
since I wrote it, or internals changes that affect it (yes, vorbiscomment
does things to internal libvorbis data structures, because libvorbis is
missing minor things).

Chad's ogginfo will eventually do what vorbiscomment does (and lots more) -
hopefully less horribly. 

In short, pick one of a) don't do it for now, or b) write all the rest of
the code, have it call a function to write out the new stream, and send it
all to me to actually implement that function.
>
>I have added a configuration dialog (currently sets name format 
>string and thread priority - both of which are implemented).
Good. That's somewhere on my to-do (the format string stuff at least. I
don't actually give a damn about thread priority).

<snip description of details of comment interface, which all sounds good>
>Any others I should add as standard? And to the format string? 
>(Currently similar to the one in Winamp 2.666 and 2.7)
Those look fine. The format string stuff was a quick hack - it probably
needs redoing entirely. I'm glad someone's stepped up to do it ;)

Michael

--- >8 ----
List archives:  http://www.xiph.org/archives/
Ogg project homepage: http://www.xiph.org/ogg/
To unsubscribe from this list, send a message to
'vorbis-dev-request@xiph.org'
containing only the word 'unsubscribe' in the body.  No subject is
needed.
Unsubscribe messages sent to the list will be ignored/filtered.