Monty Montgomery
2010-Sep-19 09:10 UTC
[theora] Two mux-fix patches against current liboggz
Two bugs in liboggz mux ordering bit me tonight. These are patches against current GIT, I'll apply if no one else volunteers, but I'd prefer a quick review. I'm surprised they'd not been caught, as it was causing oggz-sort/oggz-merge to mis-mux potentially all files containing theora (the frame->time calculation accounted for stream version backwards, and the result was always off by one frame). I suppose it was just more likely at lower fps, and I'm working in 24 right now. Monty -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-The-correction-for-different-starting-frame-numbers-.patch Type: text/x-c Size: 1643 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora/attachments/20100919/937c6d85/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-oggz-sort-would-miss-an-input-on-an-iteration-in-whi.patch Type: text/x-c Size: 1196 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora/attachments/20100919/937c6d85/attachment-0001.bin
Monty Montgomery
2010-Sep-19 09:20 UTC
[theora] Two mux-fix patches against current liboggz
Oops, patch two had a small bug where it only worked properly when --verbose was set. Here is an amended version. Monty -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-The-correction-for-different-starting-frame-numbers-.patch Type: text/x-c Size: 1643 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora/attachments/20100919/604c8203/attachment.bin -------------- next part -------------- A non-text attachment was scrubbed... Name: 0002-oggz-sort-would-miss-an-input-on-an-iteration-in-whi.patch Type: text/x-c Size: 1357 bytes Desc: not available Url : http://lists.xiph.org/pipermail/theora/attachments/20100919/604c8203/attachment-0001.bin
On 19 September 2010 18:20, Monty Montgomery <xiphmont at gmail.com> wrote:> Oops, patch two had a small bug where it only worked properly when > --verbose was set. > > Here is an amended version.Thanks, I've applied these (with some formatting changes and your name) to the 1.0-stable and master branches on github. I had an error pushing to the master on git.xiph.org but there was an error. I may have been using the wrong URL; gitweb is giving some xml formatting errors so I couldn't check the push url. I'll retry pushing that tonight from home. cheers, Conrad.