Syslinux - Jun 2013 - [5.11-pre1] SYSAPPEND does not work (IPAPPEND alias works)

On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi
<vmlinuz386 at yahoo.com.ar> wrote:
> I guess the bug is here (com32/menu/readconfig.c)
>
>    910          } else if (looking_at(p, "ipappend") ||
looking_at(p,
> "sysappend")) {
>    911              if (ld.label)
>    912                  ld.ipappend = atoi(skipspace(p + 8));
>    913              else
>    914                  ipappend = atoi(skipspace(p + 8));
>
> since the length of "sysappend" (9) differs from
"ipappend" (8) but
> parsed in the same way.
I think I see a good solution here.

--
-Gene

On Sun, Jun 23, 2013 at 8:24 PM, Gene Cumm <gene.cumm at gmail.com>
wrote:
> On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi
> <vmlinuz386 at yahoo.com.ar> wrote:
>> I guess the bug is here (com32/menu/readconfig.c)
>>
>>    910          } else if (looking_at(p, "ipappend") ||
looking_at(p,
>> "sysappend")) {
>>    911              if (ld.label)
>>    912                  ld.ipappend = atoi(skipspace(p + 8));
>>    913              else
>>    914                  ipappend = atoi(skipspace(p + 8));
>>
>> since the length of "sysappend" (9) differs from
"ipappend" (8) but
>> parsed in the same way.
>
> I think I see a good solution here.
>
> --
> -Gene
Fix and bug (requesting which of decimal versus hexadecimal is correct) sent.

--
-Gene

On 06/24/2013 12:35 AM, Gene Cumm wrote:
> On Sun, Jun 23, 2013 at 8:24 PM, Gene Cumm <gene.cumm at gmail.com>
wrote:
>> On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi
>> <vmlinuz386 at yahoo.com.ar> wrote:
>>> I guess the bug is here (com32/menu/readconfig.c)
>>>
>>>    910          } else if (looking_at(p, "ipappend") ||
looking_at(p,
>>> "sysappend")) {
>>>    911              if (ld.label)
>>>    912                  ld.ipappend = atoi(skipspace(p + 8));
>>>    913              else
>>>    914                  ipappend = atoi(skipspace(p + 8));
>>>
>>> since the length of "sysappend" (9) differs from
"ipappend" (8) but
>>> parsed in the same way.
>>
>> I think I see a good solution here.
>>
>> --
>> -Gene
> 
> Fix and bug (requesting which of decimal versus hexadecimal is correct)
sent.

Works fine in 6.01-pre5, thanks you!.



-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL:
<http://www.zytor.com/pipermail/syslinux/attachments/20130628/a3f0ec7a/attachment.sig>