search for: readconfig

...is not a fix for it! Revert "SYSAPPEND: Fix space stripping" This reverts commit 3106dcd http://repo.or.cz/w/syslinux.git/commit/3106dcd Fixes broken boot via vesamenu.c32 for the current git - 5186539 2015-06-27 version 6.04 2015 built with gcc version 5.1.1 --- com32/elflink/ldlinux/readconfig.c | 2 +- com32/menu/readconfig.c | 2 +- core/sysappend.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/com32/elflink/ldlinux/readconfig.c b/com32/elflink/ldlinux/readconfig.c index 381b43f..dcdf91b 100644 --- a/com32/elflink/ldlinux/readconfig...

com32/modules/readconfig.c: This is a side effect of is_kernel_type() overwrite the current pointer in a loop context. Hence subsequent options aren't parsed ever. This is particularily visible, if you use timeout option, which wont work in the latest 3.40-pre7. Patch: --- com32/modules/readconfig.c /opensource/sysli...

Hello, The description of SYSAPPEND for the DMI information states that the spaces are replaced by underscores, but this replacement does not occur in 6.03. There's small bug present in triplicata in com32/elflink/ldlinux/readconfig.c:copy_sysappend_string(), com32/menu/readconfig.c:copy_sysappend_string(), and core/sysappend.c:copy_and_mangle() prevent proper replacement of spaces by underscore. Here's a patch which fix this (only tested via BIOS PXELINUX) diff -pruN syslinux-6.03.orig/com32/elflink/ldlinux/readconfig.c...

...iable `clear' might be clobbered by `longjmp' or `vfork' menu.c:553: warning: variable `cmdline' might be clobbered by `longjmp' or `vfork' gcc -m32 -mregparm=3 -DREGPARM=3 -W -Wall -march=i386 -Os -fomit-frame-pointer -I../libutil/include -I../include -D__COM32__ -c -o readconfig.o readconfig.c readconfig.c: In function `unlabel': readconfig.c:198: warning: implicit declaration of function `isspace' readconfig.c:205: error: `menu_entry' undeclared (first use in this function) readconfig.c:205: error: (Each undeclared identifier is reported only once readconfig....

On Tue, Jun 30, 2015 at 4:29 PM, poma <pomidorabelisima at gmail.com> wrote: > "A real serial port that can reliably operate at 115200 8n1 may be > necessary." > > Gene, is there something special in "A real serial port" usage, compared to emulated? I should restate: A serial port that responds on BIOS IO port 3F8h that can reliably operate at 115200 8n1 may

...at zytor.com> wrote: > >> - "unsigned char c;" does not solve the problem >> >> - "c >= 0 && c <= ' '" solves the problem for the current git > > Could you try the following patch? Feel free to only apply the change > to readconfig.c if you want. > It works OK as whole, for the current git: com32/include/menu.h | 2 +- com32/menu/readconfig.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/com32/include/menu.h b/com32/include/menu.h index bc0182f..b0251e4 100644 --- a/com32/include/menu.h +++...

core and the simple menu do not interpret the IPAPPEND/SYSAPPEND directives in the same way. Which is the proper way? Either way, this should be clarified in the documentation. com32/elflink/ldlinux/readconfig.c: } else if ((ep = looking_at(p, "ipappend")) || (ep = looking_at(p, "sysappend"))) { uint32_t s = strtoul(skipspace(ep), NULL, 16); if (ld.label) ld.ipappend = s; else SysAppends = s;...

...github.com/geneC/syslinux into elflink are available in the git repository at: git://github.com/geneC/syslinux.git ipappend-fix-for-mfleming Gene Cumm (2): core & menu: fix IPAPPEND/SYSAPPEND conversion doc/ & txt/: Document IPAPPEND/SYSAPPEND format com32/elflink/ldlinux/readconfig.c | 2 +- com32/menu/readconfig.c | 2 +- doc/syslinux.txt | 3 ++- txt/syslinux.cfg.txt | 4 +++- 4 files changed, 7 insertions(+), 4 deletions(-)

..., poma via Syslinux <syslinux at zytor.com> wrote: > - "unsigned char c;" does not solve the problem > > - "c >= 0 && c <= ' '" solves the problem for the current git Could you try the following patch? Feel free to only apply the change to readconfig.c if you want. -- -Gene diff --git a/com32/include/menu.h b/com32/include/menu.h index bc0182f..b0251e4 100644 --- a/com32/include/menu.h +++ b/com32/include/menu.h @@ -195,7 +195,7 @@ void local_cursor_enable(bool); static inline int my_isspace(char c) { - return (unsigned char)c <= &...

...Syslinux <syslinux at zytor.com> wrote: > > Would someone please be so kind to explain / describe the PXERETRY > > directive? > > $ git grep -ni pxeretry -i ignore case ("thanks" said the person who exact case matching search ) > com32/elflink/ldlinux/readconfig.c:1305: else if (looking_at(p, "pxeretry")) > com32/elflink/ldlinux/readconfig.c:1306: PXERetry = > atoi(skipspace(p + 8)); > > core/fs/pxe/pxe.c:275: int i = PXERetry; > > > It's used in pxe_searchdir() to affect how many times it retries to >...

...build the menu data structures on the first (and only) parse of the config file, not to mention the fact that we only need one copy of the parser now. Other functions will be converted from asm to C later. This series is also available at, git://git.zytor.com/users/mfleming/syslinux.git elflink-readconfig-for-hpa Matt Fleming (12): dprintf: Print to stdout as well as serial ports elflink: Remove *.c32 on 'make clean' core: Be less verbose at boot elflink: Don't pass NULL to spawn_load() elflink: Move code out of core and into ldlinux.c32 elflink: Look for syslinux.cfg elf...

Hey, I noticed my_isspace() is being used in menu/mainmenu and readconfig com32 modules. Why not use isblank() instead? Here's a patch: thanks. Ram --- com32/modules/menu.h //depot/opensource/main/syslinux-3/com32/modules/menu.h#2 +++ com32/modules/menu.h 07-03-15 16:27:14 @@ -87,11 +87,6 @@ void parse_configs(char **argv); extern int (*draw_background)(const c...

If MENU COMMIT is specified for a label, execute it automatically when its hotkey is pressed. Signed-off-by: Ferenc Wagner <wferi at niif.hu> --- com32/menu/menu.h | 1 + com32/menu/menumain.c | 10 ++++++++-- com32/menu/readconfig.c | 6 +++++- 3 files changed, 14 insertions(+), 3 deletions(-) As mentioned on IRC, people ask for this. So here's something to talk about. Like the variable names... diff --git a/com32/menu/menu.h b/com32/menu/menu.h index 1e596e1..856c368 100644 --- a/com32/menu/menu.h +++ b/com32/menu...

Would someone please be so kind to explain / describe the PXERETRY directive? TIA, Ady.

...een even if we have no pDraw_Menu method elflink: Add Ctrl-p + Ctrl-n key binds core/elflink/cli.c | 10 +++++----- core/elflink/execute.c | 3 +++ core/elflink/get_key.c | 2 ++ core/elflink/getadv.c | 2 +- core/elflink/load_env32.c | 11 ++++++----- core/elflink/readconfig.c | 1 - 6 files changed, 17 insertions(+), 12 deletions(-)

Hi, hpa wrote: > On PowerPC (I think) "unsigned char" is the default. In any case it seems a good idea to interpret the character more explicitely. To my experience, one signdness change causes a little tree of consequential signedness changes or questionable cast operations. How about the following instead ? if ((c >= 0 && c <= ' ') || c == '\x7f')

...r-hpa/elflink/cmdline Matt Fleming (2): elflink, cli: TAB key now displays labels ldlinux, cli: Add support for F-keys com32/elflink/ldlinux/cli.c | 21 +++++++++ com32/elflink/ldlinux/config.h | 2 + com32/elflink/ldlinux/ldlinux.c | 2 +- com32/elflink/ldlinux/readconfig.c | 84 ++++++++++++++++++++++++++++++++++++ com32/elflink/modules/menu.h | 2 + 5 files changed, 110 insertions(+), 1 deletions(-) diff --git a/com32/elflink/ldlinux/cli.c b/com32/elflink/ldlinux/cli.c index 172a9f6..0884525 100644 --- a/com32/elflink/ldlinux/cli.c +++ b/com32/elflink/...

On 07/01/2015 01:35 AM, poma via Syslinux wrote: > > diff --git a/com32/elflink/ldlinux/readconfig.c b/com32/elflink/ldlinux/readconfig.c > index 381b43f..dcdf91b 100644 > --- a/com32/elflink/ldlinux/readconfig.c > +++ b/com32/elflink/ldlinux/readconfig.c > @@ -330,7 +330,7 @@ static char *copy_sysappend_string(char *dst, const char *src) > char c; > > while ((c...

...it 022cdd1d56512e8759e8374c10a7420201db93c0: Matt Fleming (1): cli: don't disable linewrap when redrawing the cmdline are available in the git repository at: git://github.com/geneC/syslinux.git menu-ipappend-1-for-mfleming Gene Cumm (1): menu.c32: Fix SYSAPPEND com32/menu/readconfig.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)

...>> this should be clarified in the documentation. > > To be clear: core treats the value as always hexidecimal while simple > menu treats it as decimal unless a 0x prefix is present. Correction: simple menu always does decimal (as should be expected). >> com32/elflink/ldlinux/readconfig.c: >> } else if ((ep = looking_at(p, "ipappend")) || >> (ep = looking_at(p, "sysappend"))) { >> uint32_t s = strtoul(skipspace(ep), NULL, 16); >> if (ld.label) >> ld.ipappend = s; >&...