Syslinux - Jun 2013 - [5.11-pre1] SYSAPPEND does not work (IPAPPEND alias works)

On 06/13/2013 10:15 PM, Gene Cumm wrote:
> On Thu, Jun 13, 2013 at 8:08 PM, Gerardo Exequiel Pozzi
> <vmlinuz386 at yahoo.com.ar> wrote:
>> Hello
>>
>> While testing PXE booting, I decided to change IPAPPEND to the new
>> SYSAPPEND and does not work: nothing is appended to command line.
>>
>> I tested using menu.c32 and vesamenu.c32, same issue.
>>
>> ---------------------------------------------------------------------
>> SERIAL 0 38400
>> UI boot/syslinux/vesamenu.c32
>>
>>
>> LABEL arch64_nbd
>> MENU LABEL Boot Arch Linux (x86_64) (NBD)
>> LINUX boot/x86_64/vmlinuz
>> INITRD boot/x86_64/archiso.img
>> APPEND archisobasedir=arch archisolabel=ARCH_201306
>> archiso_nbd_srv=${pxeserver}
>> SYSAPPEND 3
>>
>> ---------------------------------------------------------------------
> 
> the simple menu system, (vesa)menu.c32, has its own configuration
> parser.  Did you try the LABEL outside of the simple menu system?
> 
Good point. Yes it works. :) starting using the label from the boot: prompt.


> --
> -Gene
> _______________________________________________
> Syslinux mailing list
> Submissions to Syslinux at zytor.com
> Unsubscribe or set options at:
> http://www.zytor.com/mailman/listinfo/syslinux
> Please do not send private replies to mailing list traffic.
> 
> 

-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL:
<http://www.zytor.com/pipermail/syslinux/attachments/20130613/e5ba6f77/attachment.sig>

On 06/13/2013 11:06 PM, Gerardo Exequiel Pozzi wrote:
> On 06/13/2013 10:15 PM, Gene Cumm wrote:
>> On Thu, Jun 13, 2013 at 8:08 PM, Gerardo Exequiel Pozzi
>> <vmlinuz386 at yahoo.com.ar> wrote:
>>> Hello
>>>
>>> While testing PXE booting, I decided to change IPAPPEND to the new
>>> SYSAPPEND and does not work: nothing is appended to command line.
>>>
>>> I tested using menu.c32 and vesamenu.c32, same issue.
>>>
>>>
---------------------------------------------------------------------
>>> SERIAL 0 38400
>>> UI boot/syslinux/vesamenu.c32
>>>
>>>
>>> LABEL arch64_nbd
>>> MENU LABEL Boot Arch Linux (x86_64) (NBD)
>>> LINUX boot/x86_64/vmlinuz
>>> INITRD boot/x86_64/archiso.img
>>> APPEND archisobasedir=arch archisolabel=ARCH_201306
>>> archiso_nbd_srv=${pxeserver}
>>> SYSAPPEND 3
>>>
>>>
---------------------------------------------------------------------
>>
>> the simple menu system, (vesa)menu.c32, has its own configuration
>> parser.  Did you try the LABEL outside of the simple menu system?
>>
> 
> Good point. Yes it works. :) starting using the label from the boot:
prompt.
> 
I guess the bug is here (com32/menu/readconfig.c)

   910          } else if (looking_at(p, "ipappend") || looking_at(p,
"sysappend")) {
   911              if (ld.label)
   912                  ld.ipappend = atoi(skipspace(p + 8));
   913              else
   914                  ipappend = atoi(skipspace(p + 8));

since the length of "sysappend" (9) differs from "ipappend"
(8) but
parsed in the same way.



-- 
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 555 bytes
Desc: OpenPGP digital signature
URL:
<http://www.zytor.com/pipermail/syslinux/attachments/20130623/539ab765/attachment.sig>

On Sun, Jun 23, 2013 at 3:16 PM, Gerardo Exequiel Pozzi
<vmlinuz386 at yahoo.com.ar> wrote:
> I guess the bug is here (com32/menu/readconfig.c)
>
>    910          } else if (looking_at(p, "ipappend") ||
looking_at(p,
> "sysappend")) {
>    911              if (ld.label)
>    912                  ld.ipappend = atoi(skipspace(p + 8));
>    913              else
>    914                  ipappend = atoi(skipspace(p + 8));
>
> since the length of "sysappend" (9) differs from
"ipappend" (8) but
> parsed in the same way.
I think I see a good solution here.

--
-Gene