similar to: PATCH: add FLAC__SSE_SUPPORTED and FLAC__SSE2_SUPPORTED

Erik de Castro Lopo wrote: > Yes, I think src/libFLAC/include/private/cpu.h would be a better place > for this SSE version support stuff. > > Would you be able to do it or should I? OK, the attached patch adds FLAC__SSE*_SUPPORTED and also moves their definitions to cpu.h. It also adds GCC 4.9 support (http://gcc.gnu.org/gcc-4.9/changes.html: "It is now possible to call x86

After this patch, all FLAC__SSEN_SUPPORTED variables are undefined for GCC, so intrinsic versions of functions are not compiled into libFLAC. Previously, the code was: #if defined __INTEL_COMPILER // definitions for ICC #elif defined _MSC_VER // definitions for MSVC #elif defined __GNUC__ || defined __clang__ #if defined __clang__ && __has_attribute(__target__) //

On Mon, Mar 9, 2015 at 5:15 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Janne Hyv?rinen wrote: > >> I compiled flac.exe without NASM and verified that >> FLAC__lpc_restore_signal_16_intrin_sse2 is used. Decoding the same file >> that made VLC 2.2 crash decoded without issues. Would be nice if VLC was >> compilable with MSVC and we could use its debugger.

Unable to test on win32 at the moment, please give this a try. Feedback welcome. Avoids crashes due to unaligned ops when built with mingw. --- src/libFLAC/include/private/cpu.h | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/libFLAC/include/private/cpu.h b/src/libFLAC/include/private/cpu.h index 8927897..bd40012 100644 --- a/src/libFLAC/include/private/cpu.h +++

A newer version of the patch. Replaces the previous (ie. http://lists.xiph.org/pipermail/flac-dev/2014-February/004553.html) version. -------------- next part -------------- A non-text attachment was scrubbed... Name: no_slow_intrin_v2.patch Type: application/octet-stream Size: 2959 bytes Desc: not available Url :

Erik de Castro Lopo wrote: > Applied with minor reformatting. Thanks. And btw, about reformatting: currently stream_encoder.c contains the following code: #ifdef FLAC__SSSE3_SUPPORTED if(encoder->private_->cpuinfo.ia32.ssse3) aaaaa; else #endif #ifdef FLAC__SSE2_SUPPORTED bbbbb; #endif This code is correct because if FLAC__SSSE3_SUPPORTED is defined then FLAC__SSE2_SUPPORTED is

https://bugs.freedesktop.org/show_bug.cgi?id=73791 Priority: medium Bug ID: 73791 Assignee: nouveau at lists.freedesktop.org Summary: [NV96] [BISECTED] Regression: 9600M GT fails to boot with 3.13-rc8 QA Contact: xorg-team at lists.x.org Severity: critical Classification: Unclassified OS: Linux

--- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..4347c07 100644 --- a/configure.ac +++ b/configure.ac @@ -399,9 +399,10 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) +

On Fri, Apr 10, 2015 at 1:40 PM, lvqcl <lvqcl.mail at gmail.com> wrote: > Tristan Matthews wrote: > > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > > XIPH_ADD_CFLAGS([-msse2]) > > - XIPH_ADD_CFLAGS([-mstackrealign]) > > + if test "$host_os" = "mingw32" ; then >

Tristan Matthews wrote: > --- > configure.ac | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index eb9b0cc..e7d68c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then > > if test "x$asm_optimisation$sse_os" =

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: > The biggest of these tweaks weas to disable the intrinsics version > fero FLAC__CPU_IA32 because I couldn't get this to compile on > i386-linux (and we have the nasm versions). Still open to re-enabling > this if someone can get it to work. I know you're a skilled programmer, but... maybe you forgot to add -msse

Tristan Matthews wrote: > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > + if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > + fi > fi But sse_os==no doesn't prevent libFLAC from using SSE intrinsics. So I think

And only for i686. --- configure.ac | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..8dd5b0d 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,16 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) -

Thomas Zander wrote: > In any case, the disable-SSE matter is still important. People are > still using flac on x86 machines without SSE, for instance AMD Geode > CPUs seem to live forever. libFLAC detects CPU SSE support in runtime, so --disable-sse is necessary for cuch CPUs only because it disables -msse2 switch. Maybe it makes sense to add new switch, --no-force-sse2 or

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote: >> -msse for SSE code, -msse2 for SSE2 code, -msse4.1 for SSE4.1 code > > Yes, that was it. Brain fart. These flags were not needed on x86_64. > > Erik But now all C code is compiled with -msse2 and it won't work on older CPUs. Isn't it better to compile only necessary files with this flag?

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Hi Jesus, Thanks for the report. As far as I can tell, what's happening is that when intrinsics are enabled, we compile all tests with -msse4.1, even when it's only run-time detected. In most cases, that doesn't cause any issue, but sometimes the compiler will take the C code and generate an SSEx instruction on its own. I think this is

https://bugs.freedesktop.org/show_bug.cgi?id=73342 Priority: medium Bug ID: 73342 Assignee: nouveau at lists.freedesktop.org Summary: nouveau not working with yuy2 overlay QA Contact: xorg-team at lists.x.org Severity: normal Classification: Unclassified OS: All Reporter: fbs777 at gmail.com

Is Nasm always available when the target architecture is IA-32? For example, FLAC has FLAC__lpc_compute_autocorrelation_asm_ia32_sse_lag_NN() functions that require NASM presence, and FLAC__lpc_compute_autocorrelation_intrin_sse_lag_NN() functions that require x86 intrinsics support. FLAC makes use of the former (if NASM is available) but doesn't try to use the latter when NASM is not found.

if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) fi -msse2 tells the compiler that it can generate SSE2 instructions. The resulting code will _not_ run on CPUs without SSE2. This is counter to the assembly optimizations themselves, which check at runtime if extensions like SSE etc. are available. This

lvqcl wrote: > lvqcl wrote: > > > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > > even if x86intrin.h is not available. > > > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it. Looks good. I need to do a little testing. > > 3)