flac dev - Feb 2014 - PATCH "don't use intrinsics when they're slower", Version 2

A newer version of the patch.
Replaces the previous (ie.
http://lists.xiph.org/pipermail/flac-dev/2014-February/004553.html) version.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no_slow_intrin_v2.patch
Type: application/octet-stream
Size: 2959 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140220/1fe958fe/attachment.obj

lvqcl wrote:
> A newer version of the patch.
> Replaces the previous (ie.
http://lists.xiph.org/pipermail/flac-dev/2014-February/004553.html) version.
Thanks. Applied with minor reformatting.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik de Castro Lopo wrote:
> Applied with minor reformatting.
Thanks. And btw, about reformatting: currently stream_encoder.c contains the
following code:

#ifdef FLAC__SSSE3_SUPPORTED
	if(encoder->private_->cpuinfo.ia32.ssse3)
		aaaaa;
	else
#endif
#ifdef FLAC__SSE2_SUPPORTED
		bbbbb;
#endif

This code is correct because if FLAC__SSSE3_SUPPORTED is defined then
FLAC__SSE2_SUPPORTED is also defined (there are no compilers that support ssse3
but
don't support sse2), so there is no missing statement after 'else'.
But imho
the following version is more easy to read:

#ifdef FLAC__SSE2_SUPPORTED
#  ifdef FLAC__SSSE3_SUPPORTED
	if(encoder->private_->cpuinfo.ia32.ssse3)
		aaaaa;
	else
#  endif
		bbbbb;
#endif

because this code doesn't depend on assumptions about FLAC__SSSE3_SUPPORTED
and FLAC__SSE2_SUPPORTED

The patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ifdefs.patch
Type: application/octet-stream
Size: 1365 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140224/fc0f3db9/attachment.obj