flac dev - Apr 2015 - [PATCH] configure: only use -mstackrealign for mingw32

---
 configure.ac | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index eb9b0cc..4347c07 100644
--- a/configure.ac
+++ b/configure.ac
@@ -399,9 +399,10 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then
 
 	if test "x$asm_optimisation$sse_os" = "xyesyes" ; then
 		XIPH_ADD_CFLAGS([-msse2])
-		XIPH_ADD_CFLAGS([-mstackrealign])
+		if test "$host_os" = "mingw32" ; then
+			XIPH_ADD_CFLAGS([-mstackrealign])
+			fi
 		fi
-
 	fi
 
 XIPH_ADD_CFLAGS([-Wextra])
-- 
2.1.0

Tristan Matthews wrote:
>  	if test "x$asm_optimisation$sse_os" = "xyesyes" ;
then
>  		XIPH_ADD_CFLAGS([-msse2])
> -		XIPH_ADD_CFLAGS([-mstackrealign])
> +		if test "$host_os" = "mingw32" ; then
> +			XIPH_ADD_CFLAGS([-mstackrealign])
> +			fi
>  		fi
But sse_os==no doesn't prevent libFLAC from using SSE intrinsics.
So I think that the code

	if test "$host_os" = "mingw32" ; then
		XIPH_ADD_CFLAGS([-mstackrealign])
		fi

should be somewhere outside of

	if test "x$asm_optimisation$sse_os" = "xyesyes"
		...
		...
		fi

On Fri, Apr 10, 2015 at 1:40 PM, lvqcl <lvqcl.mail at gmail.com> wrote:
> Tristan Matthews wrote:
>
> >       if test "x$asm_optimisation$sse_os" =
"xyesyes" ; then
> >               XIPH_ADD_CFLAGS([-msse2])
> > -             XIPH_ADD_CFLAGS([-mstackrealign])
> > +             if test "$host_os" = "mingw32" ;
then
> > +                     XIPH_ADD_CFLAGS([-mstackrealign])
> > +                     fi
> >               fi
>
> But sse_os==no doesn't prevent libFLAC from using SSE intrinsics.
> So I think that the code
>
>         if test "$host_os" = "mingw32" ; then
>                 XIPH_ADD_CFLAGS([-mstackrealign])
>                 fi
>
> should be somewhere outside of
>
>         if test "x$asm_optimisation$sse_os" = "xyesyes"
>                 ...
>                 ...
>                 fi
>
Ah, good point, I'll resend.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20150410/a64dcc86/attachment.htm