flac dev - Sep 2013 - PATCH: x86-64 support and SSE intrinscis code

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:
> The biggest of these tweaks weas to disable the intrinsics version
> fero FLAC__CPU_IA32 because I couldn't get this to compile on
> i386-linux (and we have the nasm versions). Still open to re-enabling
> this if someone can get it to work.

I know you're a skilled programmer, but... maybe you forgot to add -msse
compiler option?

-msse for SSE code, -msse2 for SSE2 code, -msse4.1 for SSE4.1 code

lvqcl wrote:
> Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:
> 
> > The biggest of these tweaks weas to disable the intrinsics version
> > fero FLAC__CPU_IA32 because I couldn't get this to compile on
> > i386-linux (and we have the nasm versions). Still open to re-enabling
> > this if someone can get it to work.
> 
> 
> I know you're a skilled programmer, but... maybe you forgot to add
-msse compiler option?
> 
> -msse for SSE code, -msse2 for SSE2 code, -msse4.1 for SSE4.1 code
Yes, that was it. Brain fart. These flags were not needed on x86_64.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:
>> -msse for SSE code, -msse2 for SSE2 code, -msse4.1 for SSE4.1 code
>
> Yes, that was it. Brain fart. These flags were not needed on x86_64.
>
> Erik
But now all C code is compiled with -msse2 and it won't work on older CPUs.
Isn't it better to compile only necessary files with this flag?