flac dev - Mar 2012 - PATCH: Add test for metaflac --add-replay-gain

Erik,

I'm using bash.? Before I alter the syntax, what shell are you using ?

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Sunday, March 11, 2012 3:16:11 AM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
 
Earl Chew wrote:
> There is only one test to verify handling of harmonics of the filter table
> sampling frequencies.
Earl,

I've had a couple of attempts to get this patch working, without luck.

With this patch applied, when i run the test_metaflac.sh script, I get:

? ? Testing FLAC file with unknown metadata... OK
? ? ./test_metaflac.sh: line 450: syntax error near unexpected token `then'
? ? ./test_metaflac.sh: line 450: `? then'

It's basically barfing at this line:

? if [ -n "${ACTION##*:*}" ] ; then

Not sure where to go with this. You offerred Perl which I rejected mainly
because I read Perl :-). Are you comfortable with Python?

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120311/40154d89/attachment.htm

Earl Chew wrote:
> I'm using bash.
Thats what I'm using.
> Before I alter the syntax, what shell are you using ?
Bash version 4.2.

However, /bin/sh is either bash or dash. I've tried replacing
/bin/sh with /bin/bash and /bin/dash. None of them work.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik,

I suspect /bin/sh being dash is what is causing the problem.

I will rework the syntax.

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Sunday, March 11, 2012 10:59:50 PM
Subject: Re: [flac-dev] PATCH: Add test for metaflac --add-replay-gain
 
Earl Chew wrote:
> I'm using bash.
Thats what I'm using.
> Before I alter the syntax, what shell are you using ?
Bash version 4.2.

However, /bin/sh is either bash or dash. I've tried replacing
/bin/sh with /bin/bash and /bin/dash. None of them work.

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120312/1d79807f/attachment.htm