flac dev - Feb 2012 - Fix cuesheet.c to allow metaflac_test.sh to run to completion

Erik,

I'll resync and have another look.

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Wednesday, February 1, 2012 10:30:21 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
 
Earl Chew wrote:
> When reading the INDEX from the cue sheet, the format MM:SS:FF format
> is disallowed if the sample frequency is not a multiple of 75 because
> the index would only be approximate. However, 00:00:00 is _exact_ because
> it denotes the start of the track, so allow it as a special case. This
> allows metaflac_test.sh to pass.
Thanks for this patch Earl, but unfortunately even with this patch in
place (and the exit 0 I added the script removed), test_metaflac.sh still
fails with:

? ?  test case43: --import-cuesheet-from... ERROR: metadata does not match
? ?  expected metaflac-test-files/case43-expect.meta

Would be great if you could have another look at this.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120202/e35c9258/attachment.htm

Erik,

My working view has this as the last commit:

commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16
Author: David Schleef <ds at schleef.org>
Date:?? Thu Aug 25 18:40:29 2011 -0700

??? Fix md5 structure clearing in previous commit



Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.


I set up another view using HEAD at git.xiph.org, and in this other view
test_metaflac.sh fails.
With my change in place, the failure is a mismatch between information stored in
the golden
file.



--- metaflac-test-files/case43-expect.meta????? 2012-02-02 08:52:57.000000000
-0800
+++ metaflac-test-files/out.meta??????? 2012-02-03 11:37:13.000000000 -0800
@@ -10,9 +10,8 @@
?METADATA block #1
?? type: 3 (SEEKTABLE)
?? is last: false
-? length: 18
-? seek points: 1
-??? point 0: sample_number=0
+? length: 0
+? seek points: 0
?METADATA block #2
?? type: 4 (VORBIS_COMMENT)
?? is last: false



Do you have any more insight ?


Earl



________________________________
 From: Earl Chew <earl_chew at yahoo.com>
To: "flac-dev at xiph.org" <flac-dev at xiph.org> 
Sent: Thursday, February 2, 2012 8:50:17 AM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
 

Erik,

I'll resync and have another look.

Earl



________________________________
 From: Erik de Castro Lopo <mle+la at mega-nerd.com>
To: flac-dev at xiph.org 
Cc: Earl Chew <earl_chew at yahoo.com> 
Sent: Wednesday, February 1, 2012 10:30:21 PM
Subject: Re: [flac-dev] Fix cuesheet.c to allow metaflac_test.sh to run to
completion
 
Earl Chew wrote:
> When reading the INDEX from the cue sheet, the format MM:SS:FF format
> is disallowed if the sample frequency is not a multiple of 75 because
> the index would only be approximate. However, 00:00:00 is _exact_ because
> it denotes the start of the track, so allow it as a special case. This
> allows metaflac_test.sh to pass.
Thanks for this patch Earl, but unfortunately even with this patch in
place (and the exit 0 I added the script removed), test_metaflac.sh still
fails with:

? ?  test case43: --import-cuesheet-from... ERROR: metadata does not match
? ?  expected metaflac-test-files/case43-expect.meta

Would be great if you could have another look at this.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20120203/7c8a6102/attachment.htm

Earl Chew wrote:
> Erik,
> 
> My working view has this as the last commit:
> 
> commit 19e3918d4e35f4ab99e7fcc58c169025c576dd16
> Author: David Schleef <ds at schleef.org>
> Date:?? Thu Aug 25 18:40:29 2011 -0700
> 
> ??? Fix md5 structure clearing in previous commit
> 
> 
> 
> Using this, test_metaflac.sh runs cleanly with my cuesheet.c change.
<snip>
> Do you have any more insight ?
Ok, using a bit of git bisect magic, I find that if your cuesheet patch
had been applied on top of commit 19e3918d4e, then this patch:

    commit ce8a75134cace056f6c436d54b57bad1a1d93797
    Author: Erik de Castro Lopo <erikd at mega-nerd.com>
    Date:   Wed Feb 1 20:34:04 2012 +1100

        Fix a bunch of printf format warnings.

Broke it again.

I'll work on this some more.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/