similar to: [LLVMdev] Object File Library. llvm-nm changed to match binutils-nm for COFF and ELF (32, little endian).

I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved.

On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > write_uint32_le is used to write into a arbitrary data buffer, where as >  WriteLE32 is used to write into the object file. Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I

On Wed, Jun 23, 2010 at 12:22 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: > I'm now going to make the stub patches that Daniel requested. Added llvm/Support/COFF.h and merged in COFF constants from llvm/MC/MCSectionCOFF.h. Zeroth patch is done. http://github.com/Bigcheese/llvm-mirror/commit/2d88aa08a072bb5f8d687b67d1476f23d37a87d4 A svn-style patch against svn HEAD is

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. 3rd patch

Right on, thanks for working on this. I have been busy lately, but its good to see progress being made. On Mon, Jun 21, 2010 at 11:31 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >  - Please split the patch into at least four parts: >    (1) Add WinCOFFStreamer, with a stub implementation. >    (2) Add WinCOFFObjectWriter, with a stub implementation. >    (3) Fill in WinCOFFStreamer. >    (4) Fill in WinCOFFObjectWriter. Here's the 1'st patch.

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Here's the 2nd patch.

This probably needs to be slightly tweaked to work with mainline. I don't see anything objectionable, but I think Daniel needs to review this one. Thanks for working on this Michael! -Chris On Jul 3, 2010, at 3:19 AM, Michael Spencer wrote: > On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >> - Please split the patch into at least four parts:

On Fri, Jul 16, 2010 at 11:25 AM, Daniel Dunbar <daniel at zuster.org> wrote: > Hi Michael, > > Overall patch looks good. I do have a few comments below. My main > comment is please try to make the style match that used in the > MCMachOStreamer more closely. I intend to refactor more functionality > into the base MCObjectStreamer class, and having them use consistent >

On Thu, Jun 10, 2010 at 2:41 AM, Bigcheese <bigcheesegs at gmail.com> wrote: > On Wed, Jun 9, 2010 at 11:11 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: >> This is cool, I was looking into something like this, but hit a little bit >> of a wall, and then got sidetracked on another project. I was going to use >> llc to generate COFF object files

On Wed, Jun 9, 2010 at 11:41 PM, Bigcheese <bigcheesegs at gmail.com> wrote: > On Wed, Jun 9, 2010 at 11:11 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: >> This is cool, I was looking into something like this, but hit a little bit >> of a wall, and then got sidetracked on another project. I was going to use >> llc to generate COFF object files

On Wed, 9 Jun 2010 18:15:23 -0400, Bigcheese <bigcheesegs at gmail.com> wrote: > > I was looking into writing this test for MC based on the MachO tests, > but llvm-mc cannot read .s files as COFF because it simply lacks > support for it. It tries to read everything as MachO. FYI, I've been working wth Daniel to try and pull all the Mach-O specific things out of llvm-mc and

This is cool, I was looking into something like this, but hit a little bit of a wall, and then got sidetracked on another project. I was going to use llc to generate COFF object files as opposed to clang. Seems to me llc would give better control over what was generated and would also not require clang to be in the tree. Is there any documentation on how to run these tests from windows? - Nathan

On Sun, Jul 11, 2010 at 6:10 PM, Chris Lattner <clattner at apple.com> wrote: > This probably needs to be slightly tweaked to work with mainline.  I don't see anything objectionable, but I think Daniel needs to review this one. Updated patch to work with mainline. http://github.com/Bigcheese/llvm-mirror/commit/d19a4c82c18afc4830c09b70f02d162292231c94 - Michael Spencer

> Could be, echristo, bigcheese, would this be correct for Mach-O and COFF? bigcheese noted on IRC that the test crashes the COFF emitter. For some reason I am always getting movl $256, %eax ## imm = 0x100 calll *%eax on darwin already, so I guess you are right, the correct would be isTargetELF() && TM.getRelocationModel() == Reloc::Static; Please include a test

2011/10/21 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>: >> Could be, echristo, bigcheese, would this be correct for Mach-O and COFF? > > bigcheese noted on IRC that the test crashes the COFF emitter. For some > reason I am always getting > >        movl    $256, %eax              ## imm = 0x100 >        calll   *%eax > > on darwin already IIRC, we

Eli, Hm. There's a test in (CodeGen/X86/call-imm.ll) which uses darwin with relocation model static. It expects to use call-to-immediate. Is this in error? Should I disable this check? - pdox On Fri, Oct 21, 2011 at 11:49 AM, Eli Friedman <eli.friedman at gmail.com> wrote: > 2011/10/21 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>: >>> Could be,

IIRC the kernel uses relocation model as static. -eric On Oct 21, 2011, at 3:57 PM, David Meyer wrote: > Eli, > > Hm. There's a test in (CodeGen/X86/call-imm.ll) which uses darwin with > relocation model static. It expects to use call-to-immediate. > > Is this in error? Should I disable this check? > > - pdox > > On Fri, Oct 21, 2011 at 11:49 AM, Eli

Thought a bit more. There's also -mdynamic-no-pic. Not typically used these days, but is still there AFAIK. -Jim On Oct 21, 2011, at 4:05 PM, Eric Christopher wrote: > IIRC the kernel uses relocation model as static. > > -eric > > On Oct 21, 2011, at 3:57 PM, David Meyer wrote: > >> Eli, >> >> Hm. There's a test in (CodeGen/X86/call-imm.ll) which

Hi Michael, Overall patch looks good. I do have a few comments below. My main comment is please try to make the style match that used in the MCMachOStreamer more closely. I intend to refactor more functionality into the base MCObjectStreamer class, and having them use consistent idioms makes this easier; specific instances are included in the comments: -- > diff --git