llvm dev - Jul 2010 - [LLVMdev] Win32 COFF Support - Patch 2

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org>
wrote:
>  - Please split the patch into at least four parts:
>    (1) Add WinCOFFStreamer, with a stub implementation.
>    (2) Add WinCOFFObjectWriter, with a stub implementation.
>    (3) Fill in WinCOFFStreamer.
>    (4) Fill in WinCOFFObjectWriter.
Here's the 2nd patch.

http://github.com/Bigcheese/llvm-mirror/commit/b008e685065bef8242bb04cb8b7636cc2610522b

And a git patch is attached this time (Can't really make an svn style
patch until the 1st patch is committed).

- Michael Spencer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ms-coff-patch-2.patch
Type: application/octet-stream
Size: 3330 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20100703/b8ba5b81/attachment.obj>

Looks good, committed in r108103.  I changes various _OS arguments to be named
OS.  Please don't use underbars as the first character of an identifier,
they are a reserved namespace for the compiler implementation (with capital
letters).

-Chris

On Jul 2, 2010, at 9:26 PM, Michael Spencer wrote:
> On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org>
wrote:
>> - Please split the patch into at least four parts:
>>   (1) Add WinCOFFStreamer, with a stub implementation.
>>   (2) Add WinCOFFObjectWriter, with a stub implementation.
>>   (3) Fill in WinCOFFStreamer.
>>   (4) Fill in WinCOFFObjectWriter.
> 
> Here's the 2nd patch.
> 
>
http://github.com/Bigcheese/llvm-mirror/commit/b008e685065bef8242bb04cb8b7636cc2610522b
> 
> And a git patch is attached this time (Can't really make an svn style
> patch until the 1st patch is committed).
> 
> - Michael Spencer
>
<ms-coff-patch-2.patch>_______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev