I just finished the initial split up of WinCOFF.h into llvm/Support/COFF.h and lib/MC/WinCOFFObjectWriter.cpp. This includes almost the minimum changes required to split them up. WinCOFFObjectWriter now needs some refactoring to make things more consistent and less verbose. There also seem to be quite a few memory leaks that need to be resolved. http://github.com/Bigcheese/llvm-mirror/commit/a6f207e2a9b04e1c82c949e207b8f420535e3c2f (still passes the test) Any ideas for refactoring this are welcome. I have some ideas for refactoring, but I would feel a lot better about making any major changes if I had some outside input. I'm now going to make the stub patches that Daniel requested. - Michael Spencer
On Wed, Jun 23, 2010 at 12:22 AM, Michael Spencer <bigcheesegs at gmail.com> wrote:> I'm now going to make the stub patches that Daniel requested.Added llvm/Support/COFF.h and merged in COFF constants from llvm/MC/MCSectionCOFF.h. Zeroth patch is done. http://github.com/Bigcheese/llvm-mirror/commit/2d88aa08a072bb5f8d687b67d1476f23d37a87d4 A svn-style patch against svn HEAD is also attached. - Michael Spencer -------------- next part -------------- A non-text attachment was scrubbed... Name: ms-coff-patch-0.svn.patch Type: application/octet-stream Size: 22348 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100623/2d55197a/attachment.obj>
This looks good to me, I think it should be applied immediately. - Nathan On Wed, Jun 23, 2010 at 12:11 AM, Michael Spencer <bigcheesegs at gmail.com>wrote:> On Wed, Jun 23, 2010 at 12:22 AM, Michael Spencer <bigcheesegs at gmail.com> > wrote: > > I'm now going to make the stub patches that Daniel requested. > > Added llvm/Support/COFF.h and merged in COFF constants from > llvm/MC/MCSectionCOFF.h. > > Zeroth patch is done. > > > http://github.com/Bigcheese/llvm-mirror/commit/2d88aa08a072bb5f8d687b67d1476f23d37a87d4 > > A svn-style patch against svn HEAD is also attached. > > - Michael Spencer >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20100623/e8d1cae7/attachment.html>
On Wed, Jun 23, 2010 at 12:11 AM, Michael Spencer <bigcheesegs at gmail.com> wrote:> On Wed, Jun 23, 2010 at 12:22 AM, Michael Spencer <bigcheesegs at gmail.com> wrote: >> I'm now going to make the stub patches that Daniel requested. > > Added llvm/Support/COFF.h and merged in COFF constants from > llvm/MC/MCSectionCOFF.h. > > Zeroth patch is done. > > http://github.com/Bigcheese/llvm-mirror/commit/2d88aa08a072bb5f8d687b67d1476f23d37a87d4 > > A svn-style patch against svn HEAD is also attached.Patch looks good, thanks for splitting this up! Applied in r107418. - Daniel> - Michael Spencer >