similar to: [PATCH server] Add svc_vm_actions method to VmService.

--- .../functional/cloud/instance_controller_test.rb | 2 +- src/test/unit/vm_service_test.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/functional/cloud/instance_controller_test.rb b/src/test/functional/cloud/instance_controller_test.rb index 71d132b..0d713d4 100644 --- a/src/test/functional/cloud/instance_controller_test.rb +++

The following two patches should be applied in the order: * [PATCH server] Add svc_vm_actions method to VmService. * [PATCH server] Cloud UI layer to initiate actions on vms. The service layer patch should work fine on its own (and not break anything), but cloud patch relies on service being there.

This resend includes the rebase, but fixes a problem I just noticed with nil/empty checks.

This is a resend of the 2-patch series from a week or so ago, needed to be rebased due to some commits on next

Signed-off-by: Simon COURTOIS <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 5 ++ src/app/models/vm_task.rb | 4 +- src/app/views/vm/start.rhtml | 77 ++++++++++++++++++++++++++++++++++ src/task-omatic/taskomatic.rb | 7 +++- 4 files changed, 91 insertions(+), 2 deletions(-) create mode 100644 src/app/views/vm/start.rhtml diff

- db, model, service, controller, and view changes - many tests additions - various fixes / cleanup to get things working depends on my last two (still unacked) patches: - add collapsable sections to vm form - provide default vm allocated cpu and memory values ovirt-agent might need to be updated to work with the changes --- src/app/controllers/pool_controller.rb | 2 +-

I've pulled out the no-longer-necessary remnants of the old way of handling auth and before_filters as well as fixing a couple bugs that had crept in along the way. Unit test fixes for the refactoring will follow in a subsequent patch. Signed-off-by: Scott Seago <sseago at redhat.com> --- src/app/controllers/application.rb | 46 ----------------

since the introduction of ovirt-vnc-proxy and the updating of ovirt-viewer to user it the forward vnc functionality is no longer necessary / and incompatable w/ the current system. --- src/app/controllers/vm_controller.rb | 2 - src/app/models/host.rb | 9 - src/app/models/vm.rb | 36 ----

Previously, a pxe-booted vm would always boot to HD at next startup. Signed-off-by: Nicolas Ochem <nicolas.ochem at alcatel-lucent.com> --- src/app/controllers/vm_controller.rb | 1 + src/app/models/vm.rb | 15 +++++++++++---- src/app/views/vm/_form.rhtml | 2 +- src/task-omatic/taskomatic.rb | 13 +++++++++++-- 4 files changed, 24 insertions(+), 7

This patch fixes state changes in dbomatic so that there is no intermediate 'stopped' state after being unreachable or on startup of dbomatic etc. Also fixes a number of smaller bugs around host associations, state changes, etc. Signed-off-by: Ian Main <imain at redhat.com> --- src/db-omatic/db_omatic.rb | 85 +++++++++++++++++++++++++++++++------------- 1 files changed, 60

Forwarding to the list for Jay or Scott to have a look. Ignazio, do you see any more details (traceback or something) in the rails log? -------------- next part -------------- An embedded message was scrubbed... From: ignazio.cassano at provincia.torino.it Subject: Re: [Ovirt-devel] [PATCH node-image] keep NIC and HBA firmwares Date: Wed, 16 Sep 2009 16:48:47 +0200 Size: 4031 URL:

This patch updates dbomatic, taskomatic and host-register to use the new C++ wrapped ruby QMF bindings. It also fixes a couple of bugs along the way including the 0 cpu bug for host-register. This is a compilation of work done by myself and Arjun Roy. Signed-off-by: Ian Main <imain at redhat.com> --- src/db-omatic/db_omatic.rb | 111 ++++++-------

This patch uses the qpid migration call which requires the latest libvirt-qpid and libvirt. I also add a bunch of debug logging here which is switchable but I've left it on for now so all users will have this in their logs. Signed-off-by: Ian Main <imain at redhat.com> --- src/task-omatic/taskomatic.rb | 36 ++++++++++++++++++++++++++++-------- 1 files changed, 28 insertions(+), 8

Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/task-omatic/taskomatic.rb | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index 471ec88..1dfd74f 100755 --- a/src/task-omatic/taskomatic.rb +++ b/src/task-omatic/taskomatic.rb @@ -355,11 +355,10 @@ class TaskOmatic end end

Hi, is there a good reason why taskomatic check the number of real cores in the find_capable_host ? It prevents to use the full capacity of multithreading Signed-off-by: Arthur Clement <aclement at linagora.com> --- src/task-omatic/taskomatic.rb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb index

From: Simon Courtois <scourtois at linagora.com> Signed-off-by: Simon Courtois <scourtois at linagora.com> --- src/app/controllers/vm_controller.rb | 19 ++++++++++++++++- src/app/views/vm/_form.rhtml | 25 ++++++++++++++++++++--- src/db/migrate/044_add_virtio_to_vm_and_nic.rb | 11 ++++++++++ src/public/stylesheets/components.css | 5

Hi, Does somebody know what is the purpose of this line in taskomatic.rb : set_vm_vnc_port(db_vm, result.description) unless result.status != 0 We removed it to avoid 2 errors in taskomatic.log when a vm is launched : ERROR Mon Aug 30 15:23:00 +0000 2010 (26416) Task action processing failed: ActiveRecord::RecordInvalid: Validation failed: Vnc port must be greater than or equal to 0 ERROR

This patch changes taskomatic so it only sets the VM to shutdown if the undefine succeeds. Otherwise it's possible a shutdown event could not succeed, or take a while as it often does, giving confusing messages to the user. Basically we're just letting dbomatic handle it now. Signed-off-by: Ian Main <imain at redhat.com> --- src/task-omatic/taskomatic.rb | 1 - 1 files

Hi all, We use for preproduction purpose the next branche of oVirt. We notice that a lot of bugs appears when the number of message in qpidd increase. It seems that qpidd is doing the job and that most of the issue are due to Qmf::Query . For example in db-omatic lines 265,296 When you restart db-omatic, if you have multiple node, you have mutiple threads launch (line 266) that hang on :

This fix db-omatic that cannot recover the node on wich the vm run for example. We have not investigate far away but that can be due to a change on the ruby-qmf API. Signed-off-by: Michel Loiseleur <mloiseleur at linagora.com> --- src/db-omatic/db_omatic.rb | 10 ++++++---- src/libvirt-list.rb | 6 +++--- src/matahari-list.rb | 4 ++-- 3 files changed, 11