Ovirt devel - May 2009 - [PATCH server] Don't set VM state to shut down in task.

This patch changes taskomatic so it only sets the VM to shutdown if
the undefine succeeds.  Otherwise it's possible a shutdown event could
not succeed, or take a while as it often does, giving confusing
messages to the user.  Basically we're just letting dbomatic handle
it now.

Signed-off-by: Ian Main <imain at redhat.com>
---
 src/task-omatic/taskomatic.rb |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb
index 11d13cb..5393c29 100755
--- a/src/task-omatic/taskomatic.rb
+++ b/src/task-omatic/taskomatic.rb
@@ -286,7 +286,6 @@ class TaskOmatic
       result = vm.undefine
       if result.status == 0
         @logger.info "Deleted VM #{db_vm.description}."
-        set_vm_shut_down(db_vm)
         teardown_storage_pools(node)
       end
       return
-- 
1.6.0.6

I can't really ACK, this - as I said in irc, db-omatic doesnt do the right
thing here.  If I shut down a vm, it (db-omatic) says it is shutting down
the vm (setting state) and clearing attributes.  Then it sets the vm state
back to running.  Perhaps this is unrelated, but it does not work right as
is.

On Fri, May 29, 2009 at 2:43 PM, Ian Main <imain at redhat.com> wrote:
> This patch changes taskomatic so it only sets the VM to shutdown if
> the undefine succeeds.  Otherwise it's possible a shutdown event could
> not succeed, or take a while as it often does, giving confusing
> messages to the user.  Basically we're just letting dbomatic handle
> it now.
>
> Signed-off-by: Ian Main <imain at redhat.com>
> ---
>  src/task-omatic/taskomatic.rb |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb
> index 11d13cb..5393c29 100755
> --- a/src/task-omatic/taskomatic.rb
> +++ b/src/task-omatic/taskomatic.rb
> @@ -286,7 +286,6 @@ class TaskOmatic
>       result = vm.undefine
>       if result.status == 0
>         @logger.info "Deleted VM #{db_vm.description}."
> -        set_vm_shut_down(db_vm)
>         teardown_storage_pools(node)
>       end
>       return
> --
> 1.6.0.6
>
> _______________________________________________
> Ovirt-devel mailing list
> Ovirt-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/ovirt-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://listman.redhat.com/archives/ovirt-devel/attachments/20090529/94fbbeec/attachment.htm>