Ovirt devel - Sep 2010 - [PATCH] Check cpus capacity, not real cores.

Hi, is there a good reason why taskomatic check the number of real cores in the
find_capable_host ? It prevents to use the full capacity of multithreading


Signed-off-by: Arthur Clement <aclement at linagora.com>
---
 src/task-omatic/taskomatic.rb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb
index 6f699d2..59a0fdd 100755
--- a/src/task-omatic/taskomatic.rb
+++ b/src/task-omatic/taskomatic.rb
@@ -169,7 +169,7 @@ class TaskOmatic
       #puts "and not #{curr.is_disabled.nil?} and #{curr.is_disabled ==
0}"
       #puts "and #{vm ? vm : 'nil'} or #{vm ? vm.active :
'nil'}) or #{vm ? vm.node : 'nil'} != #{node.object_id}"
 
-      if node and node.cores >= db_vm.num_vcpus_allocated \
+      if node and node.cpus >= db_vm.num_vcpus_allocated \
          and node.memory >= db_vm.memory_allocated \
          and not curr.is_disabled.nil? and curr.is_disabled == 0 \
          and ((!vm or vm.active == 'false') or vm.node !=
node.object_id)
-- 
1.7.2.3

ACK on irc and pushed
comments above the code updated

On mardi 21 septembre 2010 18:24:02 Arthur Clement
wrote:
> Hi, is there a good reason why taskomatic check the number of real cores in
> the find_capable_host ? It prevents to use the full capacity of
> multithreading
> 
> 
> Signed-off-by: Arthur Clement <aclement at linagora.com>
> ---
>  src/task-omatic/taskomatic.rb |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/task-omatic/taskomatic.rb b/src/task-omatic/taskomatic.rb
> index 6f699d2..59a0fdd 100755
> --- a/src/task-omatic/taskomatic.rb
> +++ b/src/task-omatic/taskomatic.rb
> @@ -169,7 +169,7 @@ class TaskOmatic
>        #puts "and not #{curr.is_disabled.nil?} and #{curr.is_disabled
=> 0}" #puts "and #{vm ? vm : 'nil'} or #{vm ? vm.active :
'nil'}) or #{vm ?
> vm.node : 'nil'} != #{node.object_id}"
> 
> -      if node and node.cores >= db_vm.num_vcpus_allocated \
> +      if node and node.cpus >= db_vm.num_vcpus_allocated \
>           and node.memory >= db_vm.memory_allocated \
>           and not curr.is_disabled.nil? and curr.is_disabled == 0 \
>           and ((!vm or vm.active == 'false') or vm.node !=
node.object_id)
-- 
Arthur CLEMENT
Linagora Paris