search for: wincoffobjectwriters

On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> wrote: > > Whats going on with having both write_uint32_le() > in WinCOFFObjectWriter::DefineSection() and WriteLE32() in > WinCOFFObjectWriter::WriteFileHeader() ? > Aaron Thanks, missed that one. Nathan used write_uint32_le in WinCOFF.h, and I guess accidentally used it in WinCOFFObjectWriter.cpp.

I have updated my patch based on Chris'es feedback. I removed the dbgout_calls macro, but left others in place for now. If there are no objections, I would like to commit this tomorrow evening (~7PM GMT-7). I have compiled and tested it on MSVC, with Michaels testing code and it looks good. Once this is committed, Michaels patch can be applied. -Nathan -------------- next part --------------

Hi, Recently I was hit by an assert in WinCOFFObjectWriter that had forbidden storing pointer to string table in header name field when the pointer had more that 6 decimal digits. This limit had been chosen to make implementation easier (sprintf adds null character at the end) and could be increased to 7 digits. My patch is attached. The implementation uses additional buffer on the stack to make

Hi guys, While trying to get dwarf debugging information to work with Win32 COFF targets, I came across a couple of issues with the current implementation of WinCOFFObjectWriter. Emitting empty section causes debug information to invalid, as the presence of certain debug section implies available information, and emission of labels as symbols confused gdb about the structure of the program. The

Is there a problem if the string is not null terminated? If not, you can snprintf it right into place instead of doing sprintf+mempcy. On Tue, Jul 23, 2013 at 12:29 PM, Paweł Bylica <pawel.bylica at ibs.org.pl>wrote: > Hi, > > Recently I was hit by an assert in WinCOFFObjectWriter that had forbidden > storing pointer to string table in header name field when the pointer had

write_uint32_le is used to write into a arbitrary data buffer, where as WriteLE32 is used to write into the object file. On Mon, Jun 21, 2010 at 9:01 AM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 9:37 AM, Aaron Gray <aaronngray.lists at gmail.com> > wrote: > > > > Whats going on with having both write_uint32_le() > > in

In article <CACs=ty+7zKZU6Ad4jZ5J5Rb0qoMa-bNtO0f+xK_8SYfy3RyFbg at mail.gmail.com>, Reid Kleckner <rnk at google.com> writes: > Is there a problem if the string is not null terminated? If not, you can > snprintf it right into place instead of doing sprintf+mempcy. Am I the only one who scratches my head and says: sprintf? memcpy? Why are we using error-prone C APIs in

On Tue, Jul 23, 2013 at 12:48 PM, Nico Rieck <nico.rieck at gmail.com> wrote: > On 23.07.2013 18:43, Reid Kleckner wrote: > >> Is there a problem if the string is not null terminated? If not, you can >> snprintf it right into place instead of doing sprintf+mempcy. >> > > snprintf always null-terminates (and truncates if there's not enough > space).

On 23.07.2013 18:43, Reid Kleckner wrote: > Is there a problem if the string is not null terminated? If not, you can > snprintf it right into place instead of doing sprintf+mempcy. snprintf always null-terminates (and truncates if there's not enough space). -Nico

On Sun, Sep 26, 2010 at 3:28 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > Hi guys, > > While trying to get dwarf debugging information to work with Win32 COFF > > targets, I came across a couple of issues with the current implementation > > of

On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > write_uint32_le is used to write into a arbitrary data buffer, where as >  WriteLE32 is used to write into the object file. Ah, I didn't notice that. Here's yet another style patch. Thanks to coppro for the review that found most of these. (note, I made a branch and did a rebase just so I

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: >  - Please split the patch into at least four parts: >    (1) Add WinCOFFStreamer, with a stub implementation. >    (2) Add WinCOFFObjectWriter, with a stub implementation. >    (3) Fill in WinCOFFStreamer. >    (4) Fill in WinCOFFObjectWriter. Here's the 1'st patch.

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Here's the 2nd patch.

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. 3rd patch

On Wed, Jun 16, 2010 at 1:46 PM, Daniel Dunbar <daniel at zuster.org> wrote: > - Please split the patch into at least four parts: > (1) Add WinCOFFStreamer, with a stub implementation. > (2) Add WinCOFFObjectWriter, with a stub implementation. > (3) Fill in WinCOFFStreamer. > (4) Fill in WinCOFFObjectWriter. Attached is patch number 4. - Michael Spencer

On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > Hi guys, > While trying to get dwarf debugging information to work with Win32 COFF > targets, I came across a couple of issues with the current implementation > of WinCOFFObjectWriter. Emitting empty section causes debug information to > invalid, as the presence of certain debug section

On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > Hi guys, > While trying to get dwarf debugging information to work with Win32 COFF > targets, I came across a couple of issues with the current implementation > of WinCOFFObjectWriter. Emitting empty section causes debug information to > invalid, as the presence of certain debug section

On Tue, Sep 28, 2010 at 7:39 PM, Michael Spencer <bigcheesegs at gmail.com> wrote: > On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: >> Hi guys, >> While trying to get dwarf debugging information to work with Win32 COFF >> targets, I came across a couple of issues with the current implementation >>

On Sun, Sep 26, 2010 at 6:47 PM, Nathan Jeffords <blunted2night at gmail.com> wrote: > On Sun, Sep 26, 2010 at 3:28 PM, Michael Spencer <bigcheesegs at gmail.com> > wrote: >> >> On Sun, Sep 26, 2010 at 5:27 PM, Nathan Jeffords >> <blunted2night at gmail.com> wrote: >> > Hi guys, >> > While trying to get dwarf debugging information to work

Right on, thanks for working on this. I have been busy lately, but its good to see progress being made. On Mon, Jun 21, 2010 at 11:31 PM, Michael Spencer <bigcheesegs at gmail.com>wrote: > On Mon, Jun 21, 2010 at 3:15 PM, Nathan Jeffords > <blunted2night at gmail.com> wrote: > > write_uint32_le is used to write into a arbitrary data buffer, where as > > WriteLE32