search for: virtio_ccw_int_handl

Hi, 016c98c6f virtio: unify config_changed handling introduced a warning in virtio_ccw which is fixed by the following patch. Regards, Sebastian --- virtio_ccw: remove unsued variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/kvm/virti...

Hi, 016c98c6f virtio: unify config_changed handling introduced a warning in virtio_ccw which is fixed by the following patch. Regards, Sebastian --- virtio_ccw: remove unsued variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/kvm/virti...

...s, > > Sebastian > > --- > > virtio_ccw: remove unsued variable > > s/unsued/unused/ > Totally forgot to send an updated version..sry. Here it is. Regards, Sebastian --- virtio_ccw: remove unused variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 1 - 1 file...

...s, > > Sebastian > > --- > > virtio_ccw: remove unsued variable > > s/unsued/unused/ > Totally forgot to send an updated version..sry. Here it is. Regards, Sebastian --- virtio_ccw: remove unused variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 1 - 1 file...

...28 Oct 2014 19:37:58 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > > virtio_ccw: remove unused variable > > > > Fix this warning: > > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > > struct virtio_driver *drv; > > > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com&gt...

...28 Oct 2014 19:37:58 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote: > On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > > virtio_ccw: remove unused variable > > > > Fix this warning: > > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > > struct virtio_driver *drv; > > > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com&gt...

Michael, here's one fix for the virtio-ccw driver. Patch is against master, as your git branches on mst/vhost.git seem to be quite old. Is there some branch I can base my own branch on, or do you prefer to take patches directly anyway? Cornelia Huck (1): virtio/s390: handle error values in irb drivers/s390/virtio/virtio_ccw.c | 62 ++++++++++++++++++++++++---------------- 1 file

Michael, here's one fix for the virtio-ccw driver. Patch is against master, as your git branches on mst/vhost.git seem to be quite old. Is there some branch I can base my own branch on, or do you prefer to take patches directly anyway? Cornelia Huck (1): virtio/s390: handle error values in irb drivers/s390/virtio/virtio_ccw.c | 62 ++++++++++++++++++++++++---------------- 1 file

...o: unify config_changed handling > > introduced a warning in virtio_ccw which is fixed by the following patch. > > Regards, > Sebastian > --- > virtio_ccw: remove unsued variable s/unsued/unused/ > > Fix this warning: > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > struct virtio_driver *drv; > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > --- > drivers/s390/kvm/virtio_ccw.c | 1 - > 1 file changed, 1 deletion(-) &...

...ed variable > > > > s/unsued/unused/ > > > > Totally forgot to send an updated version..sry. Here it is. > > Regards, > Sebastian > > --- > virtio_ccw: remove unused variable > > Fix this warning: > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > struct virtio_driver *drv; > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> Acked-by: Michael S. T...

..."Michael S. Tsirkin" <mst at redhat.com> wrote: > >> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > >> > virtio_ccw: remove unused variable >> > >> > Fix this warning: >> > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: >> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] >> > struct virtio_driver *drv; >> > >> > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> >> > Acked-by: Cornelia Huck <cornelia.h...

The interrupt handler virtio_ccw_int_handler() using the vcdev pointer is protected by the ccw_device lock. Resetting the pointer within the ccw_device structure should be done when holding this lock. Also resetting the vcdev pointer (under the ccw_device lock) prior to freeing the vcdev pointer memory removes a critical path. Signed-off-...

Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter interrupt support. arch/s390/include/asm/irq.h

Hi, next version of the guest exploitation of virtio-ccw adapter interrupts. Changes from the last version: - adapt to latest kvm-next - changed housekeeping for indicator locations: we now use cacheline-sized and aligned areas - minor tweaks Cornelia Huck (2): KVM: s390: virtio-ccw: Handle command rejects. KVM: s390: virtio-ccw adapter interrupt support. arch/s390/include/asm/irq.h

...break; - } case VIRTIO_PARAM_DEV_ADD: schedule_work(&hotplug_work); break; diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index d2c0b44..6cbe6ef 100644 --- a/drivers/s390/kvm/virtio_ccw.c +++ b/drivers/s390/kvm/virtio_ccw.c @@ -940,11 +940,7 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, vring_interrupt(0, vq); } if (test_bit(0, &vcdev->indicators2)) { - drv = container_of(vcdev->vdev.dev.driver, - struct virtio_driver, driver); - - if (drv && drv->config_changed) - drv->config_changed(&vcdev->vdev); + virt...

...break; - } case VIRTIO_PARAM_DEV_ADD: schedule_work(&hotplug_work); break; diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index d2c0b44..6cbe6ef 100644 --- a/drivers/s390/kvm/virtio_ccw.c +++ b/drivers/s390/kvm/virtio_ccw.c @@ -940,11 +940,7 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, vring_interrupt(0, vq); } if (test_bit(0, &vcdev->indicators2)) { - drv = container_of(vcdev->vdev.dev.driver, - struct virtio_driver, driver); - - if (drv && drv->config_changed) - drv->config_changed(&vcdev->vdev); + virt...

This patch (on top of "virtio/s390: handle failures of READ_VQ_CONF ccw") implements the guest side of the new status ccw. Pierre Morel (1): virtio/s390: support READ_STATUS command for virtio-ccw drivers/s390/virtio/virtio_ccw.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) -- 2.3.8

...0x000003ffd867dadc 0x000003ffdca7c818 #0 [3e00035faf8] arch_spin_lock_wait at a7bd52 #1 [3e00035fb50] ccw_io_helper at 9130ea #2 [3e00035fbd0] virtio_ccw_get_config at 914a28 #3 [3e00035fc30] virtballoon_changed at 76e776 #4 [3e00035fc70] virtio_config_changed at 76aabc #5 [3e00035fca8] virtio_ccw_int_handler at 914ede #6 [3e00035fd18] ccw_device_irq at 8941d4 #7 [3e00035fd48] do_cio_interrupt at 885906 #8 [3e00035fd80] __handle_irq_event_percpu at 1b3c22 #9 [3e00035fdf0] handle_irq_event_percpu at 1b3e1e #10 [3e00035fe28] handle_percpu_irq at 1b87d8 #11 [3e00035fe58] generic_handle_irq at 1b2ce6...

This patch (on top of "virtio/s390: handle failures of READ_VQ_CONF ccw") implements the guest side of the new status ccw. Pierre Morel (1): virtio/s390: support READ_STATUS command for virtio-ccw drivers/s390/virtio/virtio_ccw.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) -- 2.3.8

.../s390/kvm/virtio_ccw.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index 779dc51..d6c7aba 100644 --- a/drivers/s390/kvm/virtio_ccw.c +++ b/drivers/s390/kvm/virtio_ccw.c @@ -639,8 +639,15 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, (SCSW_STCTL_ALERT_STATUS | SCSW_STCTL_STATUS_PEND))) { /* OK */ } - if (irb_is_error(irb)) - vcdev->err = -EIO; /* XXX - use real error */ + if (irb_is_error(irb)) { + /* Command reject? */ + if ((scsw_dstat(&irb->scsw) & DEV_STAT_UNIT_CHECK)...