Hi,
016c98c6f virtio: unify config_changed handling
introduced a warning in virtio_ccw which is fixed by the following patch.
Regards,
Sebastian
---
virtio_ccw: remove unsued variable
Fix this warning:
drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?:
drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv?
[-Wunused-variable]
struct virtio_driver *drv;
Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com>
---
drivers/s390/kvm/virtio_ccw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c
index 6cbe6ef..bda52f1 100644
--- a/drivers/s390/kvm/virtio_ccw.c
+++ b/drivers/s390/kvm/virtio_ccw.c
@@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev,
struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev);
int i;
struct virtqueue *vq;
- struct virtio_driver *drv;
if (!vcdev)
return;
--
1.8.4.2
On Mon, 20 Oct 2014 12:48:18 +0200 (CEST) Sebastian Ott <sebott at linux.vnet.ibm.com> wrote:> Hi, > > 016c98c6f virtio: unify config_changed handling > > introduced a warning in virtio_ccw which is fixed by the following patch. > > Regards, > Sebastian > --- > virtio_ccw: remove unsued variable > > Fix this warning: > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > struct virtio_driver *drv; > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > --- > drivers/s390/kvm/virtio_ccw.c | 1 - > 1 file changed, 1 deletion(-)Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> Rusty: Will you take this through the virtio tree, or should I push this through the kvm/s390 tree?
On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote:> Hi, > > 016c98c6f virtio: unify config_changed handling > > introduced a warning in virtio_ccw which is fixed by the following patch. > > Regards, > Sebastian > --- > virtio_ccw: remove unsued variables/unsued/unused/> > Fix this warning: > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > struct virtio_driver *drv; > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > --- > drivers/s390/kvm/virtio_ccw.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c > index 6cbe6ef..bda52f1 100644 > --- a/drivers/s390/kvm/virtio_ccw.c > +++ b/drivers/s390/kvm/virtio_ccw.c > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev); > int i; > struct virtqueue *vq; > - struct virtio_driver *drv; > > if (!vcdev) > return; > -- > 1.8.4.2
On Mon, 20 Oct 2014, Michael S. Tsirkin wrote:> On Mon, Oct 20, 2014 at 12:48:18PM +0200, Sebastian Ott wrote: > > Hi, > > > > 016c98c6f virtio: unify config_changed handling > > > > introduced a warning in virtio_ccw which is fixed by the following patch. > > > > Regards, > > Sebastian > > --- > > virtio_ccw: remove unsued variable > > s/unsued/unused/ >Totally forgot to send an updated version..sry. Here it is. Regards, Sebastian --- virtio_ccw: remove unused variable Fix this warning: drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] struct virtio_driver *drv; Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> --- drivers/s390/kvm/virtio_ccw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c index 6cbe6ef..bda52f1 100644 --- a/drivers/s390/kvm/virtio_ccw.c +++ b/drivers/s390/kvm/virtio_ccw.c @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev); int i; struct virtqueue *vq; - struct virtio_driver *drv; if (!vcdev) return; -- 1.8.4.2