On Tue, 28 Oct 2014 19:37:58 +0200 "Michael S. Tsirkin" <mst at redhat.com> wrote:> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote:> > virtio_ccw: remove unused variable > > > > Fix this warning: > > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > > struct virtio_driver *drv; > > > > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> > > Acked-by: Michael S. Tsirkin <mst at redhat.com> > > > --- > > drivers/s390/kvm/virtio_ccw.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c > > index 6cbe6ef..bda52f1 100644 > > --- a/drivers/s390/kvm/virtio_ccw.c > > +++ b/drivers/s390/kvm/virtio_ccw.c > > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, > > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev); > > int i; > > struct virtqueue *vq; > > - struct virtio_driver *drv; > > > > if (!vcdev) > > return;*pokes Rusty* Do you want to send this via the virtio tree? Otherwise, I'll queue this with kvm/s390.
Cornelia Huck <cornelia.huck at de.ibm.com> writes:> On Tue, 28 Oct 2014 19:37:58 +0200 > "Michael S. Tsirkin" <mst at redhat.com> wrote: > >> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > >> > virtio_ccw: remove unused variable >> > >> > Fix this warning: >> > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: >> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] >> > struct virtio_driver *drv; >> > >> > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> >> > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> >> >> Acked-by: Michael S. Tsirkin <mst at redhat.com> >> >> > --- >> > drivers/s390/kvm/virtio_ccw.c | 1 - >> > 1 file changed, 1 deletion(-) >> > >> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c >> > index 6cbe6ef..bda52f1 100644 >> > --- a/drivers/s390/kvm/virtio_ccw.c >> > +++ b/drivers/s390/kvm/virtio_ccw.c >> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, >> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev); >> > int i; >> > struct virtqueue *vq; >> > - struct virtio_driver *drv; >> > >> > if (!vcdev) >> > return; > > *pokes Rusty* > > Do you want to send this via the virtio tree? Otherwise, I'll queue > this with kvm/s390.*Rusty wakes*. I assumed you would take it when I skimmed the patch, but to be formal: Acked-by: Rusty Russell <rusty at rustcorp.com.au> Sorry for the delay, Rusty.
On Fri, 31 Oct 2014 10:31:19 +1030 Rusty Russell <rusty at rustcorp.com.au> wrote:> Cornelia Huck <cornelia.huck at de.ibm.com> writes: > > On Tue, 28 Oct 2014 19:37:58 +0200 > > "Michael S. Tsirkin" <mst at redhat.com> wrote: > > > >> On Tue, Oct 28, 2014 at 04:39:12PM +0100, Sebastian Ott wrote: > > > >> > virtio_ccw: remove unused variable > >> > > >> > Fix this warning: > >> > drivers/s390/kvm/virtio_ccw.c: In function ?virtio_ccw_int_handler?: > >> > drivers/s390/kvm/virtio_ccw.c:891:24: warning: unused variable ?drv? [-Wunused-variable] > >> > struct virtio_driver *drv; > >> > > >> > Signed-off-by: Sebastian Ott <sebott at linux.vnet.ibm.com> > >> > Acked-by: Cornelia Huck <cornelia.huck at de.ibm.com> > >> > >> Acked-by: Michael S. Tsirkin <mst at redhat.com> > >> > >> > --- > >> > drivers/s390/kvm/virtio_ccw.c | 1 - > >> > 1 file changed, 1 deletion(-) > >> > > >> > diff --git a/drivers/s390/kvm/virtio_ccw.c b/drivers/s390/kvm/virtio_ccw.c > >> > index 6cbe6ef..bda52f1 100644 > >> > --- a/drivers/s390/kvm/virtio_ccw.c > >> > +++ b/drivers/s390/kvm/virtio_ccw.c > >> > @@ -888,7 +888,6 @@ static void virtio_ccw_int_handler(struct ccw_device *cdev, > >> > struct virtio_ccw_device *vcdev = dev_get_drvdata(&cdev->dev); > >> > int i; > >> > struct virtqueue *vq; > >> > - struct virtio_driver *drv; > >> > > >> > if (!vcdev) > >> > return; > > > > *pokes Rusty* > > > > Do you want to send this via the virtio tree? Otherwise, I'll queue > > this with kvm/s390. > > *Rusty wakes*. > > I assumed you would take it when I skimmed the patch, but to be formal: > > Acked-by: Rusty Russell <rusty at rustcorp.com.au>Applied.