search for: unreview

Luke, What state should I put them in if I have looked a ticket, but it requires more information to decide what to do next? Can we add a "needs more info" or something similar where you select "unreviewed"? Mike B. ---------------------------------------------------------------- This message was sent using IMP, the Internet Messaging Program.

...> since this would be using the interpolated code (unless you're really > lucky with the rate), the cost shouldn't be too high. BTW, do you know > how often the rate gets updated? The rate is, by default, updated every 10 seconds. And sometimes (especially with the not-so-recent unreviewed patches) we do get lucky and resample from 44100 to 44100 Hz, and the next 10 seconds from 44100 to 44101 Hz. -- Alexander E. Patrakov

...l. While I was at it, I found some inconsistencies in comments in arch/x86/include/asm/barrier.h I hope I'm not splitting this up too much - the reason is I wanted to isolate the code changes (that people might want to test for performance) from comment changes approved by Linus, from (so far unreviewed) comment change I came up with myself. Lightly tested on my system. Michael S. Tsirkin (3): x86: drop mfence in favor of lock+addl x86: drop a comment left over from X86_OOSTORE x86: tweak the comment about use of wmb for IO arch/x86/include/asm/barrier.h | 10 +++------- 1 file changed...

...l. While I was at it, I found some inconsistencies in comments in arch/x86/include/asm/barrier.h I hope I'm not splitting this up too much - the reason is I wanted to isolate the code changes (that people might want to test for performance) from comment changes approved by Linus, from (so far unreviewed) comment change I came up with myself. Lightly tested on my system. Michael S. Tsirkin (3): x86: drop mfence in favor of lock+addl x86: drop a comment left over from X86_OOSTORE x86: tweak the comment about use of wmb for IO arch/x86/include/asm/barrier.h | 10 +++------- 1 file changed...

...e lightning talk. Slides: https://speakerdeck.com/asb/can-we-improve-the-experience-of-first-time-llvm-contributors Video: https://www.youtube.com/watch?v=32fmbEI9WrM # The problem As a first-time contributor, it's easy to be put off during the patch submission process. e.g. the patch may sit unreviewed for weeks. Typically people new to the project haven't yet reviewed 'review currency', and so their patches are less likely to be picked out by others scanning through llvm-commits. Obviously nobody is doing anything wrong here, it's just likely to be off-putting to newcomers. Eve...

...s deferred until we hear back from intel, which makes sense of course. So it needs HPA's ack. I hope I'm not splitting this up too much - the reason is I wanted to isolate the code changes (that people might want to test for performance) from comment changes approved by Linus, from (so far unreviewed) changes I came up with myself. Changes from v2: add patch adding cc clobber for addl tweak commit log for patch 2 use addl at SP-4 (as opposed to SP) to reduce data dependencies Michael S. Tsirkin (4): x86: add cc clobber for addl x86: drop a comment left over from X86_OOSTORE x86: tw...

...s deferred until we hear back from intel, which makes sense of course. So it needs HPA's ack. I hope I'm not splitting this up too much - the reason is I wanted to isolate the code changes (that people might want to test for performance) from comment changes approved by Linus, from (so far unreviewed) changes I came up with myself. Changes from v2: add patch adding cc clobber for addl tweak commit log for patch 2 use addl at SP-4 (as opposed to SP) to reduce data dependencies Michael S. Tsirkin (4): x86: add cc clobber for addl x86: drop a comment left over from X86_OOSTORE x86: tw...

...r 2016 at 07:59, Piotr Padlewski via llvm-dev <llvm-dev at lists.llvm.org> wrote: > This is exactly why we should switch to github. It is much easier for new > contributors to start with small fixes. There are two really quite separate issues here: 1) Patches, even trivial ones can sit unreviewed for long periods of time leading to a negative first time contribution experience. 2) Arguably, Phabricator provides a confusing interface for first-time or irregular users. There are efforts to improve this https://secure.phabricator.com/T5000 As for 1), this is something a few of us discussed...

...found some inconsistencies in comments in > arch/x86/include/asm/barrier.h > > I hope I'm not splitting this up too much - the reason is I wanted to isolate > the code changes (that people might want to test for performance) from comment > changes approved by Linus, from (so far unreviewed) comment change I came up > with myself. > > Lightly tested on my system. > > Michael S. Tsirkin (3): > x86: drop mfence in favor of lock+addl > x86: drop a comment left over from X86_OOSTORE > x86: tweak the comment about use of wmb for IO > I would like to g...

...back from > intel, which makes sense of course. So it needs HPA's ack. > > I hope I'm not splitting this up too much - the reason is I wanted to isolate > the code changes (that people might want to test for performance) > from comment changes approved by Linus, from (so far unreviewed) changes > I came up with myself. > > Changes from v2: > add patch adding cc clobber for addl > tweak commit log for patch 2 > use addl at SP-4 (as opposed to SP) to reduce data dependencies > > Michael S. Tsirkin (4): > x86: add cc clobber for addl > x86: d...

...ude/asm/barrier.h > > > > > > > > I hope I'm not splitting this up too much - the reason is I wanted to isolate > > > > the code changes (that people might want to test for performance) from comment > > > > changes approved by Linus, from (so far unreviewed) comment change I came up > > > > with myself. > > > > > > > > Lightly tested on my system. > > > > > > > > Michael S. Tsirkin (3): > > > > x86: drop mfence in favor of lock+addl > > > > x86: drop a comment...

...polated code (unless you're really >>> lucky with the rate), the cost shouldn't be too high. BTW, do you know >>> how often the rate gets updated? >> >> The rate is, by default, updated every 10 seconds. And sometimes >> (especially with the not-so-recent unreviewed patches) we do get lucky > > Which patches are you referring to? "Make module-loopback honor requested latency (v5)" by Georg Chini http://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023272.html It appears that v6 was only sent to me privately, and I don'...

...868 - $240 retail Aastra 480i CT - $280 retail The problem is that I have little to no reviews on these phones. The Aastra 480i is listed in the voip-info.org wiki as having many problems in the past that are worked around with firmware upgrades and gain configuration. The Uniden is virtually unreviewed. The only review I found said that the sound quality was excellent, that is all. The Uniden has a 5.8GHz DSS cordless phone. The Aastra has a 2.4GHz FHSS. We have interst in not interfering with 802.11b or 802.11g. However, the FHSS should be better than the 5.8DSS (which uses 2.4GHz to go...

...Type: defect | Status: new > Priority: normal | Milestone: misspiggy > Component: library | Version: 0.23.2 > Severity: normal | Resolution: > Keywords: mount | Stage: Unreviewed > Approval: Unnecessary | Patch: None > Complexity: Unknown | Compatibility: Unknown > Specification: Unnecessary | > -----------------------------+---------------------------------------------- > Changes (by luke): > > * version:...

Yet another collection of fixes from master. There will likely be at least one more 1.19.x release in 2018 as there are still a number of unreviewed patches pending. Until then, happy new year. Adam Jackson (10): xfixes: Remove the CursorCurrent array glx: Fix typos that break GLX_ARB_context_flush_control glx: Only flush indirect contexts in MakeCurrent (v2) glx: Fix glXQueryContext for GLX_FBCONFIG_ID and GLX_RENDER...

...'m getting swamped with incoming problems and tickets and I still need help triaging the tickets. James Turnbull has volunteered to help some, but I think we need more than one person. We''ve had a few people step in once or twice, but I''d like to be able to depend on Unreviewed tickets getting handled by someone else, rather than having it sitting over my head constantly. Ticket triage is basically the process of making sure a ticket is valid (usually means reproducing the problem, and if code is attached making sure that it does what it''s supposed to)....

...bad english and a little offtopic message > > > > Since you say "offtopic", I assume you intended this for the freebsd-isp list, instead of private mail. I've taken the liberty of including the list in the Cc again, since security advice like this shouldn't go unreviewed. :) You might also want to move this thread to freebsd-security@freebsd.org, to reach people with more security know-how. > I am sorry for my mistake, I really intended this for freebsd-isp list and I'll send it to freebsd-security too. Thank you for your opinion. > >> P...

...s in comments in > > arch/x86/include/asm/barrier.h > > > > I hope I'm not splitting this up too much - the reason is I wanted to isolate > > the code changes (that people might want to test for performance) from comment > > changes approved by Linus, from (so far unreviewed) comment change I came up > > with myself. > > > > Lightly tested on my system. > > > > Michael S. Tsirkin (3): > > x86: drop mfence in favor of lock+addl > > x86: drop a comment left over from X86_OOSTORE > > x86: tweak the comment about us...

...s in comments in > > arch/x86/include/asm/barrier.h > > > > I hope I'm not splitting this up too much - the reason is I wanted to isolate > > the code changes (that people might want to test for performance) from comment > > changes approved by Linus, from (so far unreviewed) comment change I came up > > with myself. > > > > Lightly tested on my system. > > > > Michael S. Tsirkin (3): > > x86: drop mfence in favor of lock+addl > > x86: drop a comment left over from X86_OOSTORE > > x86: tweak the comment about us...

...s will step up and help to get them merged. I'll be reporting back each week on any activity generated on these patches, as well as sharing a new batch. If you want your patch included you must submit it via the linked form. Now new submissions this week, but last week's submission remains unreviewed. This is understandable, as most devs have been on holiday, so I'm re-advertising: * "Syndicate common code between CallInst and InvokeInst in a shared template base class. No functional change expected, but much less redundant code to support.". [D40727](https://reviews.llvm.org/D...