search for: unchanged_attr

https://bugzilla.samba.org/show_bug.cgi?id=8268 Summary: Wrong unchanged_attrs test for symlink ownership Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: core AssignedTo: wayned at samba.org ReportedBy: matt at matt...

https://bugzilla.samba.org/show_bug.cgi?id=7622 Summary: Factor out common logic from itemize and unchanged_attrs functions Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: matt...

I noticed that rsync is happy to hard-link a device node from a --link-dest dir even if its mtime differs from that of the source device node and --times is given. Is this behavior expected? It seems to break the rule that a difference in preserved attributes disqualifies a hard link. To see the behavior, run the following as root: mkdir src dest basis mknod src/null c 1 3 sleep 1 mknod

...But all the testing I'm doing is for my particular situation: using --link-dest. The point is to create backup snapshots using --link-dest which properly preserve/backup ACL changes. What else - besides --link-dest use - should I do to test this patch before I post it? The main change is in unchanged_attrs(), where this now can detect ACL changes. Thanks... Andrew

...r consistency with "o" and "g" itemization, rsync should not itemize differences from a basis file unless they are significant in light of the options. Thus, at least when "sxp" represents an alternate basis file, "itemize" should use the same logic as "unchanged_attrs" to decide whether to itemize "p". A second issue: the logic in "unchanged_attrs" needs to be extended so that an executability difference disqualifies hard links when -E is on. Matt

...e right place. */ - set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT); + if (inplace) { + if (verbose > 2) + rprintf(FINFO, "possibly tweaking attributes of %s\n", fname); + set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT); + } else if (!unchanged_attrs(fname, file, &sx)) { + if (verbose > 2) + rprintf(FINFO, "recreating %s due to changed attributes\n", fname); + goto recreate_symlink; + } if (itemizing) itemize(fname, file, ndx, 0, &sx, 0, 0, NULL); #if defined SUPPORT_HARD_LINKS && define...

...el = 1; - /* FALL THROUGH */ - case 1: - if (!unchanged_file(cmpbuf, file, &sxp->st)) - continue; + } + if (!unchanged_file(cmpbuf, file, &sxp->st)) + continue; + if (match_level < 2) { best_match = j; match_level = 2; - /* FALL THROUGH */ - case 2: - if (!unchanged_attrs(cmpbuf, file, sxp)) { - free_stat_x(sxp); - continue; - } - best_match = j; - match_level = 3; - break; } + if (!unchanged_attrs(cmpbuf, file, sxp)) { + free_stat_x(sxp); + continue; + } + best_match = j; + match_level = 3; break; } while (basis_dir[++j] != NULL);

https://bugzilla.samba.org/show_bug.cgi?id=5644 Summary: Option to recheck basis dirs for existing dest files Product: rsync Version: 3.1.0 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: core AssignedTo: wayned@samba.org ReportedBy:

...trs': rsync.c:378: warning: unused parameter `fnamecmp' gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c generator.c -o generator.o generator.c: In function `delete_item': generator.c:216: warning: `desc' might be used uninitialized in this function generator.c: In function `unchanged_attrs': generator.c:622: warning: unused parameter `fname' generator.c: In function `itemize': generator.c:665: warning: unused parameter `fnamecmp' generator.c: In function `try_dests_non': generator.c:1112: warning: `type' might be used uninitialized in this function gcc -I. -I...

Similar to --omit-{dir,link}-times: --omit-device-times omit device files from --times --omit-special-times omit sockets and fifos from --times Also, fix corner case that allows --omit-dir-times to be ignored. See unchanged_attrs() and recv_generator()'s call to try_dests_non(). Marc. diff -aNpRruz -X /etc/diff.excludes rsync-3.2.7/generator.c devel-3.2.7/generator.c --- rsync-3.2.7/generator.c 2022-09-15 11:12:02.000000000 -0600 +++ devel-3.2.7/generator.c 2022-09-15 11:12:02.000000000 -0600 @@ -47,6 +47,8 @@ extern...

https://bugzilla.samba.org/show_bug.cgi?id=7618 Summary: symlinks and --link-dest Product: rsync Version: 3.0.7 Platform: Other OS/Version: Linux Status: NEW Severity: normal Priority: P3 Component: core AssignedTo: wayned at samba.org ReportedBy: the_majkl at seznam.cz QAContact:

...ttmccutchen.net 2007-11-04 14:51 CST ------- Created an attachment (id=2960) --> (https://bugzilla.samba.org/attachment.cgi?id=2960&action=view) Implementation of --tweak options Here, finally, is an implementation of the --tweak options! Now that bug 5051 and the omission of mtimes from unchanged_attrs have been fixed, the implementation is pretty simple; Wayne, perhaps you guessed from the comment change I inadvertently left in my patch for bug 5051 that this was what I was up to. The options seem to work and itemize properly, and there is even a test case. The clever interaction between --no...

...er (e.g. if it has no read permission). - Fix the directory permissions on an implied dot-dir when using --relative (e.g. /outside/path/././send/path). - Fixed some too-long sleeping instances when using --bwlimit. - Fixed when symlink ownership difference-checking gets compiled into unchanged_attrs(). - Improved the socket-error reporting when multiple protocols fail. - Fixed a case where a socket error could reference just-freed memory. - Failing to use a password file that was specified on the command-line is now a fatal error. - Fix the non-root updating of directories that don...

...er (e.g. if it has no read permission). - Fix the directory permissions on an implied dot-dir when using --relative (e.g. /outside/path/././send/path). - Fixed some too-long sleeping instances when using --bwlimit. - Fixed when symlink ownership difference-checking gets compiled into unchanged_attrs(). - Improved the socket-error reporting when multiple protocols fail. - Fixed a case where a socket error could reference just-freed memory. - Failing to use a password file that was specified on the command-line is now a fatal error. - Fix the non-root updating of directories that don...

https://bugzilla.samba.org/show_bug.cgi?id=12036 Bug ID: 12036 Summary: Multiple --link-dest, --copy-dest, or --compare-dest flags produce incorrect behavior Product: rsync Version: 3.1.2 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 Component:

...rsion of rsync which links a file from the link-dest directory rather copying from source when a file is identical in the source and link-dest directory, but exists and is different in the destination.) I was not aware of the issue in the case where the unchanged_file() test is passed, but not the unchanged_attrs() test, and the potential for over-writing the attributes in not just the destination, but for all hard-linked files. This means that recycling directories, which as Teodor Milkov noted: > "Such a behaviour (unlink changed files and then hard link to dest dir) > would be very handy,...

...' might be used uninitialized in this function rsync.c: In function `set_file_attrs': rsync.c:343: warning: unused parameter `fnamecmp' generator.c: In function `delete_item': generator.c:212: warning: `desc' might be used uninitialized in this function generator.c: In function `unchanged_attrs': generator.c:555: warning: unused parameter `fname' generator.c: In function `itemize': generator.c:597: warning: unused parameter `fnamecmp' generator.c: In function `try_dests_non': generator.c:1021: warning: `type' might be used uninitialized in this function sender.c:...

...file and attrs # from the source, but could copy the file in the destination # and update attrs, and remove the old file else # current behaviour update just the attributes endif endif Or, in the terms used in previous posts: if ( destination unchanged_file() is true and unchanged_attrs() is false) .... The test on the link-count is done, since teh new behaviour is needed only when the target file has a link-count greater than 1. Regards Rob. Bell e-mail: Robert.Bell at csiro.au -- Dr Robert C. Bell, BSc (Hons) PhD Technical Services Manager Advanced Scientific C...

...d_attrs': rsync.c:215: warning: `flist' might be used uninitialized in this function rsync.c: In function `set_file_attrs': rsync.c:341: warning: unused parameter `fnamecmp' gcc -I. -I. -g -O2 -DHAVE_CONFIG_H -Wall -W -I./popt -c generator.c -o generator.o generator.c: In function `unchanged_attrs': generator.c:518: warning: unused parameter `fname' generator.c: In function `itemize': generator.c:549: warning: unused parameter `fnamecmp' generator.c: In function `try_dests_non': generator.c:943: warning: `type' might be used uninitialized in this function gcc -I. -I....