rsync - Aug 2006 - Patch to handle ACL differences

A while ago (2.6.2), I built and posted a patch which caused rsync to "do
the right thing" where --link-dest was being used and where files had been
changed only in their ACLs.  I've recreated this for 2.6.8 (there were
some small differences).

I've tested this using --link-dest copying from Linux-Linux and
Linux-Solaris.  I plan to test Solaris-Solaris too, of course.  

But all the testing I'm doing is for my particular situation: using
--link-dest.  The point is to create backup snapshots using --link-dest
which properly preserve/backup ACL changes.

What else - besides --link-dest use - should I do to test this patch
before I post it?

The main change is in unchanged_attrs(), where this now can detect ACL
changes.

Thanks...

	Andrew

On Thu, Aug 03, 2006 at 02:17:33PM -0400, Andrew Gideon
wrote:
> A while ago (2.6.2), I built and posted a patch which caused rsync to
"do
> the right thing" where --link-dest was being used and where files had
been
> changed only in their ACLs.  I've recreated this for 2.6.8 (there were
> some small differences).
Did you check the ACL patch in CVS?  (Also available via the "nightly"
tar files.)  I think it already has this fixed (I know that
unchanged_attrs() was extended to check for ACL changes when preserving
ACLs).
> What else - besides --link-dest use - should I do to test this patch
> before I post it?
That's the main user of unchanged_attrs(), so if it works well with
that, you've probably got a good patch.

..wayne..