search for: stylistically

What are people''s opinions on which of these two styles is better to use? 1) before --------------------------- module UserSpecHelper include GenericSpecHelper def valid_sms_attributes(phone_number="12345") { :phone_number => phone_number } end end describe User, "with phone number" do include UserSpecHelper before(:each) do @user =

On 02/06/15 17:10, Richard W.M. Jones wrote: Hello, > On Fri, May 29, 2015 at 12:24:58PM +0300, Nikos Skalkotos wrote: >> + if (collect_coreos_inspection_info (g)) { >> + guestfs_int_free_inspect_info (g); >> + return NULL; >> + } > Although this is stylistic, I think it's easier to understand if > you change the if condition to: > > if

Hello, Here are a couple of small fixes for the virtio_console code, it's mostly stylistic fixes. Michael, can you push these to Linus? Thanks. Amit Shah (2): virtio: console: Fix type of 'len' as unsigned int virtio: console: Use better variable names for fill_queue operation drivers/char/virtio_console.c | 29 ++++++++++++++++------------- 1 files changed, 16

Hello, Here are a couple of small fixes for the virtio_console code, it's mostly stylistic fixes. Michael, can you push these to Linus? Thanks. Amit Shah (2): virtio: console: Fix type of 'len' as unsigned int virtio: console: Use better variable names for fill_queue operation drivers/char/virtio_console.c | 29 ++++++++++++++++------------- 1 files changed, 16

Another point of disparity between how I see others write Puppet manifests and the Best Practice that I''ve adopted at my institution is the use of quoting. In Puppet, you can get away with not quoting values or references if there isn''t a special character or a keyword being used (e.g. package { openssh: ...} or User[agirl]). However, even though that is possible, to make

On Thu, Oct 01, 2015 at 06:04:03PM +0300, Roman Kagan wrote: > On Mon, Aug 10, 2015 at 06:55:28PM +0300, Roman Kagan wrote: > > Libguestfs supports passing an ISO image as a source of virtio windows > > drivers to v2v. > > > > That support, however, looks too heavy-weight: in order to access those > > drivers, a separate guestfs handle is created (and thus a new

On 11/14/2011 02:45 PM, Marcello Maggioni wrote: > 2011/11/14 Tobias Grosser<tobias at grosser.es>: >> On 11/14/2011 01:24 AM, Marcello Maggioni wrote: >>> >>> Hi Tobias. >>> >>> I worked on enabling Polly accepting non affine memory accesses and I >>> produced a patch. >> >> Great. >> >>> I saw that there were

Hi Arnold, This is a very good first step! Thanks! Comments below. Evan Index: test/CodeGen/X86/constant-pool-remat-0.ll =================================================================== --- test/CodeGen/X86/constant-pool-remat-0.ll (revision 42247) +++ test/CodeGen/X86/constant-pool-remat-0.ll (working copy) @@ -1,8 +1,10 @@ ; RUN: llvm-as < %s | llc -march=x86-64 | grep LCPI | count 3 ;

2011/11/14 Tobias Grosser <tobias at grosser.es>: > On 11/14/2011 02:45 PM, Marcello Maggioni wrote: >> >> 2011/11/14 Tobias Grosser<tobias at grosser.es>: >>> >>> On 11/14/2011 01:24 AM, Marcello Maggioni wrote: >>>> >>>> Hi Tobias. >>>> >>>> I worked on enabling Polly accepting non affine memory accesses

The patch is against revision 42247. -------------- next part -------------- A non-text attachment was scrubbed... Name: tailcall-src.patch Type: application/octet-stream Size: 62639 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20070923/4770302f/attachment.obj>

Hi, I've got a browsing problem, I'm searching the error for a long time now so I think betimes it's a bug ;-) For debugging purposes, I've left away everything in the network that's not necessary. There's now only one XP-Prof workstation (domain member) and one samba server (3.0.22, acting as PDC) anymore. Bind9 is the local DNS server; Forward and PTR entries are

Here is a small doc patch based on answers from the list and from the links mentioned. For stylistic consistency I've followed the language in the va_arg description for the analogous situation. Dustin -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: LangRef.unwind.patch URL:

Just stylistic change, no functional change. --- dib/dib.ml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dib/dib.ml b/dib/dib.ml index 06a1f67..35ae6b7 100644 --- a/dib/dib.ml +++ b/dib/dib.ml @@ -781,9 +781,8 @@ let main () = ) @ mkfs_options @ [ "-t"; cmdline.fs_type; blockdev ] in ignore (g#debug "sh" (Array.of_list ([ "mkfs" ]

I made some stylistic changes to the first two patches so they match existing code, and I pushed them, along with your third patch unmodified. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful

How would one go about setting up the wakeup feature of Asterisk to NOT call an extension, but to call a phone number? My setup works great for wakeup on local extensions, but I'd like to set it up to call external phone numbers automatically and play a specific sound file (to remind people of upcoming hair stylist appointments). I suppose either there'd have to be a web interface to

Here's a list of cosmetic changes I'd be willing to make to the code in order to make it more consistent, which stylisticly it currently is not. - separate function definitions by 2 newlines - put spaces after commas in arg lists - put spaces around assignments - remove trailing spaces - change space indents to tabs - fix multiline comments - remove redundant /* dw */ comments (Deborah

Adds external weak symbols of constant pool to ExtWeakSymbols set. Lauro -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/1aaa0c7b/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 1021 bytes Desc: not available

Hi Lauro, Just a stylistic remark; In your "llvm.patch" file, there are tabs in these lines: + if (GV->hasExternalWeakLinkage()) { + ExtWeakSymbols.insert(GV); + } Others will need to review the patch for correctness, though. -bw On 12/20/06, Lauro Ramos Venancio <lauro.venancio at gmail.com> wrote: > Adds external weak symbols of constant pool to ExtWeakSymbols set.

without tabs Lauro 2006/12/20, Bill Wendling <isanbard at gmail.com>: > > Hi Lauro, > > Just a stylistic remark; In your "llvm.patch" file, there are tabs in > these lines: > > + if (GV->hasExternalWeakLinkage()) { > + ExtWeakSymbols.insert(GV); > + } > > Others will need to review the patch for correctness, though. >

On Mon, Jul 7, 2008 at 11:10 AM, Rajika Kumarasiri <rajikacc at gmail.com> wrote: > hello everybody, > > I have added few improvements to my patch. Please review the new patch > directly. > Thanks! > Hi Rajika, A few stylistic comments. I'll let others comment on the algorithm for now: if ($VERBOSE) { print "( time -p $SVNCMD/llvm/trunk llvm; cd