Linux Virtualization - Mar 2010 - [PATCH 0/2] virtio: console: Trivial fixes based on review comments

Hello,

Here are a couple of small fixes for the virtio_console code, it's mostly
stylistic fixes.

Michael, can you push these to Linus? Thanks.

Amit Shah (2):
  virtio: console: Fix type of 'len' as unsigned int
  virtio: console: Use better variable names for fill_queue operation

 drivers/char/virtio_console.c |   29 ++++++++++++++++-------------
 1 files changed, 16 insertions(+), 13 deletions(-)

We declare 'len' as int type but it should be 'unsigned int', as
get_buf() wants it to be.

Signed-off-by: Amit Shah <amit.shah at redhat.com>
Reported-by: Juan Quintela <quintela at redhat.com>
---
 drivers/char/virtio_console.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c
index 213373b..2bd6a9c 100644
--- a/drivers/char/virtio_console.c
+++ b/drivers/char/virtio_console.c
@@ -379,7 +379,7 @@ static ssize_t send_control_msg(struct port *port, unsigned
int event,
 	struct scatterlist sg[1];
 	struct virtio_console_control cpkt;
 	struct virtqueue *vq;
-	int len;
+	unsigned int len;
 
 	if (!use_multiport(port->portdev))
 		return 0;
-- 
1.6.2.5

Amit Shah <amit.shah at redhat.com> wrote:
> Hello,
>
> Here are a couple of small fixes for the virtio_console code, it's
mostly
> stylistic fixes.
>
> Michael, can you push these to Linus? Thanks.
>
> Amit Shah (2):
>   virtio: console: Fix type of 'len' as unsigned int
>   virtio: console: Use better variable names for fill_queue operation
>
>  drivers/char/virtio_console.c |   29 ++++++++++++++++-------------
>  1 files changed, 16 insertions(+), 13 deletions(-)
Acked-by: Juan Quintela <quintela at redhat.com>

On Mon, Mar 08, 2010 at 02:16:58PM +0530, Amit Shah
wrote:
> Hello,
> 
> Here are a couple of small fixes for the virtio_console code, it's
mostly
> stylistic fixes.
> 
> Michael, can you push these to Linus? Thanks.
We are in fixes only mode now. Does the first patch fix a bug,
or is it cosmetic only?
> Amit Shah (2):
>   virtio: console: Fix type of 'len' as unsigned int
>   virtio: console: Use better variable names for fill_queue operation
> 
>  drivers/char/virtio_console.c |   29 ++++++++++++++++-------------
>  1 files changed, 16 insertions(+), 13 deletions(-)