Lauro Ramos Venancio
2006-Dec-20 13:14 UTC
[LLVMdev] [patch] arm: external weak in constant pool
Adds external weak symbols of constant pool to ExtWeakSymbols set. Lauro -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/1aaa0c7b/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 1021 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/1aaa0c7b/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: weakConstantPool.ll Type: application/octet-stream Size: 298 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/1aaa0c7b/attachment.obj>
Hi Lauro,
Just a stylistic remark; In your "llvm.patch" file, there are tabs in
these lines:
+ if (GV->hasExternalWeakLinkage()) {
+ ExtWeakSymbols.insert(GV);
+ }
Others will need to review the patch for correctness, though.
-bw
On 12/20/06, Lauro Ramos Venancio <lauro.venancio at gmail.com>
wrote:> Adds external weak symbols of constant pool to ExtWeakSymbols set.
>
>
> Lauro
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
>
>
Lauro Ramos Venancio
2006-Dec-20 22:15 UTC
[LLVMdev] [patch] arm: external weak in constant pool
without tabs Lauro 2006/12/20, Bill Wendling <isanbard at gmail.com>:> > Hi Lauro, > > Just a stylistic remark; In your "llvm.patch" file, there are tabs in > these lines: > > + if (GV->hasExternalWeakLinkage()) { > + ExtWeakSymbols.insert(GV); > + } > > Others will need to review the patch for correctness, though. > > -bw > > On 12/20/06, Lauro Ramos Venancio <lauro.venancio at gmail.com> wrote: > > Adds external weak symbols of constant pool to ExtWeakSymbols set. > > > > > > Lauro > > > > _______________________________________________ > > LLVM Developers mailing list > > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > > > > > > > > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/c6331437/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: llvm.patch Type: text/x-patch Size: 1047 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20061220/c6331437/attachment.bin>