search for: stat_x

...its scope is only this definition or declaration, which is probably not what you want [enabled by default] gpfs.c:130:6: error: conflicting types for ?gpfs_free_attr? proto.h:111:6: note: previous declaration of ?gpfs_free_attr? was here gpfs.c: In function ?gpfs_free_sxp?: gpfs.c:142:10: error: ?stat_x? has no member named ?gpfs_attr? gpfs.c:144:20: error: ?stat_x? has no member named ?gpfs_attr? gpfs.c:145:10: error: ?stat_x? has no member named ?gpfs_attr? gpfs.c:146:5: error: ?stat_x? has no member named ?gpfs_attr? gpfs.c: In function ?gpfs_free_list?: gpfs.c:162:3: warning: implicit declarat...

Dear All, I have been seeing some strange behavior using rsync 3.1.1 on OSX with the 3 standard patches applied when using the --backup and --backup-Dir options. This works as expected on 3.0.9, moving any files on dest that are not on source to the backup folder. If no changes then the backup folder is not even created. -aHAXN --fileflags --force-change --protect-decmpfs ?delete --backup

...would return the call from rsync instead of making screwy directories. This is my diff, assuming one runs fileflags, crtimes, and hfs_compression diffs first for OSX and rsync 3.1.1. Rob diff --git a/backup.c b/backup.c --- a/backup.c +++ b/--- a/backup.c @@ -65,6 +65,9 @@ BOOL ret = True; stat_x sx; char *b, *rel = backup_dir_buf + backup_dir_len, *name = rel; + + if (x_lstat(fname, &sx.st, NULL) < 0) + return 1; for (f = fname, b = rel; *f && *f == *b; f++, b++) { if (*b == '/') @@ -215,17 +218,18 @@ stat_x sx; struct file_struct *file; int sa...

...eserve_mtimes; extern int omit_dir_times; extern int omit_link_times; +extern int omit_device_times; +extern int omit_special_times; extern int delete_mode; extern int delete_before; extern int delete_during; @@ -482,7 +484,12 @@ int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp) return 0; #endif } else { - if (preserve_mtimes && any_time_differs(sxp, file, fname)) + int keep_time = !preserve_mtimes ? 0 + : S_ISDIR(file->mode) ? !omit_dir_times + : IS_DEVICE(file->mode) ? !omit_device_times + : IS_SPECIAL(file->mode) ? !omit_sp...

...,7 @@ extern int preserve_hard_links; extern int preserve_perms; extern int preserve_xattrs; +extern int force_change; extern int basis_dir_cnt; extern int make_backups; extern int cleanup_got_literal; @@ -153,6 +157,20 @@ } #endif +#ifdef SUPPORT_FORCE_CHANGE + if (fd == -1) { + stat_x sx; + if (do_stat(file->dirname, &sx.st) < 0) + rprintf(FINFO, "Failed to stat %s!\n", full_fname(file->dirname)); + else { + if (force_change && make_mutable(file->dirname, sx.st.st_mode, sx.st.st_flags, force_change) > 0) { + fd = do_mkstemp(fnametm...

I've been getting spurious unnecessary copying of files on OSX when using the crtimes patch and the --crtimes -H options (version 3.0.4). I can reliably demonstrate it (on OSX 10.5) by doing this several times (as root): rsync -v -N -axHAX --delete-during --fileflags --force-change /usr/ bin/ /tmp/foo/ I think I've tracked it down to the hard-link processing code in

https://bugzilla.samba.org/show_bug.cgi?id=12036 Bug ID: 12036 Summary: Multiple --link-dest, --copy-dest, or --compare-dest flags produce incorrect behavior Product: rsync Version: 3.1.2 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 Component:

...ps core. The problem appears in versions 3.0.6, 3.0.7 & HEAD, it is in generator.c. There is an error path that takes a 'goto' that skips the initialization of sx struct, then the cleanup tries to free random memory with a call to free_acl(&sx). In acls.c the free is void free_acl(stat_x *sxp) { if (sxp->acc_acl) { rsync_acl_free(sxp->acc_acl); free(sxp->acc_acl); <<<<<<< uninitialized In version 3.0.6 the 'bad' goto is at line 1315: rprintf(FERROR_XFER,...

Thanks Wayne and everybody, This is a huge boost to have a modern rsync for OSX. We're all grateful. Rob D PS I did notice that we lost the bsd flags test in 3.0. It was ok in pre10.... thanks again bbouncer Verifying: basic-permissions ... ok Verifying: timestamps ... Sub-test: modification time ... ok ok Verifying: symlinks ... ok Verifying:

In debian bug #498083 (http://bugs.debian.org/498083) someone is getting segfaults reasonably consistently, however when using -vvvv it doesn't happen... Fortunately Sven was able to get a good backtrace. I can't quite see what's causing the problem; it does seem to be related to xattrs. Please see the bugs report at the url above for the details. Any help much appreciated. Paul

This is a PoC patch for NFSv4/ZFS ACLs. The objective of the patch is that rsync --acls support NFSv4/ZFS ACLs without requiring a new command line option NFSv4 ACLs can't be represented using POSIX draft ACLs, if an NFSv4 ACL is present a separate POSIX draft ACL will not be present and there are new APIs to access NFSv4 ACLs. So we need to distinguish between NFSv4 ACLs and POSIX ACLs in

...; mode_t dest_mode(mode_t flist_mode, mode_t stat_mode, int dflt_perms, int exists); +void make_mutable(const char *fname, mode_t mode, uint32 fileflags); +void undo_make_mutable(const char *fname, mode_t mode, uint32 fileflags); int set_file_attrs(const char *fname, struct file_struct *file, stat_x *sxp, const char *fnamecmp, int flags); RETSIGTYPE sig_int(UNUSED(int val)); @@ -296,6 +298,7 @@ int do_mknod(const char *pathname, mode_ int do_rmdir(const char *pathname); int do_open(const char *pathname, int flags, mode_t mode); int do_chmod(const char *path, mode_t mode); +int do_chf...

...ode, mode_t stat_mode, int dflt_perms, > int exists); > +int make_mutable(const char *fname, mode_t mode, uint32 fileflags, > uint32 iflags); > +int undo_make_mutable(const char *fname, uint32 fileflags); > int set_file_attrs(const char *fname, struct file_struct *file, > stat_x *sxp, > const char *fnamecmp, int flags); > RETSIGTYPE sig_int(UNUSED(int val)); > @@ -293,11 +295,12 @@ int sock_exec(const char *prog); > int do_unlink(const char *fname); > int do_symlink(const char *fname1, const char *fname2); > int do_link(const char *fname1, const...