rsync - Sep 2008 - Bug with crtimes and hard links?

I've been getting spurious unnecessary copying of files on OSX when  
using the crtimes patch and the --crtimes -H options (version 3.0.4).

I can reliably demonstrate it (on OSX 10.5) by doing this several  
times (as root):
rsync -v -N -axHAX --delete-during --fileflags --force-change  /usr/ 
bin/    /tmp/foo/


I think I've tracked it down to the hard-link processing code in  
recv_file_entry() in flist.c around line 751:

Essentially, all hard links but the first will get their modtime set  
correctly (from first->modtime), but their crtime is inherited  
(incorrectly) from the previous invocation of recv_file_entry.

The obvious idea would be to add a crtime field to file_struct but  
that looks like it has some large potential impact and
I'm afraid I don't know the rsync codebase sufficiently to want to  
attempt a fix.


-- Chris

On Fri, Sep 26, 2008 at 05:42:40PM -0700, Chris Roehrig
wrote:
> I've been getting spurious unnecessary copying of files on OSX when
using
> the crtimes patch and the --crtimes -H options (version 3.0.4).
This appears to be a lack of initializing the stat_x crtime value to 0 in
the hlink.c code.  Please try out the attached patch.

..wayne..
-------------- next part --------------
A non-text attachment was scrubbed...
Name: crtime.patch
Type: text/x-diff
Size: 503 bytes
Desc: not available
Url :
http://lists.samba.org/archive/rsync/attachments/20080927/4cd6b199/crtime.bin