search for: opus_arm_inline_asm

...celt/tests/test_unit_types.c diff --git a/celt/_kiss_fft_guts.h b/celt/_kiss_fft_guts.h index 5e3d58f..11a2676 100644 --- a/celt/_kiss_fft_guts.h +++ b/celt/_kiss_fft_guts.h @@ -90,11 +90,11 @@ do {(res).r = ADD32((res).r,(a).r); (res).i = SUB32((res).i,(a).i); \ }while(0) -#if defined(OPUS_ARM_INLINE_ASM) +#if defined(OPUS_ARM_INLINE_ASM) && defined(FIXED_POINT) #include "arm/kiss_fft_armv4.h" #endif -#if defined(OPUS_ARM_INLINE_EDSP) +#if defined(OPUS_ARM_INLINE_EDSP) && defined(FIXED_POINT) #include "arm/kiss_fft_armv5e.h" #endif #if defined(MIPSr1_ASM)...

Hello, I received feedback from engineers working on NE10 [1] that it would be better to use NE10 [1] for FFT optimizations for opus use cases. However, these FFT patches are currently in review and haven't been integrated into NE10 yet. While the FFT functions in NE10 are getting baked, I wanted to optimize the celt_pitch_xcorr (floating point only) and use it to introduce ARM NEON

...[ >> + OPUS_ARM_NEON_INTR=0 >> + AC_MSG_WARN([ARMv7 neon intrinsics not enabled]) >> + ]) >> + >> AS_IF([test x"$inline_optimization" = x"ARM"],[ >> AM_CONDITIONAL([OPUS_ARM_INLINE_ASM],[true]) >> AC_DEFINE([OPUS_ARM_INLINE_ASM], 1, >> @@ -220,7 +248,7 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ >> AC_DEFINE([OPUS_ARM_INLINE_EDSP], [1], >> [Use ARMv5E inline asm optimizat...

...st arm-linux-gnueabihf --disable-assertions --disable-check-asm --enable-intrinsics CFLAGS=-O3 --disable-shared When configuring with floating-point and intrinsics enabled as above, the generated config.h only has OPUS_ARM_MAY_HAVE_NEON_INTR defined (to 1), with /* #undef OPUS_ARM_ASM */ /* #undef OPUS_ARM_INLINE_ASM */ /* #undef OPUS_ARM_INLINE_EDSP */ /* #undef OPUS_ARM_INLINE_MEDIA */ /* #undef OPUS_ARM_INLINE_NEON */ /* #undef OPUS_ARM_MAY_HAVE_EDSP */ /* #undef OPUS_ARM_MAY_HAVE_MEDIA */ /* #undef OPUS_ARM_MAY_HAVE_NEON */ /* #undef OPUS_ARM_PRESUME_AARCH64_NEON_INTR */ /* #undef OPUS_ARM_PRESUME_EDSP */ /...

...han Vorbis for equivalent audio. I also must mention I am cross compiling with a different build system. I have attempted different sets of compilation defines. Latest run included the following: OPUS_ARM_ASM OPUS_ARM_MAY_HAVE_NEON OPUS_ARM_MAY_HAVE_MEDIA OPUS_ARM_INLINE_EDSP OPUS_ARM_INLINE_NEON OPUS_ARM_INLINE_ASM FIXED_POINT OPUS_BUILD HAVE_LRINT HAVE_LRINTF Thanks! Dan

...system. >>I >> have attempted different sets of compilation defines. Latest run >>included >> the following: >> >> OPUS_ARM_ASM >> OPUS_ARM_MAY_HAVE_NEON >> OPUS_ARM_MAY_HAVE_MEDIA >> OPUS_ARM_INLINE_EDSP >> OPUS_ARM_INLINE_NEON >> OPUS_ARM_INLINE_ASM >> FIXED_POINT >> OPUS_BUILD >> HAVE_LRINT >> HAVE_LRINTF >> >> Thanks! >> Dan >> >> _______________________________________________ >> opus mailing list >> opus at xiph.org >> http://lists.xiph.org/mailman/listinfo/opus >...

...hange to add additional ARM NEON support the commit in question broke the autoconf script.. checking for C99 variable-size arrays... yes checking for cos in -lm... (cached) yes /home/ports/pobj/opus-1.1/opus-1.1/configure[12816]: ${inline_optimization:0:3}": bad substitution AM_CONDITIONAL([OPUS_ARM_INLINE_ASM], [test x"${inline_optimization:0:3}" = x"ARM"]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], [test x"${asm_optimization:0:3}" = x"ARM"]) -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

...ssertions --disable-check-asm --enable-intrinsics CFLAGS=-O3 > --disable-shared > > When configuring with floating-point and intrinsics enabled as above, the > generated config.h only has OPUS_ARM_MAY_HAVE_NEON_INTR defined (to 1), > with > /* #undef OPUS_ARM_ASM */ > /* #undef OPUS_ARM_INLINE_ASM */ > /* #undef OPUS_ARM_INLINE_EDSP */ > /* #undef OPUS_ARM_INLINE_MEDIA */ > /* #undef OPUS_ARM_INLINE_NEON */ > /* #undef OPUS_ARM_MAY_HAVE_EDSP */ > /* #undef OPUS_ARM_MAY_HAVE_MEDIA */ > /* #undef OPUS_ARM_MAY_HAVE_NEON */ > /* #undef OPUS_ARM_PRESUME_AARCH64_NEON_INTR */ &...

...s])], > + [AC_MSG_RESULT([no])]) > + ], > + [ > + OPUS_ARM_NEON_INTR=0 > + AC_MSG_WARN([ARMv7 neon intrinsics not enabled]) > + ]) > + > AS_IF([test x"$inline_optimization" = x"ARM"],[ > AM_CONDITIONAL([OPUS_ARM_INLINE_ASM],[true]) > AC_DEFINE([OPUS_ARM_INLINE_ASM], 1, > @@ -220,7 +248,7 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ > AC_DEFINE([OPUS_ARM_INLINE_EDSP], [1], > [Use ARMv5E inline asm optimizations]) >...

...2 deletions(-) diff --git a/configure.ac b/configure.ac index 0ba4a80..443362f 100644 --- a/configure.ac +++ b/configure.ac @@ -333,9 +333,9 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ AM_CONDITIONAL([CPU_ARM], [test "$cpu_arm" = "yes"]) AM_CONDITIONAL([OPUS_ARM_INLINE_ASM], - [test x"${inline_optimization:0:3}" = x"ARM"]) + [test x"${inline_optimization%% *}" = x"ARM"]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], - [test x"${asm_optimization:0:3}" = x"ARM"]) + [test x"${asm_optimization%% *}&q...

...ension.) Here's a portable fix. --- configure.ac.orig Thu Dec 5 00:26:45 2013 +++ configure.ac Sun Dec 15 17:32:25 2013 @@ -333,9 +333,9 @@ AS_IF([test x"${enable_asm}" = x"yes"],[ AM_CONDITIONAL([CPU_ARM], [test "$cpu_arm" = "yes"]) AM_CONDITIONAL([OPUS_ARM_INLINE_ASM], - [test x"${inline_optimization:0:3}" = x"ARM"]) + [expr x"${inline_optimization}" : x"ARM" >/dev/null]) AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM], - [test x"${asm_optimization:0:3}" = x"ARM"]) + [expr x"${asm_optimizat...

...mention I am cross compiling with a different build system. I > have attempted different sets of compilation defines. Latest run included > the following: > > OPUS_ARM_ASM > OPUS_ARM_MAY_HAVE_NEON > OPUS_ARM_MAY_HAVE_MEDIA > OPUS_ARM_INLINE_EDSP > OPUS_ARM_INLINE_NEON > OPUS_ARM_INLINE_ASM > FIXED_POINT > OPUS_BUILD > HAVE_LRINT > HAVE_LRINTF > > Thanks! > Dan > > _______________________________________________ > opus mailing list > opus at xiph.org > http://lists.xiph.org/mailman/listinfo/opus >

...123,9 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "fixed_generic.h" -#ifdef OPUS_ARM_INLINE_EDSP +#ifdef OPUS_ARM_PRESUME_AARCH64_NEON_INTR +#include "arm/fixed_arm64.h" +#elif OPUS_ARM_INLINE_EDSP #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 0000000..075a6b3 --- /dev/null +++ b/celt/arm/fixed_arm64.h @@ -0,0 +1,35 @@ +/* Copyright (C) 2015 Vidyo */ +/* + Redistribution and use in source and binary forms, wi...

...st arm-linux-gnueabihf --disable-assertions --disable-check-asm --enable-intrinsics CFLAGS=-O3 --disable-shared When configuring with floating-point and intrinsics enabled as above, the generated config.h only has OPUS_ARM_MAY_HAVE_NEON_INTR defined (to 1), with /* #undef OPUS_ARM_ASM */ /* #undef OPUS_ARM_INLINE_ASM */ /* #undef OPUS_ARM_INLINE_EDSP */ /* #undef OPUS_ARM_INLINE_MEDIA */ /* #undef OPUS_ARM_INLINE_NEON */ /* #undef OPUS_ARM_MAY_HAVE_EDSP */ /* #undef OPUS_ARM_MAY_HAVE_MEDIA */ /* #undef OPUS_ARM_MAY_HAVE_NEON */ /* #undef OPUS_ARM_PRESUME_AARCH64_NEON_INTR */ /* #undef OPUS_ARM_PRESUME_EDSP */ /...

...st arm-linux-gnueabihf --disable-assertions --disable-check-asm --enable-intrinsics CFLAGS=-O3 --disable-shared When configuring with floating-point and intrinsics enabled as above, the generated config.h only has OPUS_ARM_MAY_HAVE_NEON_INTR defined (to 1), with /* #undef OPUS_ARM_ASM */ /* #undef OPUS_ARM_INLINE_ASM */ /* #undef OPUS_ARM_INLINE_EDSP */ /* #undef OPUS_ARM_INLINE_MEDIA */ /* #undef OPUS_ARM_INLINE_NEON */ /* #undef OPUS_ARM_MAY_HAVE_EDSP */ /* #undef OPUS_ARM_MAY_HAVE_MEDIA */ /* #undef OPUS_ARM_MAY_HAVE_NEON */ /* #undef OPUS_ARM_PRESUME_AARCH64_NEON_INTR */ /* #undef OPUS_ARM_PRESUME_EDSP */ /...

...123,9 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "fixed_generic.h" -#ifdef OPUS_ARM_INLINE_EDSP +#ifdef OPUS_ARM_PRESUME_AARCH64_NEON_INTR +#include "arm/fixed_arm64.h" +#elif OPUS_ARM_INLINE_EDSP #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 0000000..c6fbd3d --- /dev/null +++ b/celt/arm/fixed_arm64.h @@ -0,0 +1,35 @@ +/* Copyright (C) 2015 Vidyo */ +/* + Redistribution and use in source and binary forms, wi...

...ged, 78 insertions(+) create mode 100644 celt/arm/fixed_arm64.h diff --git a/celt/arch.h b/celt/arch.h index 9f74ddd..219569b 100644 --- a/celt/arch.h +++ b/celt/arch.h @@ -122,6 +122,8 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" +#elif defined (OPUS_ARM64_INLINE_ASM) +#include "arm/fixed_arm64.h" #elif defined (BFIN_ASM) #include "fixed_bfin.h" #elif defined (TI_C5X_ASM) diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 00...

...ged, 78 insertions(+) create mode 100644 celt/arm/fixed_arm64.h diff --git a/celt/arch.h b/celt/arch.h index 9f74ddd..219569b 100644 --- a/celt/arch.h +++ b/celt/arch.h @@ -122,6 +122,8 @@ static OPUS_INLINE opus_int16 SAT16(opus_int32 x) { #include "arm/fixed_armv5e.h" #elif defined (OPUS_ARM_INLINE_ASM) #include "arm/fixed_armv4.h" +#elif defined (OPUS_ARM64_INLINE_ASM) +#include "arm/fixed_arm64.h" #elif defined (BFIN_ASM) #include "fixed_bfin.h" #elif defined (TI_C5X_ASM) diff --git a/celt/arm/fixed_arm64.h b/celt/arm/fixed_arm64.h new file mode 100644 index 00...

...m --enable-intrinsics CFLAGS=-O3 >> --disable-shared >> >> When configuring with floating-point and intrinsics enabled as above, the >> generated config.h only has OPUS_ARM_MAY_HAVE_NEON_INTR defined (to 1), >> with >> /* #undef OPUS_ARM_ASM */ >> /* #undef OPUS_ARM_INLINE_ASM */ >> /* #undef OPUS_ARM_INLINE_EDSP */ >> /* #undef OPUS_ARM_INLINE_MEDIA */ >> /* #undef OPUS_ARM_INLINE_NEON */ >> /* #undef OPUS_ARM_MAY_HAVE_EDSP */ >> /* #undef OPUS_ARM_MAY_HAVE_MEDIA */ >> /* #undef OPUS_ARM_MAY_HAVE_NEON */ >> /* #undef OPUS_ARM_PR...

--- configure.ac | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/configure.ac b/configure.ac index 90a06c8..adcb969 100644 --- a/configure.ac +++ b/configure.ac @@ -503,6 +503,26 @@ AS_IF([test x"$enable_intrinsics" = x"yes"],[ [rtcd_support="$rtcd_support (NE10)"]) ]) + OPUS_CHECK_INTRINSICS( +