opus - Dec 2013 - Opus 1.1's autoconf script is broken

Hi,

Nice to see the 1.1 release is out but unfortunately due to a relatively 
late change to add additional ARM NEON support the commit
in question broke the autoconf script..

checking for C99 variable-size arrays... yes
checking for cos in -lm... (cached) yes
/home/ports/pobj/opus-1.1/opus-1.1/configure[12816]: 
${inline_optimization:0:3}": bad substitution

AM_CONDITIONAL([OPUS_ARM_INLINE_ASM],
     [test x"${inline_optimization:0:3}" = x"ARM"])
AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM],
     [test x"${asm_optimization:0:3}" = x"ARM"])

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

On Sun, Dec 8, 2013 at 5:14 AM, Brad Smith <brad at comstyle.com>
wrote:
>
> Nice to see the 1.1 release is out but unfortunately due to a relatively
> late change to add additional ARM NEON support the commit
> in question broke the autoconf script..
>
> checking for C99 variable-size arrays... yes
> checking for cos in -lm... (cached) yes
> /home/ports/pobj/opus-1.1/opus-1.1/configure[12816]:
> ${inline_optimization:0:3}": bad substitution
Yes, our autobuilders also hit that issue:

http://autobuild.buildroot.net/results/136/1360fefb79ebc7d95ef3a7459be681ac11e1ffb4/build-end.log

Looks like a bashism to me.

--

Bye, Peter Korsgaard

On 07/12/13 11:14 PM, Brad Smith wrote:
> Hi,
>
> Nice to see the 1.1 release is out but unfortunately due to a relatively
> late change to add additional ARM NEON support the commit
> in question broke the autoconf script..
>
> checking for C99 variable-size arrays... yes
> checking for cos in -lm... (cached) yes
> /home/ports/pobj/opus-1.1/opus-1.1/configure[12816]:
> ${inline_optimization:0:3}": bad substitution
>
> AM_CONDITIONAL([OPUS_ARM_INLINE_ASM],
>       [test x"${inline_optimization:0:3}" = x"ARM"])
> AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM],
>       [test x"${asm_optimization:0:3}" = x"ARM"])
Another issue.. there appears to be some GNU make-isms that
were introduced inbetween 1.0.x and 1.1.

*** Parse error in /home/ports/pobj/opus-1.1/build-amd64: Need an 
operator in 'yes' (Makefile:2756)

# Provide the full test output for failed tests when using the parallel
# test suite (which is enabled by default with automake 1.13+).
export VERBOSE = yes

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.