Christian Weisgerber
2013-Dec-15 16:47 UTC
[opus] Opus 1.1: configure uses invalid shell syntax
configure uses invalid shell syntax. (Ah, it's a bash extension.)
Here's a portable fix.
--- configure.ac.orig Thu Dec 5 00:26:45 2013
+++ configure.ac Sun Dec 15 17:32:25 2013
@@ -333,9 +333,9 @@ AS_IF([test x"${enable_asm}" = x"yes"],[
AM_CONDITIONAL([CPU_ARM], [test "$cpu_arm" = "yes"])
AM_CONDITIONAL([OPUS_ARM_INLINE_ASM],
- [test x"${inline_optimization:0:3}" = x"ARM"])
+ [expr x"${inline_optimization}" : x"ARM"
>/dev/null])
AM_CONDITIONAL([OPUS_ARM_EXTERNAL_ASM],
- [test x"${asm_optimization:0:3}" = x"ARM"])
+ [expr x"${asm_optimization}" : x"ARM" >/dev/null])
AS_IF([test x"$enable_rtcd" = x"yes"],[
AS_IF([test x"$rtcd_support" != x"no"],[
--
Christian "naddy" Weisgerber naddy at
mips.inka.de
Peter Korsgaard
2013-Dec-17 21:33 UTC
[opus] Opus 1.1: configure uses invalid shell syntax
>>>>> "Christian" == Christian Weisgerber <naddy at mips.inka.de> writes:> configure uses invalid shell syntax. (Ah, it's a bash extension.) > Here's a portable fix. Thanks, but this is already fixed in git: http://git.xiph.org/?p=opus.git;a=commit;h=253e15f7e840b8598c36779a6931d79289b7a2bc -- Bye, Peter Korsgaard
Maybe Matching Threads
- [PATCH] configure.ac: fix bashism in ARM optimization handling
- No subject
- [RFC PATCHv1] armv7: celt_pitch_xcorr: Introduce ARM neon intrinsics
- [PATCH v1] armv7: celt_pitch_xcorr: Introduce ARM neon intrinsics
- [RFC PATCH v2] armv7: celt_pitch_xcorr: Introduce ARM neon intrinsics