search for: llvm_on_win32

...anl.gov>: >> Author: chapuni >> Date: Sat Jun  2 10:34:26 2012 >> New Revision: 157890 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=157890&view=rev >> Log: >> Revert r157819, "#ifdef out a broken test on win32" >> >> FYI, LLVM_ON_WIN32 is useless. > > Can you be more specific? I thought that configure defined these (and I > assumed that the other build systems did too as appropriate). Is that > not true? LLVM_ON_WIN32 requires "config.h". In this case, it went useless lack of config.h. IMO, we can assume o...

Hi, LLVM_ON_WIN32 is true exactly when the compiler-set _WIN32 is set. I'd like to just replace LLVM_ON_WIN32 with just _WIN32 everywhere -- _WIN32 doesn't require a custom header file, and we already are inconsistent about which of the two versions we should use in the codebase. Let me know if you see any...

...gt; >> Date: Sat Jun  2 10:34:26 2012 > >> New Revision: 157890 > >> > >> URL: http://llvm.org/viewvc/llvm-project?rev=157890&view=rev > >> Log: > >> Revert r157819, "#ifdef out a broken test on win32" > >> > >> FYI, LLVM_ON_WIN32 is useless. > > > > Can you be more specific? I thought that configure defined these > > (and I assumed that the other build systems did too as > > appropriate). Is that not true? > > LLVM_ON_WIN32 requires "config.h". In this case, it went useless lack >...

...these. This allows me to build LLVM on cygwin. Sorry, I didn't mean to include this hunk: Index: CMakeLists.txt =================================================================== --- CMakeLists.txt (revision 58429) +++ CMakeLists.txt (working copy) @@ -31,8 +31,13 @@ ) if(WIN32) - set(LLVM_ON_WIN32 1) - set(LLVM_ON_UNIX 0) + if(CYGWIN) + set(LLVM_ON_WIN32 0) + set(LLVM_ON_UNIX 1) + else(CYGWIN) + set(LLVM_ON_WIN32 1) + set(LLVM_ON_UNIX 0) + endif(CYGWIN) set(LTDL_SHLIB_EXT ".dll") set(EXEEXT ".exe") # Maximum path length is 160 for non-unicode path...

> Could you please rig Makefile.rules or something to print out the value > of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if > that's erroneously false. The configure script sets LLVM_ON_UNIX, not LLVM_ON_WIN32, for Cygwin: case $host in ... *-*-cygwin*) llvm_cv_link_all_option="-Wl,--whole-archive" llvm_cv_no_link_all_option="-Wl,-...

Cygwin's <stdint.h> defines uint32_t as "unsigned long". I think this is valid, but it causes various problems like this when building LLVM with GCC 3.4.4: .../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3440: error: call of overloaded `AddInteger(uint32_t)' is ambiguous .../lib/CodeGen/SelectionDAG/SelectionDAG.cpp:1429: error: no matching function for call to `max(long

...both the relocation problem and uninstall tree problem, not fully tested just for discussion.* * * Index: LLVMConfig.cmake.in =================================================================== --- LLVMConfig.cmake.in (revision 159425) +++ LLVMConfig.cmake.in (working copy) @@ -32,8 +32,11 @@ set(LLVM_ON_WIN32 @LLVM_ON_WIN32@) set(LLVM_INSTALL_PREFIX @LLVM_INSTALL_PREFIX@) -set(LLVM_INCLUDE_DIRS ${LLVM_INSTALL_PREFIX}/include) -set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PREFIX}/lib) + +get_filename_component(LLVM_CURRENT_LIST_DIR CMAKE_CURRENT_LIST_FILE PATH) +set(LLVM_INCLUDE_DIRS ${LLVM_CURRENT_LIST_DIR}/....

> > *hi,Óscar:* > * * > >Why? Please describe a case. > > >I need to do some futher experiment and to see whether I have been > wrong. > Since I touch this problem several months ago, so I did some test using the 3.2svn, the reason why uninstalled build 'cmake not work lies in set(LLVM_INSTALL_PREFIX @LLVM_INSTALL_PREFIX@) set(LLVM_INCLUDE_DIRS

...5229 > <http://llvm.org/viewvc/llvm-project?view=rev&revision=65229> > > Cygwin is still giving "-fPIC ignored for target (all code is position > independent)" warnings :( *Really!* Could you please rig Makefile.rules or something to print out the value of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if that's erroneously false. Nick > I have tried from LLVM svn mainline. > > Sorry that I did not get round to trying it earlier. > > Aaron > > > > ------------------------------------------------------------...

On Sat, Feb 21, 2009 at 7:14 PM, Nick Lewycky <nicholas at mxc.ca> wrote: > Aaron Gray wrote: > > On Thu, Feb 19, 2009 at 6:55 PM, Nick Lewycky <nicholas at mxc.ca > > <mailto:nicholas at mxc.ca>> wrote: > > > > Aaron Gray wrote: > > > On Thu, Feb 19, 2009 at 5:52 PM, Nick Lewycky <nicholas at mxc.ca > >

>> Could you please rig Makefile.rules or something to print out the value >> of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if >> that's erroneously false. This works for me: Index: Makefile.rules =================================================================== --- Makefile.rules (revision 65633) +++ Makefile.rules (working copy) @@ -298,6 +298,8...

...ot;${prefix}/share/doc/llvm"; eval LLVM_ETCDIR="${prefix}/etc/llvm"; diff --git a/cmake/modules/LLVMConfig.cmake.in b/cmake/modules/LLVMConfig.cmake.in index 6b202b2..15ba314 100644 --- a/cmake/modules/LLVMConfig.cmake.in +++ b/cmake/modules/LLVMConfig.cmake.in @@ -31,7 +31,8 @@ set(LLVM_ON_WIN32 @LLVM_ON_WIN32@) set(LLVM_INSTALL_PREFIX @LLVM_INSTALL_PREFIX@) set(LLVM_INCLUDE_DIRS ${LLVM_INSTALL_PREFIX}/include) -set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PREFIX}/lib) +set(LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@") +set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PREFIX}/lib${LLVM_LIBDIR_SUFFI...

...uot;; > eval LLVM_ETCDIR="${prefix}/etc/llvm"; > diff --git a/cmake/modules/LLVMConfig.cmake.in b/cmake/modules/LLVMConfig.cmake.in > index 6b202b2..15ba314 100644 > --- a/cmake/modules/LLVMConfig.cmake.in > +++ b/cmake/modules/LLVMConfig.cmake.in > @@ -31,7 +31,8 @@ set(LLVM_ON_WIN32 @LLVM_ON_WIN32@) > > set(LLVM_INSTALL_PREFIX @LLVM_INSTALL_PREFIX@) > set(LLVM_INCLUDE_DIRS ${LLVM_INSTALL_PREFIX}/include) > -set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PREFIX}/lib) > +set(LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@") > +set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PRE...

...t; column support for msvc locations. I also added indentation so you can > easily see the grouping of errors, include stacks and notes (msvc mode > only). It seems it would be better functionally. But please remember Microsoft's toolchain would not be the only one. Also mingw depends on LLVM_ON_WIN32. (in llvm side). For now, I don't have better answer. > llvm-outputdebugstring-support.patch: > clang-visual-studio-debuggability.patch: > > Visual Studio has no good way of getting stdout and stderr output into its > Output Window. Getting these into the Output Window can be...

Jay Foad wrote: >>> Could you please rig Makefile.rules or something to print out the value >>> of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if >>> that's erroneously false. > > This works for me: > > Index: Makefile.rules > =================================================================== > --- Makefile.rules (revision 65633) > +++ Makefile.rule...

nobled <nobled at dreamwidth.org> writes: [snip] Please move the new code to a new file named cmake/modules/WindowsCRTControl.cmake and include it from the top level CMakeLists when LLVM_ON_WIN32.

...e > that has been posted to gmane.comp.compilers.llvm.devel as well. > > nobled <nobled at dreamwidth.org> writes: > > [snip] > > Please move the new code to a new file named > cmake/modules/WindowsCRTControl.cmake and include it from the top level > CMakeLists when LLVM_ON_WIN32. Isn't it only ever used when "if (MSVC)" though, not on WIN32 in general? (I also refactored some logic with helper macros to try and make it more readable.) -------------- next part -------------- A non-text attachment was scrubbed... Name: add-build-config-crt-selection-v9.patch...

...ll tree problem, not fully tested just for discussion.* > * > * > Index: LLVMConfig.cmake.in > =================================================================== > --- LLVMConfig.cmake.in (revision 159425) > +++ LLVMConfig.cmake.in (working copy) > @@ -32,8 +32,11 @@ > set(LLVM_ON_WIN32 @LLVM_ON_WIN32@) > > set(LLVM_INSTALL_PREFIX @LLVM_INSTALL_PREFIX@) > -set(LLVM_INCLUDE_DIRS ${LLVM_INSTALL_PREFIX}/include) > -set(LLVM_LIBRARY_DIRS ${LLVM_INSTALL_PREFIX}/lib) > + > +get_filename_component(LLVM_CURRENT_LIST_DIR CMAKE_CURRENT_LIST_FILE PATH) > +set(LLVM_INCLU...

...y. Or, at least, didn't in 2010, when someone asked about the same problem: https://cygwin.com/ml/cygwin/2010-01/msg00596.html "cygwin has only dlsym() not the SGI DL_info + dladdr() yet. clang just needs it to get the path for the CIndex dll. This should be possible with the code in the LLVM_ON_WIN32 section, and convert then the path from win to posix with cygwin_conv_path()." On Thu, Jun 30, 2016 at 11:16 AM, Martin J. O'Riordan via llvm-dev < llvm-dev at lists.llvm.org> wrote: > I am updating our out-of-tree copy of LLVM to track the head (revision > #272991 specific...

Óscar Fuentes <ofv at wanadoo.es> wrote: > I'm a bit wary about this patch. So much complexity for so petty > feature... Maybe the right thing is to determine the scenarios where > people set LLVM_USE_CRT. Maybe all we need is to define another build > type that inherits from Release which uses the debug version of the CRT. > > Anyways, the patch have some issues: