Nico Weber via llvm-dev
2018-Apr-02 18:30 UTC
[llvm-dev] Replacing LLVM_ON_WIN32 with just _WIN32
Hi, LLVM_ON_WIN32 is true exactly when the compiler-set _WIN32 is set. I'd like to just replace LLVM_ON_WIN32 with just _WIN32 everywhere -- _WIN32 doesn't require a custom header file, and we already are inconsistent about which of the two versions we should use in the codebase. Let me know if you see any problems with this plan, else I'll do the switch in a week or so. Nico -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180402/f44c2189/attachment.html>
Nico Weber via llvm-dev
2018-Apr-30 20:42 UTC
[llvm-dev] Replacing LLVM_ON_WIN32 with just _WIN32
This is completed as of http://llvm.org/viewvc/llvm-project?view=revision&revision=331224 On Mon, Apr 2, 2018 at 2:30 PM, Nico Weber <thakis at chromium.org> wrote:> Hi, > > LLVM_ON_WIN32 is true exactly when the compiler-set _WIN32 is set. I'd > like to just replace LLVM_ON_WIN32 with just _WIN32 everywhere -- _WIN32 > doesn't require a custom header file, and we already are inconsistent about > which of the two versions we should use in the codebase. > > Let me know if you see any problems with this plan, else I'll do the > switch in a week or so. > > Nico >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20180430/94ee1e9d/attachment.html>
Seemingly Similar Threads
- [LLVMdev] [cfe-commits] r157890 - /cfe/trunk/unittests/Tooling/ToolingTest.cpp
- [LLVMdev] [cfe-commits] r157890 - /cfe/trunk/unittests/Tooling/ToolingTest.cpp
- [LLVMdev] cygwin build problems
- [LLVMdev] -fPIC warning on every compile on Cygwin
- [LLVMdev] [cfe-dev] is configure+make dead yet?