llvm dev - Feb 2009 - [LLVMdev] -fPIC warning on every compile on Cygwin

> Could you please rig Makefile.rules or something to print out the value
> of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if
> that's erroneously false.
The configure script sets LLVM_ON_UNIX, not LLVM_ON_WIN32, for Cygwin:

  case $host in
  ...
  *-*-cygwin*)
    llvm_cv_link_all_option="-Wl,--whole-archive"
    llvm_cv_no_link_all_option="-Wl,--no-whole-archive"
    llvm_cv_os_type="Cygwin"
    llvm_cv_platform_type="Unix" ;;


case $llvm_cv_platform_type in
  Unix)

cat >>confdefs.h <<\_ACEOF
#define LLVM_ON_UNIX 1
_ACEOF

    LLVM_ON_UNIX=1

    LLVM_ON_WIN32=0

    ;;


Jay.

>> Could you please rig Makefile.rules or something to print out the value
>> of $(LLVM_ON_WIN32) ? The only way I can think of this happening is if
>> that's erroneously false.
This works for me:

Index: Makefile.rules
==================================================================---
Makefile.rules      (revision 65633)
+++ Makefile.rules      (working copy)
@@ -298,6 +298,8 @@
       # Common symbols not allowed in dylib files
       CXX.Flags += -fno-common
       C.Flags   += -fno-common
+    else ifeq ($(OS),Cygwin)
+      # Nothing. Cygwin defaults to PIC and warns when given -fPIC
     else
       # Linux and others; pass -fPIC
       CXX.Flags += -fPIC

Jay.

On Fri, Feb 27, 2009 at 4:32 PM, Jay Foad <jay.foad at gmail.com> wrote:
> >> Could you please rig Makefile.rules or something to print out the
value
> >> of $(LLVM_ON_WIN32) ? The only way I can think of this happening
is if
> >> that's erroneously false.
>
> This works for me:
>
> Index: Makefile.rules
> ==================================================================> ---
Makefile.rules      (revision 65633)
> +++ Makefile.rules      (working copy)
> @@ -298,6 +298,8 @@
>       # Common symbols not allowed in dylib files
>       CXX.Flags += -fno-common
>       C.Flags   += -fno-common
> +    else ifeq ($(OS),Cygwin)
> +      # Nothing. Cygwin defaults to PIC and warns when given -fPIC
>     else
>       # Linux and others; pass -fPIC
>       CXX.Flags += -fPIC

Jay, thanks I will try this.

Does it also deal with the lib/Transforms/Hello build failure ?

Many thanks,

Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20090227/60cda8a2/attachment.html>

Jay Foad wrote:
>>> Could you please rig Makefile.rules or something to print out the
value
>>> of $(LLVM_ON_WIN32) ? The only way I can think of this happening is
if
>>> that's erroneously false.
> 
> This works for me:
> 
> Index: Makefile.rules
> ==================================================================> ---
Makefile.rules      (revision 65633)
> +++ Makefile.rules      (working copy)
> @@ -298,6 +298,8 @@
>        # Common symbols not allowed in dylib files
>        CXX.Flags += -fno-common
>        C.Flags   += -fno-common
> +    else ifeq ($(OS),Cygwin)
> +      # Nothing. Cygwin defaults to PIC and warns when given -fPIC
>      else
>        # Linux and others; pass -fPIC
>        CXX.Flags += -fPIC
Okay. Could someone also test MinGW? Does its gcc emit a warning when 
passed -fPIC?

Nick
> Jay.
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>