On 30/07/24 9:00 pm, Michael Tokarev via samba wrote:> I'm trying to build 4.21-rc packages for debian, and noticed > that a new form of version info symbol appeared (only tried > tdb for now).? In addition to usual > > ?TDB.1.4.11 at TDB.1_4.11 > > symbol, it now also adds > > ?TDB_1_4_11 at TDB_1_4_11 > > (with dots replaced with underscores), but for single version > only. > > It doesn't look right :) > > Thanks, > > /mjt >I suspect this is related to commit 0bc5b6f29307ce758774c1b2f48ce62315fdc7f9 (and https://bugzilla.samba.org/show_bug.cgi?id=15673). But I couldn?t say whether the new symbol is correct or not. Cheers, Jo (she/her)
On 31/07/24 17:07, Jo Sutton wrote:> On 30/07/24 9:00 pm, Michael Tokarev via samba wrote: >> I'm trying to build 4.21-rc packages for debian, and noticed >> that a new form of version info symbol appeared (only tried >> tdb for now).? In addition to usual >> >> ??TDB.1.4.11 at TDB.1_4.11 >> >> symbol, it now also adds >> >> ??TDB_1_4_11 at TDB_1_4_11 >> >> (with dots replaced with underscores), but for single version >> only. >> >> It doesn't look right :) >> >> Thanks, >> >> /mjt >> > > I suspect this is related to commit > 0bc5b6f29307ce758774c1b2f48ce62315fdc7f9 (and > https://bugzilla.samba.org/show_bug.cgi?id=15673). But I couldn?t say > whether the new symbol is correct or not.Oh. Would r'[^.\w]' in the re.sub() be right? Or are there other characters other than '.' and numbers and letters that we need to preserve? Or do we need to treat version and libname differently? Douglas