samba - Aug 2024 - 4.21-rc: ldb_version.h is missing

On 30/07/24 22:20, Michael Tokarev via samba wrote:
> When building libldb as public library, its install target does not
> install ldb_version.h header file, which is included from ldb.h, so
> the resulting header files are unusable.
It may be that 625fb48326ec62a33ce0abdbfb0f6f3d33d7cc64 accidentally reversed
the logic:

                             target='include/ldb_version.h',
                             public_headers='include/ldb_version.h',
-                            public_headers_install=not private_library)
+                            public_headers_install=not
bld.env.ldb_is_public_library)

     t.env.LDB_VERSION = LDB_VERSION

from "not private" to "not is_public"?

Douglas

31.07.2024 08:30, Douglas Bagnall via samba ?????:
> On 30/07/24 22:20, Michael Tokarev via samba wrote:
>> When building libldb as public library, its install target does not
>> install ldb_version.h header file, which is included from ldb.h, so
>> the resulting header files are unusable.
> 
> It may be that 625fb48326ec62a33ce0abdbfb0f6f3d33d7cc64 accidentally
reversed the logic:
> 
>                               target='include/ldb_version.h',
>                              
public_headers='include/ldb_version.h',
> -                            public_headers_install=not private_library)
> +                            public_headers_install=not
bld.env.ldb_is_public_library)
> 
>       t.env.LDB_VERSION = LDB_VERSION
> 
> from "not private" to "not is_public"?
The logic suggests
"public_headers_install=bld.env.ldb_is_public_library"
(without the "not" part).  Lemme see... yes, the "not"
should be removed
and it works fine.

Thanks,

/mjt

-- 
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E  9D8B E14E 3F2A 9DD7 9199  28F1 61AD 3D98 ECDF
2C8E
Old key: rsa2048/457CE0A0804465C5  6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044
65C5
Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt