Adrian Bunk
2005-Dec-19 10:28 UTC
[Samba] [patch] fs/smbfs/proc.c: fix data corruption in smb_proc_setattr_unix()
From: Maciej W. Rozycki <macro@linux-mips.org> This patch fixes a data corruption in smb_proc_setattr_unix() (smb_filetype_from_mode() returns an u32, and there are only four bytes reserved for it in data. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- linux-2.6.14-rc3-git3/fs/smbfs/proc.c 2005-10-04 19:24:37.000000000 +1000 +++ .6877.trivial/fs/smbfs/proc.c 2005-10-04 19:29:50.000000000 +1000 @@ -3113,7 +3113,7 @@ smb_proc_setattr_unix(struct dentry *d, LSET(data, 32, SMB_TIME_NO_CHANGE); LSET(data, 40, SMB_UID_NO_CHANGE); LSET(data, 48, SMB_GID_NO_CHANGE); - LSET(data, 56, smb_filetype_from_mode(attr->ia_mode)); + DSET(data, 56, smb_filetype_from_mode(attr->ia_mode)); LSET(data, 60, major); LSET(data, 68, minor); LSET(data, 76, 0);